From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54462 invoked by alias); 17 Oct 2017 18:17:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54399 invoked by uid 89); 17 Oct 2017 18:17:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 18:17:10 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1506FC05169E; Tue, 17 Oct 2017 18:17:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1506FC05169E Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7AF5C79019; Tue, 17 Oct 2017 18:17:06 +0000 (UTC) Subject: Re: [PATCH 2/2] GDB test suite: Get core files on targets with systemd-coredump To: Andreas Arnez References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-3-git-send-email-arnez@linux.vnet.ibm.com> <38b0202f-5c78-a8bb-7bc8-e86f3a02ca33@redhat.com> <83a0ce4e-d236-2095-0a3f-e2298998cabf@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 17 Oct 2017 18:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <83a0ce4e-d236-2095-0a3f-e2298998cabf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00539.txt.bz2 On 10/17/2017 07:14 PM, Pedro Alves wrote: > On 10/17/2017 07:08 PM, Pedro Alves wrote: > >> Not sure, really. It seems like the "best effort" results in >> racy tests, e.g., if "coredumpctl" returns an old dump, or >> if coredumpctl decides to rate-limit core dump generation (which >> according to the docs, it does). It very much sounds like that >> can lead to hard to diagnose problems and send GDB hackers tilting >> at windmills. > > I should add that I won't oppose this too strongly _if_ we make > the warning not easily lost in the noise, like e.g., maybe tacked > to the end of all test runs, near the final test results summary? Another approach would be to not run the core tests by default, unless you specify some make check \ RUNTESTFLAGS="YES_I_KNOW_ALL_ABOUT_SYSTEMD_COREDUMP_RUN_THE_TESTS_ANYWAY_MKAY=1" option. (and then the testsuite would print a warning suggesting that.) Thanks, Pedro Alves