From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 59F803890408
 for <gdb-patches@sourceware.org>; Thu, 11 Jun 2020 03:09:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 59F803890408
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id E739D1E791;
 Wed, 10 Jun 2020 23:09:04 -0400 (EDT)
Subject: Re: [PATCH][PR build/26068] MinGW build failed due to ws2_32
 dependency
To: Adam Mitz <mitza@objectcomputing.com>, gdb-patches@sourceware.org
References: <81f58912-c143-9387-79e6-f109f8c954ae@objectcomputing.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <eca41b65-a45e-4017-3e47-79b47fc00271@simark.ca>
Date: Wed, 10 Jun 2020 23:09:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <81f58912-c143-9387-79e6-f109f8c954ae@objectcomputing.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, BODY_8BITS,
 GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jun 2020 03:09:06 -0000

On 2020-06-07 10:01 p.m., Adam Mitz wrote:
> gdb/ChangeLog:
> 2020-06-07  Adam Mitz  <mitza@objectcomputing.com>
> 
>         PR build/26068
>         * Makefile.in: fixed library dependency order
> 
> ---
>  gdb/Makefile.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index c3e074b21f..dee3c89c8e 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -611,8 +611,8 @@ CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(LIBCTF) $(ZLIB) \
>      $(XM_CLIBS) $(GDBTKLIBS) \
>      @LIBS@ @GUILE_LIBS@ @PYTHON_LIBS@ \
>      $(LIBEXPAT) $(LIBLZMA) $(LIBBABELTRACE) $(LIBIPT) \
> -    $(LIBIBERTY) $(WIN32LIBS) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> -    $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS)
> +    $(LIBIBERTY) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> +    $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS) $(WIN32LIBS)
>  CDEPS = $(NAT_CDEPS) $(SIM) $(BFD) $(READLINE_DEPS) $(LIBCTF) \
>      $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU)
>  
> -- 
> 

Hi Adam,

I think I can guess the reason for the patch, but please expand your commit message.  When
fixing a build failure, please at least quote the relevant portion of the build failure
(I'm guessing here it's undefined symbol at link time, something like that).  And for bonus
points, to help people agree with your change, you can explain why that happens, and how
your fix fixes it.

Simon