* [PATCH][PR build/26068] MinGW build failed due to ws2_32 dependency
@ 2020-06-08 2:01 Adam Mitz
2020-06-11 3:09 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Adam Mitz @ 2020-06-08 2:01 UTC (permalink / raw)
To: gdb-patches
gdb/ChangeLog:
2020-06-07 Adam Mitz <mitza@objectcomputing.com>
PR build/26068
* Makefile.in: fixed library dependency order
---
gdb/Makefile.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index c3e074b21f..dee3c89c8e 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -611,8 +611,8 @@ CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(LIBCTF) $(ZLIB) \
$(XM_CLIBS) $(GDBTKLIBS) \
@LIBS@ @GUILE_LIBS@ @PYTHON_LIBS@ \
$(LIBEXPAT) $(LIBLZMA) $(LIBBABELTRACE) $(LIBIPT) \
- $(LIBIBERTY) $(WIN32LIBS) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
- $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS)
+ $(LIBIBERTY) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
+ $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS) $(WIN32LIBS)
CDEPS = $(NAT_CDEPS) $(SIM) $(BFD) $(READLINE_DEPS) $(LIBCTF) \
$(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU)
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][PR build/26068] MinGW build failed due to ws2_32 dependency
2020-06-08 2:01 [PATCH][PR build/26068] MinGW build failed due to ws2_32 dependency Adam Mitz
@ 2020-06-11 3:09 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2020-06-11 3:09 UTC (permalink / raw)
To: Adam Mitz, gdb-patches
On 2020-06-07 10:01 p.m., Adam Mitz wrote:
> gdb/ChangeLog:
> 2020-06-07 Adam Mitz <mitza@objectcomputing.com>
>
> PR build/26068
> * Makefile.in: fixed library dependency order
>
> ---
> gdb/Makefile.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index c3e074b21f..dee3c89c8e 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -611,8 +611,8 @@ CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(LIBCTF) $(ZLIB) \
> $(XM_CLIBS) $(GDBTKLIBS) \
> @LIBS@ @GUILE_LIBS@ @PYTHON_LIBS@ \
> $(LIBEXPAT) $(LIBLZMA) $(LIBBABELTRACE) $(LIBIPT) \
> - $(LIBIBERTY) $(WIN32LIBS) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> - $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS)
> + $(LIBIBERTY) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> + $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS) $(WIN32LIBS)
> CDEPS = $(NAT_CDEPS) $(SIM) $(BFD) $(READLINE_DEPS) $(LIBCTF) \
> $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU)
>
> --
>
Hi Adam,
I think I can guess the reason for the patch, but please expand your commit message. When
fixing a build failure, please at least quote the relevant portion of the build failure
(I'm guessing here it's undefined symbol at link time, something like that). And for bonus
points, to help people agree with your change, you can explain why that happens, and how
your fix fixes it.
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-11 3:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 2:01 [PATCH][PR build/26068] MinGW build failed due to ws2_32 dependency Adam Mitz
2020-06-11 3:09 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).