From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by sourceware.org (Postfix) with ESMTPS id 5BF123858D34 for ; Thu, 23 Sep 2021 19:32:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BF123858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f50.google.com with SMTP id w29so20220793wra.8 for ; Thu, 23 Sep 2021 12:32:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dYsF6vVqeEdiyqjF0Nc0ZB5ComQDS1fmejAbkq3QdHY=; b=d11OtQpXdInjGM+VFZZi2t84zMuSXCFBS398bq2LGG2l2UVazOLxhyQwxRvWYpj40q ppUHH7fOMBhRDeLiUh6YkKlGPigmxWzsNQfgQm5ThyK9ntOikm7ZUsA2cwHAJ0XX/qa7 P8LS1Y53E5BYB/MNTMfV2N6c3ztJ7cZ883d+bbgsimM8b85pdaNL0MgManhFzC9BnEQd purVyCOy4WwqvWggFgqtcQRNtTcgm0SG8qe5JjNmn6yRjJBhjxzFN4OXZPvgV33DBLEJ MZOAGgkysNL9hlWR8S62OUKQiEwGjjTYDvHygfbXAiRVtpWn1q1IM1etH2ZZfwj5Wxn0 98Gg== X-Gm-Message-State: AOAM53088un8QJEautN7VoEQw4ER3MNZrV2NcUY7PRRpD3vyUC2hQOvZ gi6erE4ezGUKr7kQu+6D0pnSjt2mQI4= X-Google-Smtp-Source: ABdhPJwDNeKxQvBC9i1V75zar6i1B02yW8N/gQPpoRQO0rK/yJZ6SQPZJLiwZKohwwE3Fnt3OwJqag== X-Received: by 2002:a05:6000:1090:: with SMTP id y16mr7203430wrw.208.1632425518636; Thu, 23 Sep 2021 12:31:58 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id 20sm11077453wme.46.2021.09.23.12.31.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 12:31:57 -0700 (PDT) Subject: Re: [PATCH 2/3] gdb: add "maint set/show selftest verbose" commands and use process_options From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210923135651.1651552-1-simon.marchi@efficios.com> <20210923135651.1651552-2-simon.marchi@efficios.com> Message-ID: Date: Thu, 23 Sep 2021 20:31:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210923135651.1651552-2-simon.marchi@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 19:32:03 -0000 On 2021-09-23 2:56 p.m., Simon Marchi via Gdb-patches wrote: > From: Simon Marchi > > I saw the new -verbose switch to "maint selftests" and thought it would > be nice for it to use the option framework. For example, that makes > having completion easy. It's not that high value, given this is a > maintenance command, but I had never used the framework myself, so it > was a good way to practice. > > This patch also adds the "maint set/show selftest verbose" setting. It > would be possible to use option framework without adding the setting, > but using the framework makes adding the option almost trivial, so I > thought why not. > Yay! Thanks for doing this. Looks right to me. Now we could have a completer for the unit tests names. :-) The param is a regexp, but completing as simple string matching the test names I think would be still nice. Oh gosh, now that I write this I actually look at patch #3. Wohoo! I've wanted that before.