From: Paulo Neves <ptsneves@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 4/4] gdb/python doc: Move unwinder skeleton code
Date: Fri, 3 Jun 2022 18:38:49 +0200 [thread overview]
Message-ID: <ed0011a4-2a33-55de-7a1d-cf6b76a45f4c@gmail.com> (raw)
In-Reply-To: <83wndxbtwn.fsf@gnu.org>
On 6/3/22 18:20, Eli Zaretskii wrote:
>> Date: Fri, 3 Jun 2022 18:01:39 +0200
>> From: Paulo Neves via Gdb-patches<gdb-patches@sourceware.org>
>> Cc: Paulo Neves<ptsneves@gmail.com>
>>
>> +@subheading Registering a Unwinder
>> +
>> +An object file, a program space, and the @value{GDBN} proper can have
>> +unwinders registered with it.
>> +
>> +The @code{gdb.unwinder} module provides the function to register a
>> +unwinder:
>> +
>> +@defun gdb.unwinder.register_unwinder (locus, unwinder, replace=False)
>> +@var{locus} is specifies an object file or a program space to which
> ^^
> The "is" part should be deleted.
>
>> +@var{unwinder} is added. Passing @code{None} or @code{gdb} adds
>> +@var{unwinder} to the @value{GDBN}'s global unwinder list.
> First, @value{GDBN}, not @code{gdb}.
>
> And also, this sentence doesn't read well ("passing None or gdb
> adds..."), I guess it's some typo or missing or redundant word.
>
> Thanks.
This patch is purely a move from one place to another, as suggested by Andrew.
The issues you mention are not introduced in this patch, but i will try to
fix the issues you mention on another commit and then rebase this patch on top of it.
Paulo Neves
next prev parent reply other threads:[~2022-06-03 16:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 11:55 python unwinder doc improvement Paulo Neves
2022-05-28 11:55 ` [PATCH 1/2] gdb/python doc: Add register_unwinder to code example Paulo Neves
2022-05-28 12:20 ` Eli Zaretskii
2022-06-21 11:17 ` Paulo Neves
2022-06-21 12:19 ` Eli Zaretskii
2022-09-30 11:59 ` Paulo Neves
2022-09-30 12:25 ` Eli Zaretskii
2022-05-28 11:55 ` [PATCH 2/2] gdb/python doc: Add enable property to the unwinder example Paulo Neves
2022-05-28 12:22 ` Eli Zaretskii
2022-05-28 13:35 ` Paulo Neves
2022-05-28 13:29 ` [PATCH v2 1/3] gdb/python doc: Add register_unwinder to code example Paulo Neves
2022-05-28 13:29 ` [PATCH v2 2/3] gdb/python doc: Add enable property to the unwinder example Paulo Neves
2022-05-30 9:57 ` Andrew Burgess
2022-06-03 15:54 ` Paulo Neves
2022-05-28 13:29 ` [PATCH v2 3/3] gdb/python doc: Fix confusion between gdb.unwinders and gdb.unwinder Paulo Neves
2022-05-30 9:33 ` Andrew Burgess
2022-05-30 9:55 ` [PATCH v2 1/3] gdb/python doc: Add register_unwinder to code example Andrew Burgess
2022-05-30 10:12 ` Paulo Neves
2022-06-03 16:01 ` [PATCH v3 1/4] " Paulo Neves
2022-06-03 16:01 ` [PATCH v3 2/4] gdb/python doc: Add enable property to the unwinder example Paulo Neves
2022-06-03 16:17 ` Eli Zaretskii
2022-06-03 16:01 ` [PATCH v3 3/4] gdb/python doc: Fix confusion between gdb.unwinders and gdb.unwinder Paulo Neves
2022-06-03 16:17 ` Eli Zaretskii
2022-06-03 16:01 ` [PATCH v3 4/4] gdb/python doc: Move unwinder skeleton code Paulo Neves
2022-06-03 16:20 ` Eli Zaretskii
2022-06-03 16:38 ` Paulo Neves [this message]
2022-09-30 14:50 ` Pedro Alves
2022-09-30 15:53 ` Eli Zaretskii
2022-09-30 16:41 ` Pedro Alves
2022-09-30 17:37 ` Eli Zaretskii
2022-10-21 21:07 ` Pedro Alves
2022-10-22 6:41 ` Paulo Neves
2022-10-22 6:41 ` Paulo Neves
2022-06-03 16:17 ` [PATCH v3 1/4] gdb/python doc: Add register_unwinder to code example Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0011a4-2a33-55de-7a1d-cf6b76a45f4c@gmail.com \
--to=ptsneves@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).