From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id A9CCF38582AF for ; Fri, 3 Jun 2022 16:38:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9CCF38582AF Received: by mail-lf1-x131.google.com with SMTP id y32so13459239lfa.6 for ; Fri, 03 Jun 2022 09:38:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=9f1iv2Yg33hEpcFux4GmGH1zDhdAycV0fkcXh4KfZEg=; b=7IrTVI4OMi0TGJewhxmQ8kAsNBjigysBHjs62qyuau8yQFjqVr/YD7zvcgpCELAWlf u+UgAPvykQoHixpBgGyK/OMxi4cqFhA2ITa004K19zFHLh+VGGopXZsZqw29/Gk44Tqc GWTpVu4e0MwMEzHdNXcsdgb3FmJk3alcgWQTZHInGg/o8/zsiV9OrLnz3IKp4Zi5dHhH 5w1cQ5kA25P+CaPVFVUZkQ7kXCGWpOkbDqSFWD6zq8xGmWoWjrrn5A8jmnw+qSF/6qPP jfaL1yfcoJlRl3RU4tzsffkgWlhp2yAkCGNPHoJDw2rrqLahARwvB4vra7gg8alqa7kJ 6v4A== X-Gm-Message-State: AOAM530HedqTzDYfwCkD+ePAOMKhCVsupMR2LrZEdeUKqjg727WnLcQ+ x9Cxf7tZiGDyE1QZmtrgAh7jZc0WAA== X-Google-Smtp-Source: ABdhPJwcA08tZ3SzSuQ7lBcON4lHR0zRPuXM45PhYGnLC6oM1uQYLgmXJhzNxe5ZUpv1WuUvyDOt/g== X-Received: by 2002:ac2:4f0c:0:b0:477:cb8e:bd8b with SMTP id k12-20020ac24f0c000000b00477cb8ebd8bmr48704238lfr.209.1654274331178; Fri, 03 Jun 2022 09:38:51 -0700 (PDT) Received: from [10.67.202.36] (85-128-83-172.static.ip.netia.com.pl. [85.128.83.172]) by smtp.gmail.com with ESMTPSA id a12-20020a19ca0c000000b0047915250d98sm736639lfg.272.2022.06.03.09.38.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jun 2022 09:38:50 -0700 (PDT) Message-ID: Date: Fri, 3 Jun 2022 18:38:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 4/4] gdb/python doc: Move unwinder skeleton code Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220603160139.136115-1-ptsneves@gmail.com> <20220603160139.136115-4-ptsneves@gmail.com> <83wndxbtwn.fsf@gnu.org> From: Paulo Neves In-Reply-To: <83wndxbtwn.fsf@gnu.org> X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2022 16:38:54 -0000 On 6/3/22 18:20, Eli Zaretskii wrote: >> Date: Fri, 3 Jun 2022 18:01:39 +0200 >> From: Paulo Neves via Gdb-patches >> Cc: Paulo Neves >> >> +@subheading Registering a Unwinder >> + >> +An object file, a program space, and the @value{GDBN} proper can have >> +unwinders registered with it. >> + >> +The @code{gdb.unwinder} module provides the function to register a >> +unwinder: >> + >> +@defun gdb.unwinder.register_unwinder (locus, unwinder, replace=False) >> +@var{locus} is specifies an object file or a program space to which > ^^ > The "is" part should be deleted. > >> +@var{unwinder} is added. Passing @code{None} or @code{gdb} adds >> +@var{unwinder} to the @value{GDBN}'s global unwinder list. > First, @value{GDBN}, not @code{gdb}. > > And also, this sentence doesn't read well ("passing None or gdb > adds..."), I guess it's some typo or missing or redundant word. > > Thanks. This patch is purely a move from one place to another, as suggested by Andrew. The issues you mention are not introduced in this patch, but i will try to fix the issues you mention on another commit and then rebase this patch on top of it. Paulo Neves