Re: [PATCH] [gdb/python] Make gdb.UnwindInfo.add_saved_register more robust

[Tom de Vries <tdevries@suse.de>]

On 5/8/24 17:52, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> @@ -362,6 +362,18 @@ unwind_infopy_add_saved_register (PyObject *self, PyObject *args, PyObject *kw)
> Tom>        return nullptr;
> Tom>      }
>   
> Tom> +  if (value->optimized_out () || !value->entirely_available ())
> Tom> +    {
> 
> Both of these seem to have cases where they can throw an exception.
> In the Python layer, gdb code that can throw normally has to be wrapped
> in a try/catch, as throwing across the Python boundary will cause crashes.
> 
> I don't know whether exceptions can actually be provoked here or not.

Hi Tom,

thanks for the review.

Submitted fix here ( 
https://sourceware.org/pipermail/gdb-patches/2024-May/209032.html ).

Thanks,
- Tom