From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E6FB23858430 for ; Wed, 8 Dec 2021 03:13:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6FB23858430 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1B83DffH025005 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Dec 2021 22:13:45 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1B83DffH025005 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 294CB1E940; Tue, 7 Dec 2021 22:13:41 -0500 (EST) Message-ID: Date: Tue, 7 Dec 2021 22:13:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCHv2 2/2] gdb/python: add Type.signedness attribute Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <5e9277cbad4e17099261ddc413bfb7471d3eb4f9.1638799543.git.aburgess@redhat.com> From: Simon Marchi In-Reply-To: <5e9277cbad4e17099261ddc413bfb7471d3eb4f9.1638799543.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 8 Dec 2021 03:13:41 +0000 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 03:13:49 -0000 > +@vindex TYPE_SIGNEDNESS_NONE > +@item gdb.TYPE_SIGNEDNESS_NONE > +This type is considered neither signed, or unsigned. This applies to > +all non-scalar types (e.g.@: c language structs), but can sometimes be > +the value return for scalar type, one example of where this can be > +seen is in C++, where @code{char}, @code{signed char}, and > +@code{unsigned char} are all considered distinct types. I'm curious, why would type `unsigned char` not return gdb.TYPE_SIGNEDNESS_UNSIGNED? I see the corresponding code in gdbtypes.c, with the m_flag_nosign flag, so I understand that you would implementation the Python binding based on that, but I am wondering about the historical reason. Simon