From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 650D73858C83 for ; Mon, 28 Feb 2022 15:36:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 650D73858C83 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-374-bZJyROn5Me-d8-_LKYzh4w-1; Mon, 28 Feb 2022 10:36:00 -0500 X-MC-Unique: bZJyROn5Me-d8-_LKYzh4w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 731FA8031E1 for ; Mon, 28 Feb 2022 15:35:59 +0000 (UTC) Received: from [10.2.17.55] (unknown [10.2.17.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5DF0866D8 for ; Mon, 28 Feb 2022 15:35:57 +0000 (UTC) Message-ID: Date: Mon, 28 Feb 2022 07:35:56 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Fix gdb.fortran "failed to extract expected results" errors To: Keith Seitz via Gdb-patches References: <20220224174100.1620375-1-keiths@redhat.com> <87k0dioq6s.fsf@tromey.com> <4f0def89-1a03-3d2c-15a0-572f0bb7566a@polymtl.ca> From: Keith Seitz In-Reply-To: <4f0def89-1a03-3d2c-15a0-572f0bb7566a@polymtl.ca> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 15:36:03 -0000 On 2/25/22 08:48, Simon Marchi via Gdb-patches wrote: > > > On 2022-02-25 11:40, Tom Tromey wrote: >>>>>>> "Keith" == Keith Seitz via Gdb-patches writes: >> >> >> Keith> This patch skips these tests when running on non-native targets. >> >> Looks good to me. > > An alternative would be to change those tests to not rely on inferior IO. > > They could perhaps save the expected outcome to a string, which GDB would > read, rather than printing it to stdout. > > But, that takes some time, and most importantly, someone who knows > Fortran :). So I also think your patch is ok. Oh, you got me! :-) That's a good point, though. I will see if I can update this test, but in the meantime, I've pushed this change. All these errors are interfering with our Fedora CI efforts. Thank you, Tom and Simon! Keith