From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2047.outbound.protection.outlook.com [40.107.101.47]) by sourceware.org (Postfix) with ESMTPS id 7464D3858D20 for ; Tue, 15 Feb 2022 10:53:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7464D3858D20 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxfHIfJg1ga1r6nZnTWgUJ0Nn0x0wWod5kr4ClkZ18EpuM1aV+5B+QJtMW7wtdXUjSVAQi7KRRfZ4RDglHgyhB5Yal/DDvY85Fj7F43EVqKqJBtU+aixbP9OSDdHea6z4/opCMvRU8AvCUfqni3F+Vl9JfJTpEZ7rfhmBXJ3MKLL4+vf+H/+zKD1mLhZsYJ/kjGjvssK66UjHqTTaMqsqQZfDxrYLqNuZX0MAwk4zIJ6f6f/HKxOWybmG58Xhn2RXXN+PJvvzn0kx8K6SuYxQtvndMDHoyHzdZFtVSkvJSChFdUcYd1ajJras8Bm3vFUxlFRZg76iDBXWCsrgVxxrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+17i/P82wK5O65DQ7L0P0U62DQW/+k85w3M4B/1NxiQ=; b=ScdqAiyeFyQtK2hgiEaWMVqsoiiCu6Km6p9alMzsl+sDClpDWTNYfjZqqkvkRmsuuRa17SDZ9MGxclP34JpwCR26jJE7q9q/EJIYXFGFJ2H8rMi4Za4DHURDqEwdAvYQVxDz3fE5oI0JEo2TyqQUpkYC9saEAzkiHGQj5byeSntixLBgfjJjbK93gw8imISG9v9e4rSgApuK1rjqBzEzdgalHIuh4ga3EU33ybgdZ7XBuOh5XzUdf53BTHvuzDXwTeh/DK/ibpmG8FuLLrWH6roPzFpeiqc0fpJm+xaydDQDvd5yadP41RjlF1ANHf5v1MIVH9uZHgu+GGOPfZi26A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from CO6PR12MB5442.namprd12.prod.outlook.com (2603:10b6:5:35b::22) by BYAPR12MB4695.namprd12.prod.outlook.com (2603:10b6:a03:a4::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb 2022 10:53:44 +0000 Received: from CO6PR12MB5442.namprd12.prod.outlook.com ([fe80::c560:8bdd:6486:6b3c]) by CO6PR12MB5442.namprd12.prod.outlook.com ([fe80::c560:8bdd:6486:6b3c%7]) with mapi id 15.20.4975.011; Tue, 15 Feb 2022 10:53:44 +0000 Message-ID: Date: Tue, 15 Feb 2022 10:53:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 2/2] gdb: Respect the DW_CC_nocall attribute Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20220202184115.83396-1-lancelot.six@amd.com> <20220202184115.83396-3-lancelot.six@amd.com> From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0118.eurprd06.prod.outlook.com (2603:10a6:20b:465::20) To CO6PR12MB5442.namprd12.prod.outlook.com (2603:10b6:5:35b::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97d30c25-31ae-42e5-2d09-08d9f0716f7c X-MS-TrafficTypeDiagnostic: BYAPR12MB4695:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nl8o87SlTvgHTuBeG+e22DCaS+rbFQwvIUoZo1aHAqyS9QwwvLG1UGrgZtswFbr8JUaZ3j6dgUemnSy7zQ5jyU0NovHdmxREiZ1vT8revNF9twqeNgXmBcuKxXDypatb60Fski230sk0fYlUsn+KJk0mOUNCXEjFdnhKpn/1RTsXg32iHYQka+K3TymYM+gNLr5+umTbOpfGAexLWZae/Fw8vVV6UsBHrmFrhadRlmo6obfFEpBhsNDLAqLSZg+aGHSnKI3CHbkmu50hJG1kBPAb5BHqBV0eRV2yxsftCAd8hig442kgQxFQ+vs8fDs6b04wVrtXDKX9LWf3xkY70O/jLqlSIOKmt9Vg7l8/BS06r/9UXa9Gl0qbizBOVuBU8DfwLYFmXnhuBXRbTDDTf51WZMOIveY/AbzXtqK1O7JfQKW4sV+0+l4BD03JWObgnbBkwrCZx3T9oW6KUDkpXalg11N0Jhw4/KZSQjDl3BXWzNPBdCOw0ykwweC6T+zElo7e0xwBDlmnTu6jJgpWLp6PxBn4pDs4g2fhxlJC9cAbcOFlVNsU5Bg8LXD85TgSRU+kD63V6eP6oYZizA2jZDYfDTqBfJTY7XmzalKiAmQbnReQ+MlR1lwUM+EJ6d6wazjYmKKl/xwDdohljJGREOpulYSOVsc8b/xTrmFAbdgsZCiA3dB6fkZD1CtkxhEmFY4xN4yf8mZLHoD4i3BA2tJh9ZiJwkYPsvlFj/FYRZr51ZkY/dUz1WWMLLbTW58M X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5442.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6666004)(2906002)(83380400001)(508600001)(6486002)(31686004)(5660300002)(4744005)(36756003)(66556008)(66476007)(4326008)(86362001)(8676002)(66946007)(8936002)(316002)(6512007)(2616005)(186003)(6506007)(38100700002)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFJPRUpadW9mVFM5aWRkdGcweGlGQ3B2OHlrZUZva3NrYmx0ZStiTmtVdnpL?= =?utf-8?B?d1hRZGFNSTBTV0hzZFZaY3NSNFlTbi9pT2dxNzdhMjgwU0dNTHFwQ3Q0YUs5?= =?utf-8?B?TFEwMUZwYUFkM29la0FmNFhKazhNUlJHMGhpTTZvM0NEdXdhQnFtNmhxNDVM?= =?utf-8?B?S2txcmt2dGFhNnlSOXpFcDVxQ2lyTkJ2elUwcE16cFV0K2kvRkEyQkg5T3BE?= =?utf-8?B?MVlMcTgydmFRYVp0SWVQdSt6dGRJSlVmalBzZHBFazFBUFhQRmZQQSttclRI?= =?utf-8?B?Tys5NHhiakZsZWlIUkRFMUpwMjBOamJQWHR0TTg4c0xZd2thZTdOMXYwcHNy?= =?utf-8?B?dzZ2Z25BemQyOUNxbS95K3pLM253SzhYL253UHFDUEg4eTlLZnBPc2pvYzRu?= =?utf-8?B?RVpsald0L2FWQ0tFUFMwdGhmS2ZIa2ljZWYvUGRtd0Q4V1ArNGNyellEMm9J?= =?utf-8?B?MFVDVlVUcUphTzNLSnd3bmhEYTNXbmJZQjZKcy9sREFIUDB2OU1RZWs0aXNQ?= =?utf-8?B?YjcvQ2lhQURLZUhjWWJ3Kzh1QmQyU0VIODhGdW5SSUlOeUVGRkpicGVwWXpN?= =?utf-8?B?eHA1NVJPVlFkVnhpcDNrTTdXUHM1MlB1U3JxMFZ6OE40QUFIaFNWdVNFU1Bi?= =?utf-8?B?dUZoYllsUjNFdjRmMkRZUXlRYStzaG5uVDdGMDRsdUZmdE5hMmFQdnZJSUZE?= =?utf-8?B?WXVWUFRFTTYrbitBa2lwS3UwOUJjMWRoR1FTRFlpK1AwQXBycUs5bXF1SU5i?= =?utf-8?B?STF4MFlWTVJIbTVjRWFLa25NRm9xaHQ0TStjZTh6YncwZEhUYTNJTWVHbmdO?= =?utf-8?B?ekpJb3JzRVgyYVMwdWp6TEM2NklUUlRiaklaSEg2dGFmaHUwVkFJZ2h3MXVU?= =?utf-8?B?UmlGaWFHalRjelhkNGRTUWF5QkRiS1dWQXBySEdMQ2p6NC9XL2RaMGFYWUF1?= =?utf-8?B?S05pVGFwRytYblYxdGo3S1N4WjBGdlZHc3liL0pnWlVVaGYzL3J2S1RTZm93?= =?utf-8?B?a3lhbHFRQ0QrRWtrWmNBY2hNTUZVUUFLdFVieTFIdTRLZVFNbmJCKzZKRlh5?= =?utf-8?B?T2VCVWpjOXZlVEZjeG5MeDNCcmpKa1hjMXduSVgrNjAzVTJ3eFUxbmNlMWRF?= =?utf-8?B?WGhXTHRJaXJHT1kvR0FyT3NHeXVVbURqY3RvQjRmcm5KdDhnWU9EbW1ZcTEr?= =?utf-8?B?VTErbEF3NE9tQmJJT2g1ak9jVGhncDR5bUY1bWUxd1NWUXVhRGNGYTJhU3hJ?= =?utf-8?B?MGhtUGtzN1ZsN3oxa2pwbzJJMVl2dC96eGhGak1xcElOSHV0ZWM0ZldWUU5N?= =?utf-8?B?NEFkcnc4WmZLWlM3eDBISGRHV2dtbmMwVVFlYzlXVG9mQ3pZejFUZC9XOWdx?= =?utf-8?B?MVE2ZldHSmlvdFFQa01qeVo5K1hqOHVNLzZZUm1lV2hGNVo3MVNSODA4S1Bh?= =?utf-8?B?cXhZd0EvUGFKcEN4bEhpRW5zZ0cyaTBaaXZsb0hkb0JZWkNLRXRjdTM3S1pv?= =?utf-8?B?L3RheTgzTllySHZDelR1ZkkwQTFYc0ZHd0lNdE5VY01lVWVlSHcwK20wUVpK?= =?utf-8?B?WSt4ZVVWcDFFWHJBQjVQR1oyd3htalYrRld4T0tKKzlqRFVqTy82ZHhnV1N3?= =?utf-8?B?ZTUyQldUQW8xZUJya09ESnJKYk1YMmNZTW5SYzZaWFdiSlV4dXI3KzNYaGxm?= =?utf-8?B?TS8zZGZWZEJ6MlFiMU1VNWJDYW5PanZra3lPeFJEWTlHUEdEOXNldEs5YzVy?= =?utf-8?B?UUh5bGFzLzUyYjBYdW9vTWhKZG52UUpGbjNPaVNuTytkVllkNDMyeFB5RnJG?= =?utf-8?B?SklhZ0RoclBEbFlyc1R1K1dpWEpnYi82WHVsTk42VXdodzM1MVBySVF4TjRC?= =?utf-8?B?ZUFrcG5kY3BIQUMza2htMUNCUGd6WVI5Y0pacnVmYWpkRHpwZ29kZW4zSjhM?= =?utf-8?B?UG9vZVFQaTBPNVJBc2o1UVNEOUJWelJOUkhaa0JzVGZTcnpFYWQ2MmlEeVZD?= =?utf-8?B?eWpQNmMwN1Y4UnAzTzUvZmpFWUJNMWlBSmFSMFVHQmR6TFpYRVhLYi84ZzI4?= =?utf-8?B?U0hJcjRYSytERGtPNUEyTmIzcFlZM1Y5NmhnLzU0aHhQeStiOHpGUytkanBM?= =?utf-8?B?a3dBcWgzU0FMeTlQR2Nlei82N3BwZU9HVEhxd0pvLy9NNHh1ZFNVVHlRYUxG?= =?utf-8?B?WVpDeXpTSksrMHp0Ym54Y1kxNXVwQ0NVYTlnVmhFQ2xrbjE0YldlT05lODI5?= =?utf-8?Q?uhL+hOxtOIBAVuQ0eGd5bGQOdPeiAR3iEdzz2EvxOw=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97d30c25-31ae-42e5-2d09-08d9f0716f7c X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5442.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 10:53:44.7639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /3Gt+KqnTEXe7C8TUHBiKmcM7T7PTFeQ4Jr386gKbyS2RxbWMB018NNg4fraYkaYy+0Y86wbh5F69qWL8M06RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4695 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2022 10:53:49 -0000 Hi >> +# This testcase checks that if a function has the DW_AT_calling_convention >> +# attribute with the value DW_CC_nocall, then will not: > > I think we are missing a word in the sentence above. Fixed > > LGTM otherwise. > I pushed the series with: - The final adjustments requested (on comments), - Rebased on top of current master, with trivial adjustments to account for 5f9c5a63ce38b103f778f54394c6a3d43b7ade90 (gdb: remove SYMBOL_TYPE macro). Thanks, Lancelot.