Re: [PATCH] [gdb/tui] Handle shared border in fixed-sized layout

[Tom de Vries <tdevries@suse.de>]

On 12/8/23 16:57, Tom Tromey wrote:
> Is there any window with a fixed size other than the status line?

I don't think so, no.

> I wouldn't expect this to be hit currently.

Agreed.

However, I managed to trigger the behaviour using a trigger patch.

Say I have a terminal with 24 lines:
...
$ echo $LINES
24
...
and I show the window sizes of the split layout:
...
$ gdb -q -ex "layout split" -ex "info win"
...
and get:
...
Name       Lines Columns Focus
src            8      80 (has focus)
asm            8      80
status         1      80
cmd            8      80
(gdb)
...

Note that 8 + 8 + 1 + 8 == 25 == 24 + 1, this is due to the shared box 
between src and asm.

Now let's make src and asm fixed-size windows of 8 lines:
...
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 523d0ea832b..61f00b6f6d8 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -91,6 +91,15 @@ struct tui_source_element

  struct tui_source_window_base : public tui_win_info
  {
+  int max_height () const final override
+  {
+    return 8;
+  }
+
+  int min_height () const final override
+  {
+    return 8;
+  }
  protected:
    tui_source_window_base ();
    ~tui_source_window_base ();
...

Instead, we get:
...
Name       Lines Columns Focus
src            8      80 (has focus)
asm            8      80
status         1      80
cmd            7      80
(gdb)
...
and the last line of the terminal is unused.

Then after applying this patch, we're back to the expected:
...
Name       Lines Columns Focus
src            8      80 (has focus)
asm            8      80
status         1      80
cmd            8      80
...

Pushed.

Thanks,
- Tom