From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 745023858D38 for ; Thu, 9 Nov 2023 16:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 745023858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 745023858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699547475; cv=none; b=V3kCVhWG160a+ue7OReNgiQu/5jI3GYO5HxjWuaPVcsNSteyq6m22th41WdrpOuCMrd0XbXHg5+UgG6fOiOY8JKqTXAq7wowFOQfXe9jCV0vOAhS7tUny0qnG7nDpIW7LFJAsXXlDSOA+91Coog2pfHfQcwBU8dVqvnxGxeaspw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699547475; c=relaxed/simple; bh=oOwr0PS4L/g6a6EWAY4exP7IIg/Rdu5L/em1GeaKp5Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=j4myQPwqy5h8OzQ0unY/pW+zojUVum4waWuxdvzQwM0FQH72m13DzEaBw32elg35+Yc+wM8qoq/G+8JuEq0kB1QrkPTYM1yPjmJ0ST/hj5eKCmE+WZWwbCcOzB3aM34Vq29pTDfOBrGYqakCfLSzqU7WfUt/ll7Dd8MGmjYOzgo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1699547474; bh=oOwr0PS4L/g6a6EWAY4exP7IIg/Rdu5L/em1GeaKp5Q=; h=Date:Subject:To:References:From:In-Reply-To:From; b=HqWKuGXPX5vIWFnaPP1WroIs/3xbW4X4+GW++Vu4amKu5lQyXx8wZMZDYG6rB/gy4 Mj3r1xpGXSyB3FYICtxANXILZ+VFKFDeeqXGPma44USZ32QEzzPVSSvm0JBjoNMXTh CRCZOgEBPNqO8HLPlKW72Lqz33VmwfAX9O22q5/o= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CB0931E098; Thu, 9 Nov 2023 11:31:13 -0500 (EST) Message-ID: Date: Thu, 9 Nov 2023 11:31:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] [gdb] Eliminate local var pspace in inferior.c Content-Language: fr To: Tom de Vries , gdb-patches@sourceware.org References: <20231109150021.5504-1-tdevries@suse.de> <20231109150021.5504-3-tdevries@suse.de> From: Simon Marchi In-Reply-To: <20231109150021.5504-3-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/23 10:00, Tom de Vries wrote: > Eliminate local var pspace from functions add_inferior_with_spaces and > clone_inferior_command. > > This interchanges the order of the new program space / new inferior events. > > Update test-case gdb.python/py-progspace-events.exp to reflect that. > > Tested on top of trunk on x86_64-linux and ppc64le-linux. > Tested on top of gdb-14-branch on ppc64-linux. > > Suggested-By: Simon Marchi Sorry, when I suggested this cleanup, I wasn't aware it would have user-visible changes. Since there isn't a need for this except "make the code a little nicer", I retract my suggestion. Simon