From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B718E3858426 for ; Sat, 7 Oct 2023 01:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B718E3858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1696642247; bh=j328ethDWcqB6lVRi6ed3kFUeQe5zC9C4DPCisju7RQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oF6NreqP4791dNwAeRtROUGs4FAn1FwII/bM4UTMH0U9EhmAfXxt8+5ALcQgx6l5i PzFnN3NWjqi3AjzD57ztJmKjjUzlgSdEXhUf/nRyI/g4/YtnnNbqQWO9NAepWPs8MJ bwyL/w5ri6mr9WHTcNexu0mLqQKcBbPY9CUHX5nU= Received: from [10.201.39.111] (209-15-164-2.static.cgocable.ca [209.15.164.2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 90C021E092; Fri, 6 Oct 2023 21:30:46 -0400 (EDT) Message-ID: Date: Fri, 6 Oct 2023 21:30:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: support rseq auxvs To: Tom Tromey , Ilya Leoshkevich via Gdb-patches Cc: Ilya Leoshkevich References: <20230621230304.3971152-1-iii@linux.ibm.com> <875y3nzfvd.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <875y3nzfvd.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/3/23 15:05, Tom Tromey wrote: >>>>>> "Ilya" == Ilya Leoshkevich via Gdb-patches writes: > > Ilya> Linux kernel commit commit 317c8194e6ae ("rseq: Introduce feature size > Ilya> and alignment ELF auxiliary vector entries") introduced two new auxvs: > Ilya> AT_RSEQ_FEATURE_SIZE and AT_RSEQ_ALIGN. Support them in GDB. This > Ilya> fixes auxv.exp on kernels >= v6.3. > > Thank you for the patch. I didn't see a review of this. The patch > looks good to me. > > Can you add this trailer the commit? > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30540 > > Thanks. > > Approved-By: Tom Tromey > > Tom I stumbled on this problem, so I went ahead and pushed the patch. I made a little change, I used AUXV_FORMAT_DEC for both values, I think it's more natural. Simon