From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by sourceware.org (Postfix) with ESMTPS id 99B053858CDB for ; Thu, 20 Jul 2023 11:25:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99B053858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-3fd18b1d924so5166685e9.1 for ; Thu, 20 Jul 2023 04:25:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689852327; x=1690457127; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ETiU5VnqPL18HsAWpvXeRxfD4OHRv2+LoPG+lUrzxAw=; b=WVlbzq1R1rZUBZmndQxk+bAOGPj78tSVlWxuWvnrzYuB1V6tSAb8bciY16OcIqsK/x t4bUmgfcBuXfZD/JsxsFtuDjFePBB8e9WR/IsPyCxh/xxCgX9wbXu8PVVud3d58xzydw SiDZVVz9JTdtl9MAy5ckz/eY/wEz4dZbGotecW18ZJKwkyzFqRF9sil3kWYWQcZbse5L Z7OokVCAgh78RmJJXVLXWwpcR7wm4XFO1kd5kaxsyUiHepUeZhZ7/ltMKgFmQhkyXMyw A3hweMfkkGHorIOOhQBeHjJkfmyXJtQPTO52HdQmQheUC11p3TFdvf7gOLzu3k5AExAJ xDlQ== X-Gm-Message-State: ABy/qLYygLipRih/PAmYIfYjI6U3YIg9HxFJsMjTPGOM6mWJFSOlvqAq Q4/BgNs9bTY7lbCUMeQfzW7nsbomBgo= X-Google-Smtp-Source: APBJJlEEvdkexUJK6cF14XbG9FneKjSJ1SwvN4srED0//9gBa9mK8Xp07UxpLhemL8i+3xsAdL7faw== X-Received: by 2002:a05:600c:2a41:b0:3fb:dff2:9f17 with SMTP id x1-20020a05600c2a4100b003fbdff29f17mr1652292wme.15.1689852327095; Thu, 20 Jul 2023 04:25:27 -0700 (PDT) Received: from ?IPV6:2001:8a0:f91d:bc00:eea7:e191:8788:af32? ([2001:8a0:f91d:bc00:eea7:e191:8788:af32]) by smtp.gmail.com with ESMTPSA id m23-20020a7bcb97000000b003fa96620b23sm3731007wmi.12.2023.07.20.04.25.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 04:25:26 -0700 (PDT) Message-ID: Date: Thu, 20 Jul 2023 12:25:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] gdb/solib-rocm: limit the number of opened file descriptors Content-Language: en-US To: Lancelot Six , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20230720103615.93419-1-lancelot.six@amd.com> From: Pedro Alves In-Reply-To: <20230720103615.93419-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-07-20 11:36, Lancelot Six wrote: > Here is a V2 for > https://sourceware.org/pipermail/gdb-patches/2023-June/200532.html. > > Changes since V1: > - Addressed Pedro's comments. Thank you. > - I have not changed rocm_solib_fd_cache::close to return void as I > really see this a wrapper around target_fileio_close. I however made > sure the caller of rocm_solib_fd_cache::close checks the return value > and issues a warning in case of error. That's totally fine. :-) Approved-By: Pedro Alves