From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 2C1D0387FC02
 for <gdb-patches@sourceware.org>; Wed, 22 Apr 2020 13:45:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C1D0387FC02
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.193] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id DFA411F070;
 Wed, 22 Apr 2020 09:45:31 -0400 (EDT)
Subject: Re: [PATCH][gdb/symtab] Don't create duplicate psymtab for
 forward-imported CU
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
References: <20200408101912.GA32538@delia>
 <5fe7340e-b1c0-c7a5-d6a1-5b39b46d0297@suse.de>
 <e3175991-ba79-1bd9-b5ea-815f6a88226d@suse.de>
From: Simon Marchi <simark@simark.ca>
Message-ID: <edaa17a8-0cd4-b54a-d0cf-c12b33c4acdc@simark.ca>
Date: Wed, 22 Apr 2020 09:45:31 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <e3175991-ba79-1bd9-b5ea-815f6a88226d@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2020 13:45:35 -0000

On 2020-04-22 2:13 a.m., Tom de Vries wrote:
>> [ Forgot to mention ]
>>
>> Using a 2.8GB libxul.so debug file from opensuse tumbleweed, build with
>> lto, we have:
>> ...
>> $ time.sh gdb -batch -iex "maint set dwarf max-cache-age 1000" -iex "set
>> language c" usr/lib/debug/usr/lib64/firefox/libxul.so-74.0-1.1.x86_64.debug
>> maxmem: 10417196
>> real: 116.62
>> user: 114.85
>> system: 2.37
>> ...
>> and with this patch:
>> ...
>> $ time.sh gdb -batch -iex "maint set dwarf max-cache-age 1000" -iex "set
>> language c" usr/lib/debug/usr/lib64/firefox/libxul.so-74.0-1.1.x86_64.debug
>> maxmem: 10436372
>> real: 77.42
>> user: 75.54
>> system: 2.46
>>
>> OK for trunk?

I just glanced at this and... wow, that's a big difference.

Simon