From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id F13173857C5F for ; Sat, 15 May 2021 13:19:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F13173857C5F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14FDJeg6004999 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 15 May 2021 09:19:45 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14FDJeg6004999 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A73B61E813; Sat, 15 May 2021 09:19:40 -0400 (EDT) Subject: Re: [PATCH 3/4] gdb: add new -group-by-binary flag to info sources command To: Andrew Burgess Cc: gdb-patches@sourceware.org References: <760d52a0ea6ab8c2195d71feea794f0bec70a163.1619456691.git.andrew.burgess@embecosm.com> <5f7a72f3-a352-c107-4d10-3fadb7ecee38@polymtl.ca> <20210515084521.GL3067949@embecosm.com> From: Simon Marchi Message-ID: Date: Sat, 15 May 2021 09:19:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210515084521.GL3067949@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 15 May 2021 13:19:40 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 May 2021 13:19:49 -0000 On 2021-05-15 4:45 a.m., Andrew Burgess wrote: > I'm not against changing the output, but I thought as a rule we didn't > significantly change existing command behaviour unless we could show > that the existing behaviour was wrong. > > I guess how do folk feel about changing this behaviour? For the CLI, I think we can have a bit of "artistic freedom" to improve the output, as long as we don't regress use cases. If we all agree the new format is better, I would find it disappointing if the fruit of your work was hidden behind an option, where most people won't know about it and won't use it. Simon