From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id C7E3A3858404 for ; Thu, 12 Oct 2023 18:32:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7E3A3858404 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-32003aae100so1632191f8f.0 for ; Thu, 12 Oct 2023 11:32:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697135576; x=1697740376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0T1Lu5L0vLJRuDZt2DlglZaWTIZLBSMOHfEn3L1mqoo=; b=EUq8Ez1EMaLn7I+jJuaR7IHp1W7gDGDhO96H0FuTfqGsnKhmEWm0NQiTAPtarzUmSL wBwpC0QbB/jaOMMdbN4WxIzmgl5Q0YHz8Z+j4Pe/NjeEt1IaVreg9wu1foHEMKoynDEe 6t1JVXR9m3f2xv3Fxxbn0ibQR8R/TY08yg4vzF9+1aj4gnj7EPwsE+LLMAeQAjlUArj6 wdT+WSSw1I7/La4yR3a3gFM9hclM+fmoJDQUr9hVZI7nMJ2Gu/iKMEe051Jf1Xb/YkCk zo74jjVKzu1WqP75b5EJySdXZHEN47QT98TRd/UNDWmd0Mgj4Il1e/49R9e6donIjUKV pH/A== X-Gm-Message-State: AOJu0Yxqqdbdoh2yyANyGEwUavPJ9V/VdGASDCSGm9fqIJr1BgQQmLTO +quxXz4BR9NByraKwBb4s62SXnTN/P13NA== X-Google-Smtp-Source: AGHT+IFAe6WEQXz05KKcCtJYrrG1OWPe4vdmj+HfbhH/L7+ekZyIoOXm4PkTTNosySmzSMLh2897SA== X-Received: by 2002:a5d:63cc:0:b0:314:c6b:b9a2 with SMTP id c12-20020a5d63cc000000b003140c6bb9a2mr20282074wrw.13.1697135575434; Thu, 12 Oct 2023 11:32:55 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:dedd:c263:b7d3:9ba1? ([2001:8a0:f939:d200:dedd:c263:b7d3:9ba1]) by smtp.gmail.com with ESMTPSA id bv28-20020a0560001f1c00b0032d402f816csm7781504wrb.98.2023.10.12.11.32.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Oct 2023 11:32:54 -0700 (PDT) Message-ID: Date: Thu, 12 Oct 2023 19:32:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Move -lsocket check to common.m4 Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231006132409.2294987-1-tom@tromey.com> <87zg0qv2mv.fsf@tromey.com> From: Pedro Alves In-Reply-To: <87zg0qv2mv.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-10 17:55, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> A user pointed out that the -lsocket check in gdb should also apply to > Tom> gdbserver -- otherwise it can't find the Solaris socketpair. This > Tom> patch makes the change. It also removes a couple of redundant > Tom> function checks from gdb's configure.ac. > > Tom> This was tested by the person who reported the bug. > > BTW this one should probably also go on the GDB 14 branch. > It seems pretty safe, IMO, and it fixes a Solaris build problem. Agreed, for both branches: Approved-By: Pedro Alves