From: Simon Marchi <simon.marchi@polymtl.ca>
To: Felix Willgerodt <felix.willgerodt@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Add half support for AVX512 register view.
Date: Fri, 3 Sep 2021 08:30:49 -0400 [thread overview]
Message-ID: <edec1d0f-b6e5-1bf1-c870-2bf35cd3dc17@polymtl.ca> (raw)
In-Reply-To: <20210729083833.2483704-2-felix.willgerodt@intel.com>
> diff --git a/gdb/features/i386/32bit-sse.c b/gdb/features/i386/32bit-sse.c
> index e5eaf8feb59..5554849a6ca 100644
> --- a/gdb/features/i386/32bit-sse.c
> +++ b/gdb/features/i386/32bit-sse.c
> @@ -10,6 +10,9 @@ create_feature_i386_32bit_sse (struct target_desc *result, long regnum)
>
> feature = tdesc_create_feature (result, "org.gnu.gdb.i386.sse");
> tdesc_type *element_type;
> + element_type = tdesc_named_type (feature, "ieee_half");
ieee_half isn't listed on this page:
https://sourceware.org/gdb/current/onlinedocs/gdb/Predefined-Target-Types.html
Should it?
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2021-09-03 12:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 8:38 [PATCH 0/2] Add AVX512-FP16 support Felix Willgerodt
2021-07-29 8:38 ` [PATCH 1/2] Add half support for AVX512 register view Felix Willgerodt
2021-09-03 12:30 ` Simon Marchi [this message]
2021-09-03 12:55 ` Willgerodt, Felix
2021-09-03 12:59 ` Simon Marchi
2021-07-29 8:38 ` [PATCH 2/2] gdb: Enable finish command and inferior calls for _Float16 on amd64 and i386 Felix Willgerodt
2021-07-29 16:03 ` Luis Machado
2021-07-30 7:52 ` Willgerodt, Felix
2021-07-30 12:04 ` Luis Machado
2021-09-03 12:37 ` Simon Marchi
2021-09-03 14:00 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edec1d0f-b6e5-1bf1-c870-2bf35cd3dc17@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).