From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1028C3857C6B for ; Fri, 3 Sep 2021 12:30:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1028C3857C6B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 183CUokE031108 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 Sep 2021 08:30:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 183CUokE031108 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EDD3A1EDDB; Fri, 3 Sep 2021 08:30:49 -0400 (EDT) Subject: Re: [PATCH 1/2] Add half support for AVX512 register view. To: Felix Willgerodt , gdb-patches@sourceware.org References: <20210729083833.2483704-1-felix.willgerodt@intel.com> <20210729083833.2483704-2-felix.willgerodt@intel.com> From: Simon Marchi Message-ID: Date: Fri, 3 Sep 2021 08:30:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210729083833.2483704-2-felix.willgerodt@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Sep 2021 12:30:50 +0000 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 12:30:59 -0000 > diff --git a/gdb/features/i386/32bit-sse.c b/gdb/features/i386/32bit-sse.c > index e5eaf8feb59..5554849a6ca 100644 > --- a/gdb/features/i386/32bit-sse.c > +++ b/gdb/features/i386/32bit-sse.c > @@ -10,6 +10,9 @@ create_feature_i386_32bit_sse (struct target_desc *result, long regnum) > > feature = tdesc_create_feature (result, "org.gnu.gdb.i386.sse"); > tdesc_type *element_type; > + element_type = tdesc_named_type (feature, "ieee_half"); ieee_half isn't listed on this page: https://sourceware.org/gdb/current/onlinedocs/gdb/Predefined-Target-Types.html Should it? Otherwise, LGTM. Simon