From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38693 invoked by alias); 16 Nov 2016 23:34:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37781 invoked by uid 89); 16 Nov 2016 23:34:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ifeq, Articles, 3.81, 3.80 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 23:34:45 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59AC22FE57D; Wed, 16 Nov 2016 23:34:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAGNYfir019823; Wed, 16 Nov 2016 18:34:42 -0500 Subject: Re: [PATCH 1/4] Document new hard requirement on GNU make To: Simon Marchi , Eli Zaretskii References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-2-simon.marchi@ericsson.com> <83oa1ffkwa.fsf@gnu.org> <814e16be74a92751d1a2e47ba88b6ad9@polymtl.ca> <83inrnfier.fsf@gnu.org> <9836fdc1e7775a7afdada97654d044ef@polymtl.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 16 Nov 2016 23:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9836fdc1e7775a7afdada97654d044ef@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00466.txt.bz2 On 11/16/2016 10:04 PM, Simon Marchi wrote: > On 2016-11-16 12:23, Eli Zaretskii wrote: >>> With make >= 3.82, it would do the right thing (choose the second one), >>> by choosing the rule with the shorter stem. Before that, it used the >>> order of definition (the first that matches wins). So it would be nice >>> for that reason to require >= 3.82, but it's also possible to work >>> around if that's too recent. >> >> 3.82 shouldn't be a problem, I think. > > Oops, I said that without even checking the version I have on my system. > Ubuntu 14.04, strangely, has make 3.81. Apparently that was because of > a critical bug on Debian with 3.82, which stayed open for a long time, > preventing the upgrade. Debian and its derivatives, including Ubuntu, > were stuck with that for a long time. > > Refs: > http://stackoverflow.com/questions/31912233/how-to-update-make-3-81-linux > https://lwn.net/Articles/569920/ > > I don't think it's worth complicating the lives of those users just to > get the benefit of the behaviour change I mentioned. > > So I'm back at having no idea what version we should require. I think we should go with the same requirement as gcc (3.80), as seen on the top level Makefile.in: @if gcc ifeq (,$(.VARIABLES)) # The variable .VARIABLES, new with 3.80, is never empty. $(error GNU make version 3.80 or newer is required.) endif @endif gcc ... and listed on their prerequisites page: https://gcc.gnu.org/install/prerequisites.html (I'd be very nice to have a page like that for gdb. Currently we're not very organized wrt to prerequisite tracking.) Thanks, Pedro Alves