From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DD104385783F for ; Tue, 16 May 2023 16:42:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD104385783F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684255322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=201YVWvHP1bjUH5cXOC2Kwz+Crd7dGGjBS+finNlMyw=; b=NTPVsJAFoNt6PRDQQCilwxCeGr5FQ/HswCl+nvrVKgwJb7hpLTBWWpC9ZNWwsjOq1C+3Vg 1AdPwu5yIymVyhxljEtkPQKACv2o5rgeicYzbpalV+u4hT0w+cs2KLqR72NfL68tgFQ3ch Ip7ia4oFOD4dnh+U+u3pFZW8+PVH7+Y= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499--UuktfYCN3qRnv7oVhPckA-1; Tue, 16 May 2023 12:41:58 -0400 X-MC-Unique: -UuktfYCN3qRnv7oVhPckA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-62135468933so48641406d6.1 for ; Tue, 16 May 2023 09:41:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684255318; x=1686847318; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=201YVWvHP1bjUH5cXOC2Kwz+Crd7dGGjBS+finNlMyw=; b=X9NFIlc6wVuGGNIDxcLQfQ2cXnvsLFkgG3KO1MeH0dSmGOTSTWrZBh4EywLsR5Q+sK 4Ak14+B06Ix5r71dVuxT+294yxn7sxd9C20tw6mCFV5/JmwE/EouzpoCCtikhSlVQFBj v123a6LI4vYQIPpEntBLdhC/eOqOR5V0FyL8sz2+oJWv1hIhwkPnwieixdmX/LIwbmDe GpReixc50nR34EjSjb3c+6iI2Sr7tFskJoXfT+GUOPl71mhMjghMrxfwrh00ecfDqq8m bdqzHvfAMHHLNuHQGLwR7GW1g7LRGPb/MoIrlEyy+T0oCrWqq/ALCcpVg5yR5iVDH32E rMNQ== X-Gm-Message-State: AC+VfDyX5/wzq66fPMh0oB7SsbR2nUdxF8oPwWYFcbwFf3bzn9c5K1qc vUTDxMGTzQX60IDxDONtz1nJU08g8gjN3FzVNdi4JEKA753BZu0dmrwDjrv7uQs3GgX2rKFEfzS xFPE6d22wtd44rKS3cmuh2A== X-Received: by 2002:ad4:5ca8:0:b0:5ef:519:b27 with SMTP id q8-20020ad45ca8000000b005ef05190b27mr61141540qvh.35.1684255318235; Tue, 16 May 2023 09:41:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ69ouhcPUMUwawswLZ1GUcgytAIvvZ1QyOzNqUQatr4xjGlkIwUN8J4+mTcIzvXGcTsnlNnDQ== X-Received: by 2002:ad4:5ca8:0:b0:5ef:519:b27 with SMTP id q8-20020ad45ca8000000b005ef05190b27mr61141503qvh.35.1684255317811; Tue, 16 May 2023 09:41:57 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id k22-20020a05620a139600b0074db94ed42fsm698961qki.116.2023.05.16.09.41.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 09:41:57 -0700 (PDT) Message-ID: Date: Tue, 16 May 2023 18:41:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS To: Eli Zaretskii Cc: gdb-patches@sourceware.org, gdb@sourceware.org References: <20230516143826.3431583-1-blarsen@redhat.com> <20230516143826.3431583-2-blarsen@redhat.com> <83pm70z2hr.fsf@gnu.org> From: Bruno Larsen In-Reply-To: <83pm70z2hr.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16/05/2023 18:04, Eli Zaretskii wrote: >> Cc: gdb@sourceware.org, >> Bruno Larsen >> Date: Tue, 16 May 2023 16:38:27 +0200 >> From: Bruno Larsen via Gdb-patches >> >> + - Tested-by: >> + >> + Used when a contributor does not want to comment on the quality >> + of the code in the patch, but has tested and sees no regressions on their >> + hardware. >> + >> + - Reviewed-by: >> + >> + Used when a contributor has looked at code and agrees with the changes, >> + but either does not have the authority or doesn't feel comfortable >> + approving the patch (usually due to unfamiliarity with a certain >> + part of the code). > Reviewed-by is used by responsible maintainers as well. I think I need clearer wording then. I tried using "contributor" to mean anyone who decided to look at a patch, so it would include responsible maintainers when they dont have authority (or desire) to approve a patch. How do you think it could be rephrased to make it more clear? > >> + >> + - Approved-by: >> + >> + Used by responsible mainainers or global maintainers when > ^^^^^^^^^^ > Typo. oops sorry > >> + a patch is ready to be upstreamed. Some patches may touch multiple areas >> + and require multiple approvals before landing (such as a maintainer only >> + approving documentation), it is up to the maintainer giving the approval tag >> + to make it clear when that a tag is not sufficient. >> + Responsible, Global and Official FSF-appointed maintainers may approve their >> + own patches, but it is recommended that they seek external approval before >> + doing so. >> + > I think the above list is incomplete, because there appears to be no > "git trailer" (why do we have to call it "git" trailer, btw? will > that change if we ever switch to a different VCS?) for the situation > where the responsible maintainer does approve some part of the patch, > but not all of it (e.g., because the other parts are not in the > expertise domain of that maintainer). I thought Reviewed-by is such a > trailer, but based on the above I'm beginning to think I was confused. > I wrote the proposal based on how I think the use of trailers works on the QEMU project (I wasn't in it long enough to be sure that I am correct, though). My thinking was that you'd send something like "documentation changes are approved, but someone needs to look at the code, Approved-By ..." or something similar. That said, I just remembered that they also use Ack-By in those situations and the maintainer of the subsystem most affected by a change is the only one to approve the patch, and other relevant maintainers use Ack-By (they have a very different development workflow, with each subsystem maintainer having their own tree and them only being merged into the master tree periodically). I'm pretty open to suggestions, if you think using Acked-By or some other trailer is better. That is the reason I'm doing this :-) As to why call them "git trailers", I copied over from the checklist[1], that was already there describing Co-Authored-By and Bug trailers. We can change the name to just trailers or tags or something else if you prefer. [1] https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages -- Cheers, Bruno