From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 99E943858006
 for <gdb-patches@sourceware.org>; Thu, 29 Jul 2021 01:28:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99E943858006
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16T1RL2v000672
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Wed, 28 Jul 2021 21:27:26 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16T1RL2v000672
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 7708E1E813;
 Wed, 28 Jul 2021 21:27:21 -0400 (EDT)
Subject: Re: [PATCH 2/4] gdb: make string-like set show commands use
 std::string variable
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
References: <20210728195043.904136-1-lsix@lancelotsix.com>
 <20210728195043.904136-3-lsix@lancelotsix.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <ee3e58c2-3fef-1ea3-5fea-2ce77c2aa53a@polymtl.ca>
Date: Wed, 28 Jul 2021 21:27:21 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210728195043.904136-3-lsix@lancelotsix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 29 Jul 2021 01:27:21 +0000
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 01:28:29 -0000

> @@ -675,6 +670,17 @@ add_path (const char *dirname, char **which_path, int parse_separators)
>      }
>  }
>  
> +/* add_path would need to be re-written to work on an std::string, but this is 

Probably my fault, but trailing whitespace here.

Simon