From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id D5B05385043E
 for <gdb-patches@sourceware.org>; Thu, 29 Jul 2021 18:00:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5B05385043E
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16TI0p64002648
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Thu, 29 Jul 2021 14:00:56 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16TI0p64002648
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 3A9A21E813;
 Thu, 29 Jul 2021 14:00:51 -0400 (EDT)
Subject: Re: [PATCH 15/16] gdb: make cmd_list_element var an optional union
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
References: <20210714045520.1623120-1-simon.marchi@polymtl.ca>
 <20210714045520.1623120-16-simon.marchi@polymtl.ca>
 <87wnpacjaf.fsf@tromey.com> <fa04dd3b-1c63-9291-4fca-5acf9cb5e5cc@polymtl.ca>
 <87im0tauhd.fsf@tromey.com> <b65de81d-a9fa-ca47-caa9-23d08e4d9454@polymtl.ca>
 <87a6m5au3q.fsf@tromey.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <ee7a9a16-1eb7-47b1-310c-6616c03b5a44@polymtl.ca>
Date: Thu, 29 Jul 2021 14:00:50 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <87a6m5au3q.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 29 Jul 2021 18:00:51 +0000
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 18:00:58 -0000

On 2021-07-29 1:49 p.m., Tom Tromey wrote:
> struct _Optional_payload_base has:
> 
>       constexpr _Tp&
>       _M_get() noexcept
>       { return this->_M_payload._M_value; }
> 
> I don't know why this one doesn't check, but I suppose given the
> resolution of that bug, it's probably fine.

This looks like an internal class, perhaps the assertion is made at all
entry points that possibly lead to this being called?

Simon