From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CC8FE3858D1E for ; Thu, 3 Aug 2023 07:29:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC8FE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 136B321985; Thu, 3 Aug 2023 07:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691047794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xEp8IvN3bYe2m5tEiFOEh/1/kH4p0yef2OuYnletLfY=; b=EDRhwF+Uiy2bUw6j26gdMlYjbF5ep3H1MuND0MLN9KGNl2Gcb2gD+lxbKLGVR4X9c77fn+ 0sDTBLk4XVctgDdMUk2AYeo8RJWDF+MZm86+v/wCfSXwfJGK9VkTalrz9oWcx4VM3MYE6Q vZ5jFpmeljLd4n9zvKBD8CcKW7AM9NY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691047794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xEp8IvN3bYe2m5tEiFOEh/1/kH4p0yef2OuYnletLfY=; b=M2vYG8u0ySnIDgjEDB4iW9n5mP3D4BbzHKd+kXoshaw9XsABNmDLMc9AhFoYxv8cY0LamF 5BQYlU2Cdixm1IDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EBB3B1333C; Thu, 3 Aug 2023 07:29:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n+NmOHFXy2RUMwAAMHmgww (envelope-from ); Thu, 03 Aug 2023 07:29:53 +0000 Message-ID: Date: Thu, 3 Aug 2023 09:29:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add name_of_main and language_of_main to the DWARF index Content-Language: en-US To: Matheus Branco Borella , eliz@gnu.org Cc: gdb-patches@sourceware.org References: <83bkgwrxnh.fsf@gnu.org> <20230707150021.618-1-dark.ryu.550@gmail.com> From: Tom de Vries In-Reply-To: <20230707150021.618-1-dark.ryu.550@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/7/23 17:00, Matheus Branco Borella via Gdb-patches wrote: > Is there anything else I'm missing? There seem to be a lot of white space issues: ... $ git show --pretty=%s --check | grep -v '^\+' Add name_of_main and language_of_main to the DWARF index gdb/dwarf2/index-write.c:1084: indent with spaces. gdb/dwarf2/index-write.c:1206: indent with spaces. gdb/dwarf2/index-write.c:1217: indent with spaces. gdb/dwarf2/index-write.c:1218: indent with spaces. gdb/dwarf2/index-write.c:1219: indent with spaces. gdb/dwarf2/index-write.c:1221: indent with spaces. gdb/dwarf2/index-write.c:1222: indent with spaces. gdb/dwarf2/index-write.c:1223: indent with spaces. gdb/dwarf2/read-gdb-index.c:622: indent with spaces. gdb/dwarf2/read-gdb-index.c:777: trailing whitespace. gdb/dwarf2/read-gdb-index.c:778: indent with spaces. gdb/dwarf2/read-gdb-index.c:791: indent with spaces. gdb/dwarf2/read-gdb-index.c:803: trailing whitespace. gdb/dwarf2/read-gdb-index.c:804: trailing whitespace, indent with spaces. gdb/dwarf2/read-gdb-index.c:805: indent with spaces. gdb/dwarf2/read.h:248: trailing whitespace. gdb/dwarf2/read.h:251: trailing whitespace. gdb/dwarf2/read.h:252: trailing whitespace. ... Furthermore, I can confirm that this fixes regressions with target board gdb-index in test-cases: - gdb.fortran/backtrace.exp - gdb.fortran/info-main.exp - gdb.dwarf2/main-subprogram.exp - gdb.fortran/mixed-lang-stack.exp Some of those are KFAIL-ed for https://sourceware.org/bugzilla/show_bug.cgi?id=24549 . So, you could add this to the commit message: ... PR symtab/24549 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24549 ... Thanks, - Tom