From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by sourceware.org (Postfix) with ESMTPS id E7E123858407 for ; Mon, 23 Jan 2023 17:42:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7E123858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f41.google.com with SMTP id e19-20020a05600c439300b003db1cac0c1fso9688678wmn.5 for ; Mon, 23 Jan 2023 09:42:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U9jUV9hE6BzTe8TnZxn8cfn6YnZcRCaXFK2j40f0D84=; b=7E4rc07LWYXOqxsi6p+XmeyDcjXuZ3NvZKCzfKMaUFqS1UqqiAELVE2Ug64R8Drvhf 3CF1qSD3CPW2bZspPr/IIqB8rGcgRw2/owqx1GjuABAXAI2f/tmmt47nBOIMkYGS6AGg 9kxCKP9BcSLN/GaFVHDz3ljLJ5D2okVvEqJowRe0WdE4EU36V3DVZ6Civwr0v2cczJzR fAPTsHhhBGKjP7p+6H38U4TGRByunRIiwKgulxY8UYJY/QuXkRd+4Sv0fOHxsb71pqQ6 5mo/UgTRrz3WGPAcwA10h1ssBawvHyI5BiUlR6ensrzqCBbAiasUvx16pX8+Xl2kGj8M erlQ== X-Gm-Message-State: AFqh2koJw9qyhvnEVESqJfjPe0KzKK0n6EvqrztVbgvSKzG1NS1mXVdC qZQ020gCmuFlJMp+h6Meeu8= X-Google-Smtp-Source: AMrXdXtksjhkjQVq52Mkv+gi4/p8DVWGJb3gnXkuQs4h+WoxZ0OCeaMrNcHvbt+WbNDYRV60I9ETFg== X-Received: by 2002:a05:600c:2103:b0:3d3:43ae:4d10 with SMTP id u3-20020a05600c210300b003d343ae4d10mr25237691wml.11.1674495778709; Mon, 23 Jan 2023 09:42:58 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b003cfd4e6400csm11719034wmq.19.2023.01.23.09.42.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 09:42:58 -0800 (PST) Subject: Re: [PATCH v4 1/3] gdb: Make global feature array a per-remote target array To: Christina Schimpe , gdb-patches@sourceware.org Cc: tom@tromey.com, aburgess@redhat.com, eliz@gnu.org References: <20221221133958.2111768-1-christina.schimpe@intel.com> <20221221133958.2111768-2-christina.schimpe@intel.com> From: Pedro Alves Message-ID: Date: Mon, 23 Jan 2023 17:42:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20221221133958.2111768-2-christina.schimpe@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2022-12-21 1:39 p.m., Christina Schimpe wrote: > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,20 @@ > > *** Changes since GDB 13 > > +* Multi-target feature configuration > + > + GDB now supports the individual configuration of remote target's feature I think you meant for "remote target" to be plural, so it should be written with the approstrophe after the plural "s", like "remote targets'". Otherwise, if you really meant singular, then an article seems missing after "of", as in "configuration of a/the remote target's" > + sets. Based on the current selection of a target, the commands 'set remote > + -packet (on|off|auto)' and 'show remote -packet' can be used to > + configure a target's feature packet and to display its configuration, > + respectively. > + > + The configuration of the packet itself applies to the currently selected > + target (if available). If no target is selected, it applies to future remote > + connections. Similarly, the show commands print the configuration of the > + currently selected target. If no remote target is selected, the default > + configuration for future connections is shown. > + > * MI version 1 has been removed. ... > > +/* Description of a remote packet. */ > + > +struct packet_description > + { Please fix indentation of {, and then the struct's fields accordingly (and possibly reflow comments). The "{" should be at column zero. No need to repost the patch for this. > + /* Name of the packet used for gdb output. */ > + const char *name; > + > + /* Title of the packet, used by the set/show remote name-packet > + commands to identify the individual packages and gdb output. */ > + const char *title; > + Remove spurious empty line after last field. > + }; > + > +/* Configuration of a remote packet. */ > + > +struct packet_config > + { Ditto. > + /* If auto, GDB auto-detects support for this packet or feature, > + either through qSupported, or by trying the packet and looking > + at the response. If true, GDB assumes the target supports this > + packet. If false, the packet is disabled. Configs that don't > + have an associated command always have this set to auto. */ > + enum auto_boolean detect; > + > + /* Does the target support this packet? */ > + enum packet_support support; > + }; > + This is OK with the nits above fixed. Thank you!