From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 373C1385B50D for ; Mon, 13 Feb 2023 15:01:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 373C1385B50D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676300506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d5OtwNIZg48C/3YmKCzgiKnIjsp4i8OKxUiSoIt8lP4=; b=HXPnFnloYY7Ee2cxULKiuW7EQnprGZgLWj8KQ12o8DEmj5Zmn3XdiuTmmtoH15qwxyhHvh xuYug+X/9oRFPloKLPgjyYn+n/O8MBPzNRmlXFkDMELNpa1xFyWB1mMj+sfwd3zqpM3ILR N2YIAfJ5avpOMerAfgKMoyDw/rTnlCc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-3WCwXWt6PWucqRYJ5Ui2NA-1; Mon, 13 Feb 2023 10:01:38 -0500 X-MC-Unique: 3WCwXWt6PWucqRYJ5Ui2NA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 43D1B3810B05 for ; Mon, 13 Feb 2023 15:01:38 +0000 (UTC) Received: from [10.2.16.27] (unknown [10.2.16.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1572F2026D76 for ; Mon, 13 Feb 2023 15:01:37 +0000 (UTC) Message-ID: Date: Mon, 13 Feb 2023 07:01:37 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] Fix doc build dependencies for --with-system-readline To: Keith Seitz via Gdb-patches References: <20230210214224.1754620-1-keiths@redhat.com> <871qmwgp9s.fsf@tromey.com> From: Keith Seitz In-Reply-To: <871qmwgp9s.fsf@tromey.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/11/23 08:06, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz via Gdb-patches writes: > > Keith> PR build/30108 concerns building gdb documentation with > Keith> --with-sytem-readline. If the in-tree readline directory is > Keith> missing, though, the docs will fail to build: > > ... > Keith> This patch fixes this by creating (essentially) a conditional setting of the > Keith> dependencies to be included from readline. > > Thanks, this is ok. > Approved-By: Tom Tromey Thank you for the review; I've pushed this and cherry-picked it for gdb-13-branch (as requested by Joel). Keith