From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 5C0483858C2C for ; Fri, 22 Apr 2022 14:56:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C0483858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id h25so5399577wrc.13 for ; Fri, 22 Apr 2022 07:56:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=UhAv51bl3wHOeKGjOTHcVXHavAuJm6dTxBua5XDaG3A=; b=fsPtKGqVJwRTmC5Dt5VapDdGn6+SfBR7LMRKB2pAdXywPIArJZMDqHZvyt9PArwaYC CkvyL/Z79XwUKFkIQmEBXJiYeJOeyirWHsxzoQRRNCTZt6X5rws2upDn9PdG9QFk2apK yEDv/zdRMEM0MSG7fGa3uxyYapxo3Nv2a0pJEqJZuF1drZQ0SChEc2PPyEfdWACxt2GQ CWko3Yu9PpVIkouf/qJM5y/jmLmybi2Cd7ERn4mV2b6AotYE5up2FQmd6ESCQ/Kzppoh iedwUn2Pii/FLciHjN6yEsx3t/gVuELFkzeq2fUaIskmoYmtOU31xNYfvlfsQB6X+lFp X1Cw== X-Gm-Message-State: AOAM530zO9h4mwlmAQnPHBhNzreSNbf+DSTmx7BJ2BmMLgnEa5K7qlOw FxGap44+CvgTNJSs5yMdfz4DXw80b+I= X-Google-Smtp-Source: ABdhPJwacgk+y30gLeRkdbxZ0nqb9ucEtcpecNHRm06c0fokedmDA9kxNVt3kkdcl9bHJiHt1HjNIQ== X-Received: by 2002:a5d:44cf:0:b0:20a:c5d2:b6c3 with SMTP id z15-20020a5d44cf000000b0020ac5d2b6c3mr4059326wrr.177.1650639362117; Fri, 22 Apr 2022 07:56:02 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id m8-20020a056000008800b00207b3fa7fc0sm2084220wrx.108.2022.04.22.07.56.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 07:56:01 -0700 (PDT) Message-ID: Date: Fri, 22 Apr 2022 15:55:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 0/4] Minor cleanups in coff-pe-read.c Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220422135632.2615890-1-tromey@adacore.com> From: Pedro Alves In-Reply-To: <20220422135632.2615890-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 14:56:04 -0000 On 2022-04-22 14:56, Tom Tromey via Gdb-patches wrote: > I looked a little into having coff-pe-read.c reuse minimal symbols > without re-reading. This turned out to be difficult because this code > is only called from coffread.c, which does more complicated work > first, so I didn't do this. > > However, while looking at this code I found a few things that could be > tidied. This series is the result. I tested this using AdaCore's > internal test suite on Windows. The series looks fine to me, but now I'm curious on what you mean by "reuse minimal symbols without re-reading".