From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp
Date: Mon, 17 Feb 2020 20:52:00 -0000 [thread overview]
Message-ID: <ef33c667-58ff-f96c-0f5d-8d5901f561bb@polymtl.ca> (raw)
In-Reply-To: <2319b744-2902-9c09-2448-450e40347c04@suse.de>
On 2020-02-13 10:02 a.m., Tom de Vries wrote:
> On 13-02-2020 15:32, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> 2020-02-13 Tom de Vries <tdevries@suse.de>
>>
>> Tom> * gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail)
>> Tom> (ignore_unsupported): New proc.
>> Tom> (test_proc): Temporarily rename pass/fail/ignore to
>> Tom> ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages
>> Tom> from the tested procs.
>>
>> Can we just require that caching proc bodies not invoke tests?
>>
>
> We could, I don't have preference one way or the other.
>
> If I remove all the fail calls from gnat_runtime_has_debug_info, we
> still get these PASSes from gdb_compile_ada:
> ...
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: gnat_runtime_has_debug_info consistency
> ...
>
> But we can factor that out, I've already done that once here (
> https://sourceware.org/ml/gdb-patches/2019-10/msg01109.html ).
>
> Simon, WDYT?
>
> Thanks,
> - Tom
>
If you can indeed do that, I think it would be best.
Simon
next prev parent reply other threads:[~2020-02-17 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 10:58 Tom de Vries
2020-02-13 14:32 ` Tom Tromey
2020-02-13 15:02 ` Tom de Vries
2020-02-17 20:52 ` Simon Marchi [this message]
2020-02-17 23:23 ` Tom de Vries
2020-02-17 23:58 ` Simon Marchi
2020-02-18 9:39 ` [committed][gdb/testsuite] Handle missing gnatmake in gnat_runtime_has_debug_info Tom de Vries
2020-02-18 10:59 ` [RFC][gdb/testsuite] Ignore pass in gdb_caching_proc Tom de Vries
2020-02-18 15:29 ` Tom Tromey
2020-02-19 6:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef33c667-58ff-f96c-0f5d-8d5901f561bb@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).