public inbox for
 help / color / mirror / Atom feed
From: Tom de Vries <>
To: Simon Marchi <>,
	Simon Marchi <>,
Subject: Re: [PATCH] gdb: fix dealloc function not being called for frame 0
Date: Wed, 15 Feb 2023 18:56:18 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 2/15/23 17:42, Simon Marchi wrote:
>> Hi Simon,
>> I've:
>> - applied the initial patch
>> - verified that it fixes the gdb.btrace/record_goto.exp test-case
>> - verified that it breaks the gdb.server/server-kill.exp test-case
>> - applied your proposed change (attached in patch form for clarity)
>> - verified that it fixes the gdb.server/server-kill.exp test-case
>> - verified that it still fixes the gdb.btrace/record_goto.exp test-case
>> - done a complete build and test run, no issues found (in other words,
>>    I'm back to just one FAIL, in gdb.server/monitor-exit-quit.exp,
>>    PR29833)
> Thanks for testing.  Should I add just your Tested-By, or did you review
> more in-depth?

Hi Simon,

just tested-by.

Unfortunately, the frame cache is just one of those things in gdb I'm 
wholly unfamiliar with, so I don't feel myself capable of reviewing 
without investing serious amounts of time.

I've looked through the commit message, and it sounds reasonable and 
well-explained to me, I just don't understand the full extent of it, 
nevermind the code change.

I did see a few typo's, I'll reply to the submission email to note those.

- Tom

  reply	other threads:[~2023-02-15 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 19:50 Simon Marchi
2023-02-10  3:10 ` Simon Marchi
2023-02-15  9:39   ` Tom de Vries
2023-02-15 16:42     ` Simon Marchi
2023-02-15 17:56       ` Tom de Vries [this message]
2023-02-15 18:01 ` Tom de Vries
2023-02-15 18:45   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).