Re: [PATCH] gdb: fix dealloc function not being called for frame 0

[Tom de Vries <tdevries@suse.de>]

On 2/15/23 17:42, Simon Marchi wrote:
>> Hi Simon,
>>
>> I've:
>> - applied the initial patch
>> - verified that it fixes the gdb.btrace/record_goto.exp test-case
>> - verified that it breaks the gdb.server/server-kill.exp test-case
>> - applied your proposed change (attached in patch form for clarity)
>> - verified that it fixes the gdb.server/server-kill.exp test-case
>> - verified that it still fixes the gdb.btrace/record_goto.exp test-case
>> - done a complete build and test run, no issues found (in other words,
>>    I'm back to just one FAIL, in gdb.server/monitor-exit-quit.exp,
>>    PR29833)
> 
> Thanks for testing.  Should I add just your Tested-By, or did you review
> more in-depth?
> 

Hi Simon,

just tested-by.

Unfortunately, the frame cache is just one of those things in gdb I'm 
wholly unfamiliar with, so I don't feel myself capable of reviewing 
without investing serious amounts of time.

I've looked through the commit message, and it sounds reasonable and 
well-explained to me, I just don't understand the full extent of it, 
nevermind the code change.

I did see a few typo's, I'll reply to the submission email to note those.

Thanks,
- Tom