From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 8C8133858423 for ; Wed, 15 Feb 2023 17:56:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C8133858423 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A057C20C11; Wed, 15 Feb 2023 17:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676483778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W3i7ORaU6sRmQ3NqOpozSsMslDj4PHc5yEsoqR5N1QU=; b=zQGEJ2qEF26ajn/slbxLU3dEg3W7Q6j2H41LQQC7KHYqKEW/k0yY05JkpPguBydLf8Pluk IKyms/zCQnKzeSMNyZxnbUyvSkI+F4nZjYd9wtKC/Q4Y6FzdpnefOcAGQbjkZJuQeSyvRD Rcwsw+hQ/+tERUTvSz/KldO2OI33dik= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676483778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W3i7ORaU6sRmQ3NqOpozSsMslDj4PHc5yEsoqR5N1QU=; b=6XqpplQSIgjHPCXuo3ZCSi0RQ+LJdiZW/emh0fL/cHiAvrSa1p52eu5eOxh+RRPXiZdtHS 1H5kEZCdTnHQdwBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7DDC3134BA; Wed, 15 Feb 2023 17:56:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id V5U4HcIc7WMbZAAAMHmgww (envelope-from ); Wed, 15 Feb 2023 17:56:18 +0000 Message-ID: Date: Wed, 15 Feb 2023 18:56:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] gdb: fix dealloc function not being called for frame 0 To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20230209195037.100368-1-simon.marchi@efficios.com> <30ee85a3-d6aa-c69e-2fe6-3c6d53a11a90@simark.ca> <8b8d6d16-ed28-bebb-9136-85fc81968fa5@suse.de> <7ddb6fa6-17ad-285d-3b0d-945c503cb999@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <7ddb6fa6-17ad-285d-3b0d-945c503cb999@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/15/23 17:42, Simon Marchi wrote: >> Hi Simon, >> >> I've: >> - applied the initial patch >> - verified that it fixes the gdb.btrace/record_goto.exp test-case >> - verified that it breaks the gdb.server/server-kill.exp test-case >> - applied your proposed change (attached in patch form for clarity) >> - verified that it fixes the gdb.server/server-kill.exp test-case >> - verified that it still fixes the gdb.btrace/record_goto.exp test-case >> - done a complete build and test run, no issues found (in other words, >> I'm back to just one FAIL, in gdb.server/monitor-exit-quit.exp, >> PR29833) > > Thanks for testing. Should I add just your Tested-By, or did you review > more in-depth? > Hi Simon, just tested-by. Unfortunately, the frame cache is just one of those things in gdb I'm wholly unfamiliar with, so I don't feel myself capable of reviewing without investing serious amounts of time. I've looked through the commit message, and it sounds reasonable and well-explained to me, I just don't understand the full extent of it, nevermind the code change. I did see a few typo's, I'll reply to the submission email to note those. Thanks, - Tom