From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6100A3858D20 for ; Tue, 8 Aug 2023 15:46:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6100A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691509564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UziXUfNKf9LrAM2q9cjqQjDe+jztrHUCVO8YUJhQ7dA=; b=WtXWe2rzNRvSkOK4ulIV2lgDtYNRbYBwW3C60bIOa+FCzFFgPj1NGKyZsm35jaG1WSvBVe NraO7wL3VGQv8ZawXlQ/YNzl7Vl36NTSoU305roVLpcvYl/NIfFtafWlbKA3U3TV9V4n25 s3+VRAErceR4ByHrwML3doBTz8QzV8U= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-VBEYogqSPjuMTmENw42kew-1; Tue, 08 Aug 2023 11:46:02 -0400 X-MC-Unique: VBEYogqSPjuMTmENw42kew-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-63cff1f2d20so70594216d6.1 for ; Tue, 08 Aug 2023 08:46:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691509562; x=1692114362; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UziXUfNKf9LrAM2q9cjqQjDe+jztrHUCVO8YUJhQ7dA=; b=OxmL3GUdDWpMGBQE9N1CBf3gM/JEc2Rhera6zqfms9TU7JCKdfP6IXMy+4FPsANGcD 43JuYE46aJBHm2riPCtKIjH1OhWanIhLJJUJzquSUZQStdf4HTwivLog/3NkxUP4B7C1 ArpyjUMscftkvtYK0dZXZ5YHWMuSZBOStcEF4aj4INK/qG1+2EUnSkEbe96HPxsGjqUF 1huEMRnouUqiU7rj3BHqqbHU1KqATMDSDestbLg7IPzkDI7t64C5YQwgBb5OMBZw6Qzz 9om6mWN9hiV2ySWrMzBa7OonXRHylgo5lJBctdldoVpclqjG1Z1ARc4oY5Cl0VdhXmcN Ye6A== X-Gm-Message-State: AOJu0Yzxnr2MwmwgXqYGTx2JJQ7WKvK6lcvfl2/po991CxkysT6i65i9 xPxtAZODYN8as8yOSR3AkQrfZuF5VH4GrSlMdMxI6Jg2+kOwO7iU49iKzxkHt492AxUiMh2VY7C QTNEpHT6H1CwHRnYWm+ULtQ== X-Received: by 2002:a0c:fe41:0:b0:63c:e700:d38b with SMTP id u1-20020a0cfe41000000b0063ce700d38bmr12371622qvs.29.1691509562285; Tue, 08 Aug 2023 08:46:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeRad6rF0diosXK8Uc7bdbpvT0dDqqc9l6nwb5VW8jg+DEDZUEyYLieiOxlD4jk+DJ1Ypsow== X-Received: by 2002:a0c:fe41:0:b0:63c:e700:d38b with SMTP id u1-20020a0cfe41000000b0063ce700d38bmr12371608qvs.29.1691509562002; Tue, 08 Aug 2023 08:46:02 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id y18-20020a0c9a92000000b00631ecb1052esm3790439qvd.74.2023.08.08.08.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 08:46:01 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 17:45:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2 ver 2] Fix reverse stepping multiple contiguous PC ranges over the line table. To: Carl Love , Simon Marchi , gdb-patches@sourceware.org, UlrichWeigand , pedro@palves.net Cc: luis.machado@arm.com References: <3a46ac42391707325ee2aab900d13bce05c8a0b8.camel@us.ibm.com> <387d9d9d-6f4f-696b-ff18-f68974a7da39@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/08/2023 17:38, Carl Love wrote: > Guinevere: > > On Tue, 2023-08-08 at 12:04 +0200, Guinevere Larsen wrote: > > >> On 07/08/2023 21:03, Carl Love wrote: >>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >>> index 36bf738c667..bffbbf38b09 100644 >>> --- a/gdb/testsuite/lib/gdb.exp >>> +++ b/gdb/testsuite/lib/gdb.exp >>> @@ -4896,6 +4896,8 @@ proc quote_for_host { args } { >>> # debug information >>> # - text_segment=addr: Tell the linker to place the text >>> segment at ADDR. >>> # - build-id: Ensure the final binary includes a build-id. >>> +# - no-column-info: Disable generation of column table >>> information. >>> +# - column-info: Enable generation of column table information. >>> # >>> # And here are some of the not too obscure options understood by >>> DejaGnu that >>> # influence the compilation: >>> @@ -5105,6 +5107,38 @@ proc gdb_compile {source dest type options} >>> { >>> } else { >>> error "Don't know how to handle text_segment >>> option." >>> } >>> + } elseif { $opt == "column-info" } { >>> + # If GCC or clang does not support column-info, compilation >>> + # will fail and the usupported column-info option will be >>> + # reported as such. >>> + if {[test_compiler_info {gcc-*}]} { >> I think you missed a bit on an old comment from simon. Way back in >> may, >> in this email >> https://sourceware.org/pipermail/gdb-patches/2023-May/199523.html , >> he >> mentioned: >> >> For instance, if you used no-column-info with gcc 6 >> (which doesn't support column info at all), gdb_compile should >> succeed, >> even if there isn't an option to disable column info with that >> compiler. >> If you used column-info with gcc 6, gdb_compile would fail. >> >> So I think this bit should throw an error if it detects gcc-[1-6]. > It has been awhile, but as I recall, we decided that the we would > specify column-info and if the compiler doesn't support it then the > compiler will complain (i.e. fail) and we will let the failure be > handled by the normal compiler failure path. I think that will work > fine? If there is some concern that is not sufficient, I would be > happy to put in the test if {[test_compiler_info {gcc-[1-6]-*}]} for > the $opt == "column-info" to have the script flag the error. > Thoughts? oh, I see. I must have misread when looking back at that conversation. Sorry for the noise. Also, disregard my comments about LLVM. I checked on IRC and the oldest GCC we support compiling/using for usptream stuff is form 2014, so I think we dont have to worry about 2012 clang :) All in all, this patch looks good to go in. Reviewed-By: Guinevere Larsen I hope the maintainers approve this series soon, it is a long time coming! -- Cheers, Guinevere Larsen She/Her/Hers > > In the case where the compiler doesn't handle the no-column-info flag, > i.e. gcc 1-6, we handle that case by not adding the flag so the > compiler will not flag the error and fail. In that case, it isn't > going to generate the column info anyways so we don't need to specify > no-column info. > > >>> + lappend new_options "additional_flags=-gcolumn-info" >>> + >>> + } elseif {[test_compiler_info {clang-*}]} { >> I did some digging, and column-info were added in llvm back in >> october >> 2012 (commit a2f7eb7c52cdc), which seems to mean support was added >> in >> llvm 3.2, but I don't see any mention in the release notes. In my >> opinion, this is old enough that we don't need to have a special >> case, >> but I wanted to mention, in case some maintainer thinks it should be >> dealt with. >> >> If we should, before then, it seems that clang WOULD add column info >> by >> default, so it should compile with a warning here, and fail if the >> user >> requested no column info >> > Carl >