From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46]) by sourceware.org (Postfix) with ESMTPS id 1EE323858C50 for ; Fri, 14 Oct 2022 12:04:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EE323858C50 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gOx1/YnVxlOOoo8c4YbPEU3T4Gw4cIimrsMqIXRae+JFBhszb1R3f45YSWimPwpIfaPvac2XRjrKoOKmHWjiHJeUFSehUclL2cgCtPzvKpFatkDOz9nWjQezDCGVqWgc6U2GTiMU2WHGsdwwh+k1lmjgqj/2FiOjla2uHCJgbYadjNw5jhsDGD5E8ZfJsa19wd1yzr5++BxDbIo4ZGkFsSbnjg/y4hyiRB3eeR/TBZ5i9aJKHqF+rwuO3LEywArkl3weMLRZmYaXbsFkYQh6BZFeox483LhxeAUg2Xs/CxzzfuXLJRvsjP0V4IxtS3e4f/1T5pKOqkrCJSTDpz8PqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/q8DViLNXDl4TxK6Wl1O1pkPUPapczkFSxhPeMxMqk=; b=KkUfeDRyzAZSulWMH5KBC0ewh17gwIHEF99jJde0uDBoaFArlXY5MD4JsZ6DzV0uciKAurcecbyNaG6ZQIk3FdyX+MSo/zeH40GikHWS/MxvFIzXP1cQT22qrPkpQfEZBwP+SVVaa9biX3DylGL5yFP6THjo/QF03TEa3LfzU2gWPvEbBaVQpgDaosHw4DEZVeyLMAx3fXLFnc1VrDOJMz8lgofLVXxy6pM0+DoM3qQWHTA/FBPKrDMKg05meOVE9+MhHGiOUQPLNR2fvx+mpHVJbHJcyP7Lc8NCKwiUhpOju1J/leiDyw02JNSIa7GJOAh3KAJP/F505m59TYenNg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6PR0802CA0042.eurprd08.prod.outlook.com (2603:10a6:4:a3::28) by AS2PR08MB9617.eurprd08.prod.outlook.com (2603:10a6:20b:60a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 12:04:15 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::47) by DB6PR0802CA0042.outlook.office365.com (2603:10a6:4:a3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend Transport; Fri, 14 Oct 2022 12:04:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 12:04:15 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 14 Oct 2022 12:04:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 67a48d641821934e X-CR-MTA-TID: 64aa7808 Received: from c8a319256a0f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D15FE5B2-AC6A-4EE4-9AFC-D46C79F03613.1; Fri, 14 Oct 2022 12:04:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c8a319256a0f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Oct 2022 12:04:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a25dtuMLUTRI+BAq+k0dbqdKYs/A/oW3O0/o+A+LyPao7LF3PGHGqEmimmvJKKYnK6qO1xcRzvov0c3RU+Nnu94eDmIA1PvKGO9lWYcqFymJwNV7Il0gxkxXjrkNYsti/Tct862/+F7k9r1iefLxBA+VQD+w+sY3ge9bBtGD3AluExTm9leRBQKpF5hzqn2TLwe9isyIh/CknN0bLxIdrceygjMZy4wVb3qASjO2QHoVnbBafiUcMm0ujAvC0i5WdIMHLhqsW6uqOXgJkuGusYbrjFuRxuAV1ogTOzKRAV5uvbAuR2wmidXeMqqskuYAIFDjgXmj+7kFSqoOXeOvyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/q8DViLNXDl4TxK6Wl1O1pkPUPapczkFSxhPeMxMqk=; b=L0kvb4k9jGDBs3X8J3+tPLLgN8zVAZCU+i70+T2OaETTVeIzJ0y2t7peo3oPBtmC0a3Ti+BxdYR4gboTs0RNiJSHhdh0+V/RKRe8rVYgYDRhMLvMQslUggmJi61vhjY0B5lglZD4sAQfGjE3eNaD9nokzUvRT5QwzzJUUD8D+VXHKEFEhYjCtgIHWiZ8ZYGJ5PuYFscpVI9yy6MgCkHzni8Xrau8O5R3+66mFBySdw2W0p0KUKGJgH/sLPQHqt3d33xtSL+ygbmdZNqofjl60x1wjakrdurlTCiBg8ZAkAmcXrcoFYKRqaRJdi41rBtukNc9UoiPso1xueUaPqvE3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB8PR08MB5355.eurprd08.prod.outlook.com (2603:10a6:10:11f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct 2022 12:04:06 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bbeb:a49e:d969:5d2]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bbeb:a49e:d969:5d2%6]) with mapi id 15.20.5709.021; Fri, 14 Oct 2022 12:04:05 +0000 Message-ID: Date: Fri, 14 Oct 2022 13:03:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4] gdb/arm: Stop unwinding on error, but do not assert Content-Language: en-US To: Pedro Alves , =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gdb-patches@sourceware.org References: <20221013181135.688646-1-torbjorn.svensson@foss.st.com> <6d3e2120-15bf-25e6-8914-8ec5b6e67976@palves.net> From: Luis Machado In-Reply-To: <6d3e2120-15bf-25e6-8914-8ec5b6e67976@palves.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN4PR0501CA0035.namprd05.prod.outlook.com (2603:10b6:803:40::48) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB8PR08MB5355:EE_|DBAEUR03FT021:EE_|AS2PR08MB9617:EE_ X-MS-Office365-Filtering-Correlation-Id: eac7e27c-5473-4e76-bd79-08daaddc36cf x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BQECQ1u8AHn1fV3qoT5cbUvnlFLo6Ul1v8IFyZrzu/baGLadpcOHHaL/EvVxLDu9t18ZRw2/qCFAjckJWUuMFepe5MP0tSNVBbFm/rj40lokUMNvbaG65tkQFgB4H3ZLrm24FftYYLzuazZJfGQJrwpiVu6xsn1tn1dPDYc2JXLo42XH/Pl3x1tlkR2Q8fCYltTKAO10CsBSxlsMnTGw676oBHZS6c1Wsn8/t24PHfCJAj68g4gfb+wzHTj7mDkRxUwAjeWTYyrlBWrTOy1otVqRMCUvo3IQRuj+dYKRCd0mmH6B/O7rNFDpdwQ5sl8SyeGWPMiYjqAJai0o5yLb9v90dGU5yHgWcgdk8XytesQtMalJTQZpSvcWA+CU/LGnWAty93yTod6XOnYRrIUmeVTAf+2ZG0WiZ/LXvsUuagFCbZMaWOAHVpJtPzI1qWH6IYhDMAlFO3368zkp1h9WYOc+u3nrxESNWGYgwGLUHE9AMaS3EWohlX/dEIkZvc2aXpXmxjQp9GcPyy+kkNmcQ1iLbMtS5lurtZt5NJe97bVbCAHC1SK9f3+8IcQYXytrX9ZlTFyRYYVAASWet4OG1GJCEMbs0yTyU67Ayi7G+u0DX685nI5kuO6O4KcRj3wLGx9avW3qNPGzizbILZAaiSfNGhl8Aigcdn+/sPRFJiIR9Jdqj64DC/t6izHb10vfPd97wMQBUqTeHmJnYQC8E0Q1btm4jRm3erU7j1uBcDq3kQvsgoxIX2X6jAn3dztFYf9FS3Uc9Rcqmy1RrZCOsukgx+6H/y+zm9NDYYQ8f60= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199015)(31696002)(31686004)(6666004)(26005)(4326008)(8676002)(44832011)(53546011)(66946007)(66556008)(6512007)(66476007)(2906002)(6506007)(38100700002)(4001150100001)(4744005)(8936002)(2616005)(86362001)(6486002)(478600001)(316002)(110136005)(36756003)(41300700001)(186003)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5355 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: beb499d6-57aa-42ab-8a01-08daaddc3106 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b+U3BBVeLN/Tf02VG+k6Tt2xr0vX8XX3RC7sKM/gv3Pb11sleRSowzXZ5qnXUGJ/PlUZ5rbDQsSBiGxc1LOpXAiG4oibachW4BnWwPp9joBDkPhAkeZh/aacPZ7mRe1EKOayvDsRop1Mk4IRANX1i2/DPXqLYsn4hdT+1sNWlEZw0kVqRr+nuHPke8YTRz1imiqmPugANq56jl8ccTbaKeaLMSfgv1neW3A0vTYhR868LyBseN8TwwSptXe0BTH+CD7PitpDCuTmHSXH/Zk/UNSzfTbenkc64y2va57gkgjaFJG1jVB7HWmxyWrPT75cTLhrV/azgdMTZCozby7THueNmaGWxkNO+bfdcArH/viaH0FtOtEbRn0QV+TJojQ5bSwfw1Qv1RW9AxyHKPoIqoHdJvmwWEf0bBzSTpYwds6+d13VMz8zokuyLZb3AcrpuIIsrzVqeGfCqVHWnw5OYlCrpRdsCUTUl9HtZTYG8NPG+CTBvNvTFz5SNUgEbu3XlKQuR6X4eH67gAdd3xobwl8CI7XsMZfkxVdRzgfTSerqjbOjASerHWiAZCR0CCVSWAW8CE4lTatRydXWosFRqej35Qeuadzw2lShuhMCtxQ5Y+yqojX4nGe/MTtJJ5F9VMWbnvd4D/SdBycW1No4QZ6HiFXXoAp75+5Xwm3+4dIB8W2eDxirjkbBSjWZsXnwHFjsqtBj0gBbjUWLbfAyr4EdHAIgQz+xXmC/brpX0EH0IAWv+FT98BHHKirtxrPJvKYrVTtkAYioZV/mRA+fXByNDwjS6YIkQ7LXS3oOLCwxv81XP6ZRutIEzXi/8OkM X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(46966006)(36840700001)(40470700004)(110136005)(4744005)(4326008)(82310400005)(8936002)(70206006)(70586007)(316002)(8676002)(41300700001)(478600001)(36756003)(5660300002)(186003)(36860700001)(40460700003)(44832011)(6486002)(82740400003)(356005)(6666004)(40480700001)(6512007)(26005)(2616005)(31696002)(53546011)(336012)(86362001)(6506007)(47076005)(81166007)(31686004)(4001150100001)(2906002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 12:04:15.0184 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eac7e27c-5473-4e76-bd79-08daaddc36cf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9617 X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 12:04:22 -0000 On 10/14/22 12:45, Pedro Alves wrote: > On 2022-10-13 7:11 p.m., Torbjörn SVENSSON wrote: >> When it's impossible to read the FPCCR and XPSR, the unwinding is >> unpredictable as the it's not possible to determine the correct >> frame size or padding. >> The only sane thing to do in this condition is to stop the unwinding. >> >> Example session wihtout this patch: > > wihtout -> without > > Thank you, this version LGTM. This way, there's a better chance gdb can > distinguish different "outermost" frames, e.g., for watchpoints on local vars, > or for stepping from a "broken" frame, to another "broken" frame. > > I'll defer final approval to Luis. > > Reviewed-by: Pedro Alves LGTM.