From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 6E6533858D35 for ; Thu, 5 Jan 2023 16:17:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E6533858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AEA633FF4C; Thu, 5 Jan 2023 16:17:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 996F913338; Thu, 5 Jan 2023 16:17:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aI1EJBz4tmNkQgAAMHmgww (envelope-from ); Thu, 05 Jan 2023 16:17:32 +0000 Message-ID: Date: Thu, 5 Jan 2023 17:17:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] Initial implementation of Debugger Adapter Protocol Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20220901163059.3678708-1-tromey@adacore.com> <16a7949d-4a65-28a4-732e-44e6b99f9478@suse.de> <87fscpf1hu.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87fscpf1hu.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -0.10 X-Spamd-Result: default: False [-0.10 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/5/23 16:24, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> In case you haven't seen it, on IRC someone mentioned: > > I didn't. > > Tom> diff --git a/gdb/python/lib/gdb/dap/io.py b/gdb/python/lib/gdb/dap/io.py > Tom> index 656ac08b4ec..1d561f07665 100644 > Tom> --- a/gdb/python/lib/gdb/dap/io.py > Tom> +++ b/gdb/python/lib/gdb/dap/io.py > Tom> @@ -22,7 +22,7 @@ def read_json(stream): > Tom> """Read a JSON-RPC message from STREAM. > Tom> The decoded object is returned.""" > Tom> # First read and parse the header. > Tom> - content_length = None > Tom> + content_length = 0 > Tom> while True: > Tom> line = stream.readline() > Tom> line = line.strip() > > In this case, though, the protocol request is malformed and I think it's > fine for gdb to just give up. > I see. > TBH I am not sure what should officially happen for a malformed request. > I don't think the docs I read address this. Agreed, I also couldn't find that info. I suppose we can try to use a more intuitive message for the exception, say "malformed DAP request". Thanks, - Tom