From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C299F3858C2D for ; Fri, 10 Feb 2023 09:15:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C299F3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 049DA610EE; Fri, 10 Feb 2023 09:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676020544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A8ujnsJUKjOi2un6TgM6b4GD2s/tiLnThSGppruNIxk=; b=XSb696ZD3HPm7exqohAy+awt5kK023Ss293RrvRVMYvrwOV5v5P0EyW5NNItMsD10Ctn/b qJYBO6shh407k97xv0BXcDt5K+I7AjgX7iFuWwNEU/PKzH1zLnh68pbsMEBkLHY9+UmiJP 8v99IQnGDqIkX+zo7B4SCV8VPBuzPtw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676020544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A8ujnsJUKjOi2un6TgM6b4GD2s/tiLnThSGppruNIxk=; b=ZoMHab+5ZephwplE6upehQmN0AAEHZmCNEKNXM1pzQKThSsORmRR1pQPis6B7mS712nW3K Sp3lLqzWg/WzAmDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E546213588; Fri, 10 Feb 2023 09:15:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aBnuNj8L5mPKIwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 09:15:43 +0000 Content-Type: multipart/mixed; boundary="------------GQy0bvwJUpb94WAidDmgc5S0" Message-ID: Date: Fri, 10 Feb 2023 10:15:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC] [gdb/cli] Add maint info frame-unwinders Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20230209130658.4860-1-tdevries@suse.de> <83y1p7kkr8.fsf@gnu.org> From: Tom de Vries In-Reply-To: <83y1p7kkr8.fsf@gnu.org> X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------GQy0bvwJUpb94WAidDmgc5S0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/9/23 14:53, Eli Zaretskii wrote: >> Date: Thu, 9 Feb 2023 14:06:58 +0100 >> From: Tom de Vries via Gdb-patches >> >> Add a new command "maint info frame-unwinders" > > Thanks. > >> +@kindex maint info frame-unwinders >> +@item maint info frame-unwinders >> +List frame unwinders, starting with the highest priority. > ^^^^^^^^^^^^^^^^^^^^ > I'd suggest "List the frame unwinders currently in effect", or > something like it. "List frame unwinders" is too terse, and possibly > also not entirely correct English-wise. > Thanks for spotting that. Fixed in both the docs and the help message. > What about NEWS? should this be called out there? Added. I've also added a Reviewed-By tag. Any further comments? Thanks, - Tom --------------GQy0bvwJUpb94WAidDmgc5S0 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-cli-Add-maint-info-frame-unwinders.patch" Content-Disposition: attachment; filename="0001-gdb-cli-Add-maint-info-frame-unwinders.patch" Content-Transfer-Encoding: base64 RnJvbSAwZTFmMGYzNzk3ZmFjZWFhNGExM2QzYmYxMTE2MmRhMmRmNmVhNWQ0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFRodSwgOSBGZWIgMjAyMyAwOTo1NzozNCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IFtnZGIvY2xpXSBBZGQgbWFpbnQgaW5mbyBmcmFtZS11bndpbmRlcnMKCkFkZCBhIG5ldyBj b21tYW5kICJtYWludCBpbmZvIGZyYW1lLXVud2luZGVycyI6Ci4uLgooZ2RiKSBoZWxwIG1h aW50IGluZm8gZnJhbWUtdW53aW5kZXJzCkxpc3QgdGhlIGZyYW1lIHVud2luZGVycyBjdXJy ZW50bHkgaW4gZWZmZWN0LCBzdGFydGluZyB3aXRoIHRoZSBoaWdoZXN0IFwKICBwcmlvcml0 eS4KLi4uCgpPdXRwdXQgZm9yIGkzODY6Ci4uLgokIGdkYiAtcSAtYmF0Y2ggLWV4ICJzZXQg YXJjaCBpMzg2IiAtZXggIm1haW50IGluZm8gZnJhbWUtdW53aW5kZXJzIgpUaGUgdGFyZ2V0 IGFyY2hpdGVjdHVyZSBpcyBzZXQgdG8gImkzODYiLgpkdW1teSAgICAgICAgICAgICAgICAg ICBEVU1NWV9GUkFNRQpkd2FyZjIgdGFpbGNhbGwgICAgICAgICBUQUlMQ0FMTF9GUkFNRQpp bmxpbmUgICAgICAgICAgICAgICAgICBJTkxJTkVfRlJBTUUKaTM4NiBlcGlsb2d1ZSAgICAg ICAgICAgTk9STUFMX0ZSQU1FCmR3YXJmMiAgICAgICAgICAgICAgICAgIE5PUk1BTF9GUkFN RQpkd2FyZjIgc2lnbmFsICAgICAgICAgICBTSUdUUkFNUF9GUkFNRQppMzg2IHN0YWNrIHRy YW1wICAgICAgICBOT1JNQUxfRlJBTUUKaTM4NiBzaWd0cmFtcCAgICAgICAgICAgU0lHVFJB TVBfRlJBTUUKaTM4NiBwcm9sb2d1ZSAgICAgICAgICAgTk9STUFMX0ZSQU1FCi4uLgoKT3V0 cHV0IGZvciB4ODZfNjQ6Ci4uLgokIGdkYiAtcSAtYmF0Y2ggLWV4ICJzZXQgYXJjaCBpMzg2 Ong4Ni02NCIgLWV4ICJtYWludCBpbmZvIGZyYW1lLXVud2luZGVycyIKVGhlIHRhcmdldCBh cmNoaXRlY3R1cmUgaXMgc2V0IHRvICJpMzg2Ong4Ni02NCIuCmR1bW15ICAgICAgICAgICAg ICAgICAgIERVTU1ZX0ZSQU1FCmR3YXJmMiB0YWlsY2FsbCAgICAgICAgIFRBSUxDQUxMX0ZS QU1FCmlubGluZSAgICAgICAgICAgICAgICAgIElOTElORV9GUkFNRQpweXRob24gICAgICAg ICAgICAgICAgICBOT1JNQUxfRlJBTUUKYW1kNjQgZXBpbG9ndWUgICAgICAgICAgTk9STUFM X0ZSQU1FCmkzODYgZXBpbG9ndWUgICAgICAgICAgIE5PUk1BTF9GUkFNRQpkd2FyZjIgICAg ICAgICAgICAgICAgICBOT1JNQUxfRlJBTUUKZHdhcmYyIHNpZ25hbCAgICAgICAgICAgU0lH VFJBTVBfRlJBTUUKYW1kNjQgc2lndHJhbXAgICAgICAgICAgU0lHVFJBTVBfRlJBTUUKYW1k NjQgcHJvbG9ndWUgICAgICAgICAgTk9STUFMX0ZSQU1FCmkzODYgc3RhY2sgdHJhbXAgICAg ICAgIE5PUk1BTF9GUkFNRQppMzg2IHNpZ3RyYW1wICAgICAgICAgICBTSUdUUkFNUF9GUkFN RQppMzg2IHByb2xvZ3VlICAgICAgICAgICBOT1JNQUxfRlJBTUUKLi4uCgpUZXN0ZWQgb24g eDg2XzY0LWxpbnV4LgoKUmV2aWV3ZWQtQnk6IFRvbSBUcm9tZXkgPHRvbUB0cm9tZXkuY29t PgpSZXZpZXdlZC1CeTogRWxpIFphcmV0c2tpaSA8ZWxpekBnbnUub3JnPgotLS0KIGdkYi9O RVdTICAgICAgICAgICAgfCAgNCArKysrCiBnZGIvZG9jL2dkYi50ZXhpbmZvIHwgIDQgKysr KwogZ2RiL2ZyYW1lLXVud2luZC5jICB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCiBnZGIvZnJhbWUuYyAgICAgICAgIHwgIDQgKystLQogZ2RiL2ZyYW1lLmggICAg ICAgICB8ICA0ICsrKysKIDUgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nZGIvTkVXUyBiL2dkYi9ORVdTCmluZGV4IDE1 NjdjYmVhOWJkLi5iODU5MjNjZjgwZCAxMDA2NDQKLS0tIGEvZ2RiL05FV1MKKysrIGIvZ2Ri L05FV1MKQEAgLTUyLDYgKzUyLDEwIEBAIG1haW50ZW5hbmNlIHByaW50IHJlY29yZC1pbnN0 cnVjdGlvbiBbIE4gXQogICBwcmludHMgaG93IEdEQiB3b3VsZCB1bmRvIHRoZSBOLXRoIHBy ZXZpb3VzIGluc3RydWN0aW9uLCBhbmQgaWYgTiBpcwogICBwb3NpdGl2ZSwgaXQgcHJpbnRz IGhvdyBHREIgd2lsbCByZWRvIHRoZSBOLXRoIGZvbGxvd2luZyBpbnN0cnVjdGlvbi4KIAor bWFpbnRlbmFuY2UgaW5mbyBmcmFtZS11bndpbmRlcnMKKyAgTGlzdCB0aGUgZnJhbWUgdW53 aW5kZXJzIGN1cnJlbnRseSBpbiBlZmZlY3QsIHN0YXJ0aW5nIHdpdGggdGhlIGhpZ2hlc3QK KyAgcHJpb3JpdHkuCisKICogTUkgY2hhbmdlcwogCiAqKiBtaSBub3cgcmVwb3J0cyAnbm8t aGlzdG9yeScgYXMgYSBzdG9wIHJlYXNvbiB3aGVuIGhpdHRpbmcgdGhlIGVuZCBvZiB0aGUK ZGlmZiAtLWdpdCBhL2dkYi9kb2MvZ2RiLnRleGluZm8gYi9nZGIvZG9jL2dkYi50ZXhpbmZv CmluZGV4IGVlYmI2ZGQ0MjJhLi43YjEyODA1M2I1YSAxMDA2NDQKLS0tIGEvZ2RiL2RvYy9n ZGIudGV4aW5mbworKysgYi9nZGIvZG9jL2dkYi50ZXhpbmZvCkBAIC00MDk4Niw2ICs0MDk4 NiwxMCBAQCB3aXRoIHRoZSBEV0FSRiBmcmFtZSB1bndpbmRlcnMgZW5hYmxlZC4KIElmIERX QVJGIGZyYW1lIHVud2luZGVycyBhcmUgbm90IHN1cHBvcnRlZCBmb3IgYSBwYXJ0aWN1bGFy IHRhcmdldAogYXJjaGl0ZWN0dXJlLCB0aGVuIGVuYWJsaW5nIHRoaXMgZmxhZyBkb2VzIG5v dCBjYXVzZSB0aGVtIHRvIGJlIHVzZWQuCiAKK0BraW5kZXggbWFpbnQgaW5mbyBmcmFtZS11 bndpbmRlcnMKK0BpdGVtIG1haW50IGluZm8gZnJhbWUtdW53aW5kZXJzCitMaXN0IHRoZSBm cmFtZSB1bndpbmRlcnMgY3VycmVudGx5IGluIGVmZmVjdCwgc3RhcnRpbmcgd2l0aCB0aGUg aGlnaGVzdCBwcmlvcml0eS4KKwogQGtpbmRleCBtYWludCBzZXQgd29ya2VyLXRocmVhZHMK IEBraW5kZXggbWFpbnQgc2hvdyB3b3JrZXItdGhyZWFkcwogQGl0ZW0gbWFpbnQgc2V0IHdv cmtlci10aHJlYWRzCmRpZmYgLS1naXQgYS9nZGIvZnJhbWUtdW53aW5kLmMgYi9nZGIvZnJh bWUtdW53aW5kLmMKaW5kZXggYjcwOGM2NGY5NjcuLjc2NjAxZmFhNDc5IDEwMDY0NAotLS0g YS9nZGIvZnJhbWUtdW53aW5kLmMKKysrIGIvZ2RiL2ZyYW1lLXVud2luZC5jCkBAIC0yOCw2 ICsyOCw3IEBACiAjaW5jbHVkZSAidGFyZ2V0LmgiCiAjaW5jbHVkZSAiZ2RiYXJjaC5oIgog I2luY2x1ZGUgImR3YXJmMi9mcmFtZS10YWlsY2FsbC5oIgorI2luY2x1ZGUgImNsaS9jbGkt Y21kcy5oIgogCiBzdHJ1Y3QgZnJhbWVfdW53aW5kX3RhYmxlX2VudHJ5CiB7CkBAIC0zMzcs MyArMzM4LDM0IEBAIGZyYW1lX3Vud2luZF9nb3RfYWRkcmVzcyAoZnJhbWVfaW5mb19wdHIg ZnJhbWUsIGludCByZWdudW0sCiAJICAgICByZWdpc3Rlcl90eXBlIChnZGJhcmNoLCByZWdu dW0pLCBhZGRyKTsKICAgcmV0dXJuIHJlZ192YWw7CiB9CisKKy8qIEltcGxlbWVudCAibWFp bnRlbmFuY2UgaW5mbyBmcmFtZS11bndpbmRlcnMiIGNvbW1hbmQuICAqLworCitzdGF0aWMg dm9pZAorbWFpbnRlbmFuY2VfaW5mb19mcmFtZV91bndpbmRlcnMgKGNvbnN0IGNoYXIgKmFy Z3MsIGludCBmcm9tX3R0eSkKK3sKKyAgc3RydWN0IGdkYmFyY2ggKmdkYmFyY2ggPSB0YXJn ZXRfZ2RiYXJjaCAoKTsKKyAgc3RydWN0IGZyYW1lX3Vud2luZF90YWJsZSAqdGFibGUgPSBn ZXRfZnJhbWVfdW53aW5kX3RhYmxlIChnZGJhcmNoKTsKKworICBmb3IgKHN0cnVjdCBmcmFt ZV91bndpbmRfdGFibGVfZW50cnkgKmVudHJ5ID0gdGFibGUtPmxpc3Q7IGVudHJ5ICE9IE5V TEw7CisgICAgICAgZW50cnkgPSBlbnRyeS0+bmV4dCkKKyAgICB7CisgICAgICBjb25zdCBj aGFyICpuYW1lID0gZW50cnktPnVud2luZGVyLT5uYW1lOworICAgICAgY29uc3QgY2hhciAq dHlwZSA9IGZyYW1lX3R5cGVfc3RyIChlbnRyeS0+dW53aW5kZXItPnR5cGUpOworCisgICAg ICBnZGJfcHJpbnRmIChnZGJfc3Rkb3V0LCAiJS0xNnNcdCUtMTZzXG4iLCBuYW1lLCB0eXBl KTsKKyAgICB9Cit9CisKK3ZvaWQgX2luaXRpYWxpemVfZnJhbWVfdW53aW5kICgpOwordm9p ZAorX2luaXRpYWxpemVfZnJhbWVfdW53aW5kICgpCit7CisgIC8qIEFkZCAibWFpbnQgaW5m byBmcmFtZS11bndpbmRlcnMiLiAgKi8KKyAgYWRkX2NtZCAoImZyYW1lLXVud2luZGVycyIs CisJICAgY2xhc3NfbWFpbnRlbmFuY2UsCisJICAgbWFpbnRlbmFuY2VfaW5mb19mcmFtZV91 bndpbmRlcnMsCisJICAgXygiTGlzdCB0aGUgZnJhbWUgdW53aW5kZXJzIGN1cnJlbnRseSBp biBlZmZlY3QsICIKKwkgICAgICJzdGFydGluZyB3aXRoIHRoZSBoaWdoZXN0IHByaW9yaXR5 LiIpLAorCSAgICZtYWludGVuYW5jZWluZm9saXN0KTsKK30KZGlmZiAtLWdpdCBhL2dkYi9m cmFtZS5jIGIvZ2RiL2ZyYW1lLmMKaW5kZXggOTIzNWEyY2ViMzguLmM2OWEzZWEwY2IwIDEw MDY0NAotLS0gYS9nZGIvZnJhbWUuYworKysgYi9nZGIvZnJhbWUuYwpAQCAtNDM5LDkgKzQz OSw5IEBAIGZyYW1lX2lkOjp0b19zdHJpbmcgKCkgY29uc3QKICAgcmV0dXJuIHJlczsKIH0K IAotLyogUmV0dXJuIGEgc3RyaW5nIHJlcHJlc2VudGF0aW9uIG9mIFRZUEUuICAqLworLyog U2VlIGZyYW1lLmguICAqLwogCi1zdGF0aWMgY29uc3QgY2hhciAqCitjb25zdCBjaGFyICoK IGZyYW1lX3R5cGVfc3RyIChmcmFtZV90eXBlIHR5cGUpCiB7CiAgIHN3aXRjaCAodHlwZSkK ZGlmZiAtLWdpdCBhL2dkYi9mcmFtZS5oIGIvZ2RiL2ZyYW1lLmgKaW5kZXggNGE5OWJkNjYw ZGYuLjZlZDhkYjBhZjU2IDEwMDY0NAotLS0gYS9nZGIvZnJhbWUuaAorKysgYi9nZGIvZnJh bWUuaApAQCAtMjAzLDYgKzIwMywxMCBAQCBlbnVtIGZyYW1lX3R5cGUKICAgU0VOVElORUxf RlJBTUUKIH07CiAKKy8qIFJldHVybiBhIHN0cmluZyByZXByZXNlbnRhdGlvbiBvZiBUWVBF LiAgKi8KKworZXh0ZXJuIGNvbnN0IGNoYXIgKmZyYW1lX3R5cGVfc3RyIChmcmFtZV90eXBl IHR5cGUpOworCiAvKiBBIHdyYXBwZXIgZm9yICJmcmFtZV9pbmZvICoiLiAgZnJhbWVfaW5m byBvYmplY3RzIGFyZSBpbnZhbGlkYXRlZAogICAgd2hlbmV2ZXIgcmVpbml0X2ZyYW1lX2Nh Y2hlIGlzIGNhbGxlZC4gIFRoaXMgY2xhc3MgYXJyYW5nZXMgdG8KICAgIGludmFsaWRhdGUg dGhlIHBvaW50ZXIgd2hlbiBhcHByb3ByaWF0ZS4gIFRoaXMgaXMgZG9uZSB0byBoZWxwCgpi YXNlLWNvbW1pdDogYWExODA3NDE5YmEwYjZmYTRhOGI0OTdiYWJjMWM4OWIyN2U2NjdlNQot LSAKMi4zNS4zCgo= --------------GQy0bvwJUpb94WAidDmgc5S0--