From: Pedro Alves <palves@redhat.com>
To: Kevin Buettner <kevin@buettner.to>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Make gdb.PendingFrame.read_register handle "user" registers
Date: Wed, 12 Oct 2016 13:08:00 -0000 [thread overview]
Message-ID: <f04262cd-3fcf-a195-e9d9-31604a22b738@redhat.com> (raw)
In-Reply-To: <20160928015602.600071c6@pinnacle.lan>
On 09/28/2016 09:56 AM, Kevin Buettner wrote:
> Make gdb.PendingFrame.read_register handle "user" registers.
>
> The C function, pending_framepy_read_register(), which implements
> the python interface gdb.PendingFrame.read_register does not handle
> the so called "user" registers like "pc". An assertion error is
> triggered due to the user registers having numbers larger than or
> equal to gdbarch_num_regs(gdbarch).
>
> With the VALUE_FRAME_ID tweak in place, the call to
> get_frame_register_value() can simply be replaced by a call to
> value_of_register(), which handles both real registers as well as the
> user registers.
>
> gdb/ChangeLog:
>
> * python/py-unwind.c (pending_framepy_read_register): Use
> value_of_register() instead of get_frame_register_value().
OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-10-12 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 8:49 [PATCH 0/4] Prevent more recursion into python based unwinders Kevin Buettner
2016-09-28 8:53 ` [PATCH 1/4] Distinguish sentinel frame from null frame Kevin Buettner
2016-10-12 13:07 ` Pedro Alves
2016-10-26 7:22 ` Kevin Buettner
2016-10-28 5:26 ` Kevin Buettner
2016-09-28 8:56 ` [PATCH 2/4] Tweak meaning of VALUE_FRAME_ID Kevin Buettner
2016-10-12 13:08 ` Pedro Alves
2016-09-28 8:59 ` [PATCH 3/4] Make gdb.PendingFrame.read_register handle "user" registers Kevin Buettner
2016-10-12 13:08 ` Pedro Alves [this message]
2016-09-28 12:41 ` [PATCH 4/4] py-unwind-maint.exp: Allow unwinders to be called during python import Kevin Buettner
2016-10-12 13:10 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f04262cd-3fcf-a195-e9d9-31604a22b738@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevin@buettner.to \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).