public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: John Baldwin <jhb@FreeBSD.org>
To: Joubert Nel <joubert@joubster.com>,
	simon.marchi@polymtl.ca, Tom Tromey <tom@tromey.com>,
	Kevin Buettner <kevinb@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: Feedback sought: patch to enable gdb to build on macOS Mojave
Date: Mon, 25 Feb 2019 22:41:00 -0000	[thread overview]
Message-ID: <f0a59aeb-b730-3e8b-401a-6699cd22a41f@FreeBSD.org> (raw)
In-Reply-To: <F9A725D6-B8D9-419A-9864-D811B8A465B5@joubster.com>

On 2/23/19 3:14 PM, Joubert Nel wrote:
> Thanks for the review, John & Simon. 
> 
> Your feedback makes sense and I’ve revised the suggested patch accordingly: https://gist.github.com/joubertnel/267ca0fff4eaad494cc19ec3ba7953ed <https://gist.github.com/joubertnel/267ca0fff4eaad494cc19ec3ba7953ed>

I think this looks fine, but you should send it as a normal patch as Kevin
and Tom noted previously.

-- 
John Baldwin

                                                                            

      reply	other threads:[~2019-02-25 22:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 17:41 Joubert Nel
2019-02-18 20:38 ` Kevin Buettner
2019-02-18 22:47   ` Tom Tromey
2019-02-20  6:50     ` Joubert Nel
2019-02-20 16:49       ` John Baldwin
2019-02-23 23:14         ` Joubert Nel
2019-02-25 22:41           ` John Baldwin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0a59aeb-b730-3e8b-401a-6699cd22a41f@FreeBSD.org \
    --to=jhb@freebsd.org \
    --cc=gdb-patches@sourceware.org \
    --cc=joubert@joubster.com \
    --cc=kevinb@redhat.com \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).