From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45427 invoked by alias); 25 Feb 2019 22:41:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45410 invoked by uid 89); 25 Feb 2019 22:41:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=nel, Hx-languages-length:637, H*r:24b, H*r:sk:client- X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Feb 2019 22:41:38 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 9E9879509F; Mon, 25 Feb 2019 22:41:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E4820855B6; Mon, 25 Feb 2019 22:41:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4E8CA1603F; Mon, 25 Feb 2019 22:41:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: Feedback sought: patch to enable gdb to build on macOS Mojave To: Joubert Nel , simon.marchi@polymtl.ca, Tom Tromey , Kevin Buettner , gdb-patches@sourceware.org References: <3A32D160-EC89-4615-8327-041B154923B9@joubster.com> <20190218133855.7525c484@f29-4.lan> <87d0nolnnb.fsf@tromey.com> <7ff6bf6d-1d02-6e87-e734-2f6177efcc9e@FreeBSD.org> From: John Baldwin Openpgp: preference=signencrypt Message-ID: Date: Mon, 25 Feb 2019 22:41:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E4820855B6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.95 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; NEURAL_HAM_SHORT(-0.95)[-0.952,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00424.txt.bz2 On 2/23/19 3:14 PM, Joubert Nel wrote: > Thanks for the review, John & Simon. > > Your feedback makes sense and I’ve revised the suggested patch accordingly: https://gist.github.com/joubertnel/267ca0fff4eaad494cc19ec3ba7953ed I think this looks fine, but you should send it as a normal patch as Kevin and Tom noted previously. -- John Baldwin                                                                            Â