From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 8277E385840B for ; Fri, 29 Sep 2023 10:08:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8277E385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BF844218E9; Fri, 29 Sep 2023 10:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695982106; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCoYqIezFTO46WcZMx7h17RIcqL6PJ1q+8NwbTB1TPc=; b=whE1lRCY6DRMWO1A8cbP3PV/WYokIpes72ZhBcS0S568D0eEnjvBVUoWkjEROYoMYNVJIx F8kADQYekyByZ4oy1ofMiEOGeOezeykifpWpeppAvWw1wOdL6B2IMLhf1MnbGIBP+0OVOT e8utS3l95PqTnZO3PmFfiACLvMZaBUE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695982106; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCoYqIezFTO46WcZMx7h17RIcqL6PJ1q+8NwbTB1TPc=; b=KXOAmJKez5rhrcZ5CNT1cVeE8Q9Qq/gLloltzGxcUjbJBEdyZ1fEW4UrT3A0CewLPW86c+ BgxKFcGp/uie4+Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC1D31390A; Fri, 29 Sep 2023 10:08:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jR3ZKBqiFmXDHQAAMHmgww (envelope-from ); Fri, 29 Sep 2023 10:08:26 +0000 Message-ID: Date: Fri, 29 Sep 2023 12:08:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] [gdb/tui] Fix segfault in tui_find_disassembly_address Content-Language: en-US From: Tom de Vries To: Kevin Buettner , Tom de Vries via Gdb-patches References: <20230905150339.6452-1-tdevries@suse.de> <20230927091013.5b3a590d@f37-zws-nv> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/28/23 22:57, Tom de Vries wrote: > On 9/27/23 18:10, Kevin Buettner wrote: >> Hi Tom, >> >> On Tue,  5 Sep 2023 17:03:38 +0200 >> Tom de Vries via Gdb-patches wrote: >> >>> Fix the segfault by handling asm_lines.empty () results of >>> tui_disassemble in >>> tui_find_disassembly_address. >>> >>> I've written a unit test that exercises this scenario. >>> >>> Tested on x86_64-linux. >>> >>> PR tui/30823 >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30823 >> >> I don't know this area very well, but your explanation and patch look >> reasonable to me. >> >> Reviewed-by: Kevin Buettner > > Thanks for the review. > > I've committed this, but I now see there's a new warning: > ... > gdb/tui/tui-disasm.c: In function ‘CORE_ADDR > tui_find_disassembly_address(gdbarch*, CORE_ADDR, int)’: > gdb/tui/tui-disasm.c:293:7: warning: ‘last_addr’ may be used > uninitialized in this function [-Wmaybe-uninitialized] >        if (last_addr < pc) >        ^~ > ... > > I'll take a look. I've submitted a fix here ( https://sourceware.org/pipermail/gdb-patches/2023-September/202849.html ). Thanks, - Tom