From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2055.outbound.protection.outlook.com [40.107.249.55]) by sourceware.org (Postfix) with ESMTPS id 7E9DD3857013 for ; Wed, 26 Oct 2022 12:05:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E9DD3857013 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bwdSIoznGfeka0XACTSZ21iIwATPFBevAF57CIaRKhuHvfUSwLMruyO+KcFXbEcMXOoQo5YkO2wy59voUDpV7WPEkvt09mkS22WYE039lvCtLOIY+q7lFlW2p2AQBErndDF8oJJ7bFx6VMeFXWPTViw4T6WNvAK3N+CTR8iYKf4isZrcOxgKh2e7AqgbLnCFmcKHjwQJASajvcnBv8z/GJ2DMDYOFF1mEWjID1Nn43VL9IIalVYwYc5NGbC27f4NrpyxVc94hZ1QLWYsWwnFeie1B5FILAERxIcQ9+zJgCXhEV8BRMvQrj4GsKwhnxXTUAhCaOdgyuDmjVItH6tWMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fWDEPHYCNE6bUL8ZlvuPaanjuHYm5Of4aTfJFwSWOpQ=; b=BOnBBV1D7kiAABnZwSiAwJlB8pee412naZHuX5JJ0X3pLs2yu+S2hqBDj6rK2GLWNDkxCVtfdVuZCMwHFJj+YeL7oduGMqRsCO1ncJANPvtxzCa9RRyxfLW8NamegPI9dDfU6rB+RH+e/8IY7k0eUEvbvpuk9YUncExRY5PKOQ5GCLXotY9ACMqQ4TAiDJWVXBAY9dCYkb/K/cN+fa6tJ90eiWWZdrCakX2xDcXgwsBpc4CP2ZeZvK1M9T0Cxk6XvnsUB6UaZ8ekGeMayc+vK3ponaIjA4mRtmF2aHEkjTXFfRPKSmys+wKs8qmix6rM+nNc781MkGO3A7n4lAxi9Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fWDEPHYCNE6bUL8ZlvuPaanjuHYm5Of4aTfJFwSWOpQ=; b=c6qiC31A9yLovCvsWpMGZYjyF5Zly320B7lI769aJq1FeS6aDTidN1KjFFWvKwv2vAQjA2uN6uVmqZXJcWgeBR8ArkBOlYRq1p9wbgwn+fBhQFOPr3mj9thZazBvQzPICaBPQoXAudRnhhtbWTzhuhVtAUBieDWIk+waDC8RpNA= Received: from DU2PR04CA0183.eurprd04.prod.outlook.com (2603:10a6:10:28d::8) by DU0PR08MB8908.eurprd08.prod.outlook.com (2603:10a6:10:464::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:05:05 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::fa) by DU2PR04CA0183.outlook.office365.com (2603:10a6:10:28d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27 via Frontend Transport; Wed, 26 Oct 2022 12:05:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.10 via Frontend Transport; Wed, 26 Oct 2022 12:05:05 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Wed, 26 Oct 2022 12:05:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 89c1d1193ab30354 X-CR-MTA-TID: 64aa7808 Received: from ab3bbb6c42cf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CA3A71D4-8F2D-44CB-B398-F3293758A85B.1; Wed, 26 Oct 2022 12:04:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ab3bbb6c42cf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:04:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mCI0XT9dWuZtf2HpEniUO/IVbx0SKh+MN6FvJcVI0zCayHtRw6msFjiF0aaXDT4KeiakhILuC12nAQgewjfts7cIH/71uylDwSL67nncAa8qTFeC7S/hKRkDqj8h0gICViBTPY1MzJO26/lRP9yCM034a8MUj+LNYRbG70GE3yyl4JKlgmGVjzWm+T10oegPuF0Jy5Z4cWsy6knEkQXVHezxJt+hc0mQouFTfUW2Np2kEDGDVgtr9sEIRaGp/uUCH0GJ4GnaveA5B5Bp0jtQc/auG4MAuuDT0A1qDtcP58V09RRrBF/sU5ysmTT5NSc31LRH+6prg4xTKix7gtJcyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fWDEPHYCNE6bUL8ZlvuPaanjuHYm5Of4aTfJFwSWOpQ=; b=m5V2FHysgO52ZaVrtpEhNLg7zwL+EuP+ELyiDMiQ5ZvVhVfa24pA8SdXbtZukAOW3hWzRVNNgnUmxFCFrq8je/MiGa9Y9fSE4BS0lOOy8gMiAOdgjbUcRWjlmVQMmNl61+5h2qLx0Tf7zXOTjtpP+fzLN6eJVBJsnQZmVK0GuSWmjj9MgI4S01VjZK3RDlTyzkH3FPWlTXUJIpkORJCjHHtetjnFK+V1iYucII1XFqelPzfc23qfRvn7EKFHAk5zdLmWr4bdDa4EV6hYt6EOasui3D3XP6y/O9ZW9VKsTovgGi5LmX7A9SyeFO0lyds2JDNfVzTWe4Ns1Oc9515qXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fWDEPHYCNE6bUL8ZlvuPaanjuHYm5Of4aTfJFwSWOpQ=; b=c6qiC31A9yLovCvsWpMGZYjyF5Zly320B7lI769aJq1FeS6aDTidN1KjFFWvKwv2vAQjA2uN6uVmqZXJcWgeBR8ArkBOlYRq1p9wbgwn+fBhQFOPr3mj9thZazBvQzPICaBPQoXAudRnhhtbWTzhuhVtAUBieDWIk+waDC8RpNA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAVPR08MB9748.eurprd08.prod.outlook.com (2603:10a6:102:31f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 12:04:56 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7f57:1601:9b18:7529]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7f57:1601:9b18:7529%7]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022 12:04:56 +0000 Message-ID: Date: Wed, 26 Oct 2022 13:04:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] gdb/arm: fix IPSR field test in arm_m_exception_cache () Content-Language: en-US To: Tomas Vanek , gdb-patches@sourceware.org References: <1666427154-22766-1-git-send-email-vanekt@fbl.cz> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA0PR12CA0007.namprd12.prod.outlook.com (2603:10b6:806:6f::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAVPR08MB9748:EE_|DBAEUR03FT024:EE_|DU0PR08MB8908:EE_ X-MS-Office365-Filtering-Correlation-Id: 879e5fb2-590c-46fa-fb68-08dab74a5194 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: s4+A+g4nCJ02CPqFNsi3EgIngYc+lOlI9AyfhrSSSjFE+F1hvqT9CbnecH9g6rn/wOsQsIpyV7zV4rlNHl0M0mVr8X6GBdZfEMf1NV0bNvL4Sm0sTOQG/Ec4B2qo4+oe3XWPg9zuS2edu9azzdnuWp+M2Ff/1RkJ6i7tInKaugLqzsSoWcrTO+VmL8B5t+LRvW+KjcEfhTzXLL9ByzRFCNyKQkOEgJZqnd3Yqx7z+7eTry8BKcln5Irw2vANE9zHVF+x40T6ukP0PITgd/t8Lo4MMTLHJ4VCvQH1jwnL/VGZBJmOzdv9p5FgsJc5crUPoUrSsezfW3JP4zYYTt1NgUdjpk1bW8ZVZlr/j25dGx7NX6dZporuEf7tfqBayYx4wrszvfakYUoZRyfvmFwZaVy9SgrfizKqO2dTA7omBrvwZA3MWKknvnI9GWb5g2e8i3OWc+sXSUuU9y9lh1nFonT7xEc54aw/0LJNNAuRj0T1W6qid6JR2ZCmxXsbKW30aMml5GPtvki9W3eG/zgShryjLnCMgwXcwotLg6hmmw60/P0GzlUvvssU1ir+UDZ64cTtNkcqTo9zsEN3vJelyay2EDxbKtx6eY30WTXzZ5dZmeC2nI8gdkxjx8RXoVG4eRU7Kj6jJzhp260GNEen/TbxoIU8wJQW3/fdKV35d+eUQsKTJzhK6yX3zR0Cc29KBnUXdTzWeFD9kwKs4c72jOx1bV1ToR2k7aB8eTPyMma7y16AHANbhPYGyzupUJxrtiYg/VgjoptNHl3u+Vrec2V52so92RbuhKB1DDmjFCE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199015)(8936002)(5660300002)(41300700001)(26005)(36756003)(6512007)(83380400001)(38100700002)(2616005)(186003)(44832011)(2906002)(31686004)(6486002)(478600001)(316002)(86362001)(6506007)(53546011)(66556008)(66476007)(8676002)(66946007)(6666004)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9748 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ff6e9ab-cf2c-480a-c1e9-08dab74a4c26 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O8UQYChAQYx4FjW8QajHnuEBxpTBuYO12SgFsuSsTdV/znBcvSU6oCOSZ77nJSQ1prvchGy9HVwJGFXtSLrItbOcUmkWGX0vIdPUGgClyLFFPqeHNVQsMJfbqAcaZ/+tS81ut8wxKslgmvJsCG+K5IHVqiCIvLRcxQiKT4FN4sVbSXK+/ODwwb4Al+lQ/ad5WM5/wsn4euHrEAmghporIB5YFoZL548yECtLLBRo+0NOsaJu8BCjw3snHdJ4IXBd00zFTMmgX7MjljgdlQQfBH+Rfi0pjuoeLLmIOent3j/0xCE2HeEmAYlV0ae6DO903iz/jK1gUOWiwPs/HlATqkSpEslYy9cgDxNDgL1U9kiSC4hlv+uSWmMI41L5O10/QbqSCVSfCy0sO5JkEleEnTJsIoizUAnfQC7OZhhZOO2wwPMhQgYgzgnn3fjYzSkjqk6Gh7r+PTPysB3hcqCr7nRCKCIM+m4Oa7gt1KeJeFgFaWETURnChDqgTOR5kkbDbeldh1ixB7foyqYShrb87dCELvebBP4IsfaERc/lZvuQPlfBDE1/TvfJ5e4CWyEnnfKso9WHNTC8G4DRp1inRSNnbPaQD0Zn3a2QBvqaMUSEoV2t6stpFjiyATZCFOZnr3tLaOxnQ0cvSwbq1DGZDCjOe1vRPHu1vZZz2KZp8uwc9RC8knR1E/Qdh0tfZRQuJVtKI+GA7GInmPCfvLp2aypV48xtfceqddippB0Vye2ZfEuaZqg2H/vcrwKIZ9/i0uS5yqNYAvHn7dufbgMkmyN+AwxsNB5HGKLyaEKuBQzL783S6FX7YaH2BN+jo0YC X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(31696002)(70586007)(8936002)(70206006)(2906002)(8676002)(40480700001)(81166007)(41300700001)(316002)(5660300002)(86362001)(186003)(83380400001)(36860700001)(82740400003)(478600001)(6666004)(336012)(47076005)(6486002)(356005)(6506007)(53546011)(40460700003)(2616005)(6512007)(26005)(44832011)(31686004)(82310400005)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:05:05.0527 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 879e5fb2-590c-46fa-fb68-08dab74a5194 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8908 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/25/22 14:22, Luis Machado via Gdb-patches wrote: > Hi Tomas, > > On 10/22/22 09:25, Tomas Vanek wrote: >> Arm v8-M Architecture Reference Manual, >> D1.2.141 IPSR, Interrupt Program Status Register reads >> "Exception, bits [8:0]" >> >> 9 bits, not 8! It is uncommon but true! >> >> Signed-off-by: Tomas Vanek >> --- >>   gdb/arm-tdep.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c >> index b397ca3..923447a 100644 >> --- a/gdb/arm-tdep.c >> +++ b/gdb/arm-tdep.c >> @@ -3441,7 +3441,7 @@ struct frame_unwind arm_stub_unwind = { >>       } >>         ULONGEST xpsr = get_frame_register_unsigned (this_frame, ARM_PS_REGNUM); >> -      if ((xpsr & 0xff) != 0) >> +      if ((xpsr & 0x1ff) != 0) >>       /* Handler mode: This is the mode that exceptions are handled in.  */ >>       arm_cache_switch_prev_sp (cache, tdep, tdep->m_profile_msp_s_regnum); >>         else > > Good catch. This LGTM. > > I suppose you need us to push this patch on your behalf? > > One thing that would be nice to do is to have a flags/fields type for XPSR, which > would then display things in a nicer way to the user. Something like CPSR for a-profile. Pushed.