From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 6859C386F0CC for ; Fri, 24 Jun 2022 15:17:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6859C386F0CC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f48.google.com with SMTP id 189so1031269wmz.2 for ; Fri, 24 Jun 2022 08:17:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=16tKi1sxCNeQznuXg7tCeTUhmbchldw37iTSUIkauYo=; b=FHne9jVbtV/cx+exui23f5fyHkhxC7tjnafax2RqikUVw2WnZRZ4rux6vtYp/Osq7b 194IFfJv9m1EOkS4vk9rzEl4MBNutGa0ulpO/7ZFl6wnQpVC45aTypbtdKRtSsrM2zy9 Ui/qghuEvSAoY688kRuT/QNZ3z/zyMB8aDD4Aza4mz8fgRpTB7CNz07dJAe8BUcPg5aV e7mL21xZ0A4kv5DScgRL4cuYongHeOTyJN0eeN+hDlMmfWlULyYrTgS3K30XKbL4kpMR 7oWaZmsaLeq9cTg4eYwGtTZubDCmams9/OSCzin/KFkHWdCWhaOD1pjO2DBxSUM8Ajhe F7ew== X-Gm-Message-State: AJIora8d8nx/+pJBTHbPBvcYVParnikVOuJgYDSgghJ6M84qmvVIU10N 0qsEF8AYJSNwcRogqnNa54P6jq1NLJg= X-Google-Smtp-Source: AGRyM1s37HGZ3q4T0DzhyRg8iryEmP4JcUQjwrz/uW/z5HfU/kNxNnbRxQS8oP3XFrob+tkiovfUgg== X-Received: by 2002:a1c:2902:0:b0:3a0:2a05:c639 with SMTP id p2-20020a1c2902000000b003a02a05c639mr4621795wmp.31.1656083821237; Fri, 24 Jun 2022 08:17:01 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id m17-20020a05600c3b1100b0039c5497deccsm10746707wms.1.2022.06.24.08.16.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 08:17:00 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 16:16:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] gdb/testsuite: modernize gdb.base/maint.exp Content-Language: en-US To: Bruno Larsen , gdb-patches@sourceware.org Cc: aburgess@redhat.com References: <87edzic8v1.fsf@redhat.com> <20220621194520.34682-1-blarsen@redhat.com> From: Pedro Alves In-Reply-To: <20220621194520.34682-1-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 15:17:05 -0000 On 2022-06-21 20:45, Bruno Larsen via Gdb-patches wrote: > +# When there is a problem, there may be loads of output, which can > +# overwhelm the expect buffer. Splitting it seems to fix those > +# issues. > + > +set seen_command 0 > +gdb_test_multiple "maint check-psymtabs" "" { > + -re "^maint check-psymtabs\r\n" { > + set seen_command 1 > + exp_continue > + } > > -# guo: on linux this command output is huge. for some reason splitting up > -# the regexp checks works. > -# > -send_gdb "maint check-psymtabs\n" > -gdb_expect { > - -re "^maint check-psymtabs" { > - gdb_expect { > - -re "$gdb_prompt $" { > - pass "maint check-psymtabs" > - } > - timeout { fail "(timeout) maint check-psymtabs" } > + -re "^$gdb_prompt $" { > + if { $seen_command == 1 } { > + pass "maint check-psymtabs" > + } else { > + fail $gdb_test_name > } > } > - -re ".*$gdb_prompt $" { fail "maint check-psymtabs" } > - timeout { fail "(timeout) maint check-psymtabs" } > + > + -re "^\[^\r\n\]+\r\n" { > + exp_continue > + } I think that instead of adding this line match, you can pass -lbl to gdb_test_multiple.