From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <palves@redhat.com>,
Bernd Edlinger <bernd.edlinger@hotmail.de>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCHv2] Make "skip" work on inline frames
Date: Thu, 31 Oct 2019 16:53:00 -0000 [thread overview]
Message-ID: <f12850fb-6eee-ea5c-adb8-684ca7644c7b@simark.ca> (raw)
In-Reply-To: <c6215231-ad0c-e52c-3b4e-0d8f72c52a2a@redhat.com>
On 2019-10-31 12:42 p.m., Pedro Alves wrote:
> On 10/30/19 9:56 PM, Bernd Edlinger wrote:
>> +if { [prepare_for_testing "failed to prepare" "skip2" \
>> + {skip2.c skip1.c } \
>> + {debug nowarnings optimize=-O2}] } {
>
> Instead of -O2, could you make this use -O0 (the default),
> and then use attribute((always_inline)) to force inlining?
> We do that in some tests. E.g., gdb.opt/inline-locals.c.
I think that's a good suggestion, but just be aware that there used to be
some problems with always_inline, e.g.:
https://sourceware.org/bugzilla/show_bug.cgi?id=13263
https://sourceware.org/bugzilla/show_bug.cgi?id=12429
I'm not sure if those are still valid. If they are, it might be more difficult
that expected to use always_inline.
Simon
next prev parent reply other threads:[~2019-10-31 16:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 12:52 [PATCH] " Bernd Edlinger
2019-10-19 4:40 ` Bernd Edlinger
2019-10-20 6:48 ` [PATCHv2] " Bernd Edlinger
2019-10-26 8:06 ` [PING] " Bernd Edlinger
2019-10-27 1:52 ` Simon Marchi
2019-10-27 2:18 ` Simon Marchi
2019-10-30 21:56 ` Bernd Edlinger
2019-10-31 16:42 ` Pedro Alves
2019-10-31 16:53 ` Simon Marchi [this message]
2019-10-31 18:00 ` Pedro Alves
2019-10-31 19:19 ` [PATCHv3] " Bernd Edlinger
2019-11-24 11:22 ` [PATCHv4] " Bernd Edlinger
2019-12-01 20:46 ` [PING] " Bernd Edlinger
2019-12-02 2:34 ` Simon Marchi
2019-12-02 16:47 ` [PATCHv5] " Bernd Edlinger
2019-12-03 4:22 ` Simon Marchi
2019-12-14 13:55 ` [PING] " Bernd Edlinger
2019-12-15 0:46 ` Simon Marchi
2019-12-15 11:25 ` [PATCHv6] " Bernd Edlinger
2019-12-15 13:12 ` Simon Marchi
2019-12-15 18:18 ` Bernd Edlinger
2019-12-17 2:01 ` Simon Marchi
2019-12-17 13:00 ` Bernd Edlinger
2019-10-30 20:06 ` [PATCHv2] " Bernd Edlinger
2019-10-30 20:18 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f12850fb-6eee-ea5c-adb8-684ca7644c7b@simark.ca \
--to=simark@simark.ca \
--cc=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).