From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47885 invoked by alias); 31 Oct 2019 16:53:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47876 invoked by uid 89); 31 Oct 2019 16:53:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HTo:U*palves X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 16:53:51 +0000 Received: from [172.16.0.155] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 434701E0A1; Thu, 31 Oct 2019 12:53:48 -0400 (EDT) Subject: Re: [PATCHv2] Make "skip" work on inline frames To: Pedro Alves , Bernd Edlinger , "gdb-patches@sourceware.org" References: <8fc93db4-8906-4f4e-53f4-225ebfa0115d@simark.ca> <215bbf9c-4c3c-5cd2-c657-51aa7262f234@simark.ca> From: Simon Marchi Message-ID: Date: Thu, 31 Oct 2019 16:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-10/txt/msg01176.txt.bz2 On 2019-10-31 12:42 p.m., Pedro Alves wrote: > On 10/30/19 9:56 PM, Bernd Edlinger wrote: >> +if { [prepare_for_testing "failed to prepare" "skip2" \ >> + {skip2.c skip1.c } \ >> + {debug nowarnings optimize=-O2}] } { > > Instead of -O2, could you make this use -O0 (the default), > and then use attribute((always_inline)) to force inlining? > We do that in some tests. E.g., gdb.opt/inline-locals.c. I think that's a good suggestion, but just be aware that there used to be some problems with always_inline, e.g.: https://sourceware.org/bugzilla/show_bug.cgi?id=13263 https://sourceware.org/bugzilla/show_bug.cgi?id=12429 I'm not sure if those are still valid. If they are, it might be more difficult that expected to use always_inline. Simon