From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 86B99395446C for ; Thu, 8 Apr 2021 19:26:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 86B99395446C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 138JQpAu020157 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Apr 2021 15:26:56 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 138JQpAu020157 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5E85F1E01F; Thu, 8 Apr 2021 15:26:51 -0400 (EDT) Subject: Re: [PATCH 2/3] [delete] Not-so-harmless spurious call to `wait4` To: Dominique Quatravaux , gdb-patches@sourceware.org References: <20210408191449.27434-1-dominique.quatravaux@epfl.ch> <20210408191449.27434-2-dominique.quatravaux@epfl.ch> From: Simon Marchi Message-ID: Date: Thu, 8 Apr 2021 15:26:51 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210408191449.27434-2-dominique.quatravaux@epfl.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 8 Apr 2021 19:26:51 +0000 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 19:27:00 -0000 On 2021-04-08 3:14 p.m., Dominique Quatravaux via Gdb-patches wrote: > As seen in https://sourceware.org/bugzilla/show_bug.cgi?id=24069 Hi Dominique, We try to make the git commit messages somewhat self-contained, so that it's possible to understand the change even if bugzilla becomes inaccessible. Can you please explain in the commit message what harm that wait4 call does and why we want to remove it? It's still a good idea to link to the Bugzilla entry, if people want to dig more. Thanks, Simon > --- > gdb/darwin-nat.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c > index 3ec881d3a76..9c6423ceb02 100644 > --- a/gdb/darwin-nat.c > +++ b/gdb/darwin-nat.c > @@ -1106,9 +1106,6 @@ darwin_nat_target::decode_message (mach_msg_header_t *hdr, > inferior_debug (4, _("darwin_wait: pid=%d exit, status=0x%x\n"), > res_pid, wstatus); > > - /* Looks necessary on Leopard and harmless... */ > - wait4 (inf->pid, &wstatus, 0, NULL); > - > return ptid_t (inf->pid); > } > else >