From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2049.outbound.protection.outlook.com [40.107.102.49]) by sourceware.org (Postfix) with ESMTPS id 68C883858D33 for ; Wed, 1 Feb 2023 16:01:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68C883858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffhqGqAWethy0M0BRY7RNr/HxGoJR6bFDZOBOuFFOmN2paWFC878HY/qrh5Yn0IGPPUiwQwjhRxRBQxC8dJTVUBWM5qJDFErM8//F/gsiH5mpRmvltGXjWP1gkYCfjOWJCId8ICbtnPwQjWaw9q31k4ZaZzcVWwkP50MgFfndwOPZ57AnsjcnP9d6j9aZAEHcFkh9D+NRD5bJQU/+FCl8YFf9qgspaykhmRqOrar3cemFeGCZqDcCFIzPYcr8N9EHIeo8WXJMU6PK9wSoTuhkuRpOlJ+ax7X0+m4ZqhQxP7u2cXRGYVmThSav/l/CTdISSM2dvxg9D2A6wf+CjlKuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iyy6n2PVkTBr38bs370xHYe8botn0Y3hatE9a446r+4=; b=Krsq7+K7zWC9J5f5D2jn/SLWiXIdFPYticZjiw7phWIetEYRmbhC8YS6NMtQsQuQ/6CA+yJoQFzcTpvRXitdKlHxHosHdQYshyT0pldHTYD+siZO4DDLQaWrI7/ETKQkB87sLmXbXsBCLaQTTNHJq7Y45cx9xuyTvFSknE249zQmg9Ae8EbUWt+QP9Y05WE2TliLAfXXVkVM8qd70VQGNInn+VuVR9UdS4gPBaj0VBeWcA0Lp+IMWq6BETTiEkeES6DHDtswbYw5jVPgi579pZzexRu0ujdBR3J0JJC9MZ35X/VgZDPepddDO+UDZFgEipudW8Eu/qfmNFlEC495Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iyy6n2PVkTBr38bs370xHYe8botn0Y3hatE9a446r+4=; b=Jx5zdHEwXbSZHr5mwSLjekjkcK+4jWPmZRJGKqmhAL0DOZ43jzPkAU7vJuSSeF6/99YLaS+/M9URTZkp3NjBc0vPzdvjyzV3p2cCIWET/ymuhhVseP4rrUwErS4MV1YzoSnt7yb1Ne4wwrwgQuEVJebQrcorP57NTfD1dwcnTEeoG05j1djIj96PYB6wC+OuPsah2usde39RVueaLPdULEvLFaKA7zSksbQnr36MoXNhUfkchueDYc1ftu84nF5M8ja3C+LKLMFjNIxivSJu6l0qLBvCCFiMgeZQxEBFS/8RwqqKHpNVa2w21KtlmYdAQ+0T6qR7udsL6OHZtc2trA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB8388.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:9e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Wed, 1 Feb 2023 16:01:19 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::ca4c:b759:c2f5:c976]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::ca4c:b759:c2f5:c976%5]) with mapi id 15.20.6064.024; Wed, 1 Feb 2023 16:01:19 +0000 Message-ID: Date: Wed, 1 Feb 2023 11:01:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/8] gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap Content-Language: en-US To: Andrew Burgess , Thiago Jung Bauermann via Gdb-patches Cc: Thiago Jung Bauermann References: <20230130044518.3322695-1-thiago.bauermann@linaro.org> <20230130044518.3322695-3-thiago.bauermann@linaro.org> <87sffpu04g.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87sffpu04g.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0167.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:7e::23) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: cf8374df-7c0c-47ba-0e5c-08db046d8e7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0ohxYjS7X3tw+tXMcqwWPTK3LZRBOtGXAlCrOR+sP+cyF9O8D173oAtE6PJqg6tdJneh6PaW46l8wc+0zUy1DZdB4edn795PpVNO/p6mcw1EHJQ/Cd7dPMKpsr62oFzqp6ElF1Uf31NfJnaSP0R1+j4oxMsfpdRQFDN9sIUY5sO6ok9WXubsp7gGkP3/XjBHMm9d1Z0KqzW8C1o7eR/IqP3mcHzErM3ieTZxEtjUewx5YOnwYYZKRyss836bjEeB4pqon+Dx2lr0KxPwvHpDikmZq8iVGUdImOidxsGZX28Hmrpb+8pSq3dCZBIurW+xtYyU2Fgm3FtYz5IoEzYe8p38yR3u9o15ZidogTpEzuzka3WhCoKD5E9sbt3QOOQo8u4X8X6zA9T37xIwKbDHh/fQZEdymxFbEQk39a8N426BtuaSijRyfxWZeimhfaFuMvvh4uiaulXNCJ/X1CAM4vezypVkKUUaijMMgmYNbvpYNfjWqcCIFCTq1o+H/90T/yjpLcjOLEDVTEqFefLJR6BmmqV/xyO5wCocIcQCQUO/zEnEaq8KAAWseWVRaOSxKi1nXHX1GBg4bAN1kGw/4XkvWWX6j43Qr62TB0DTtq1xCqyMT9aFFOCUn7dgoFQ8IkXQ/C8nbegNMvLDcuicmudpN5H5Nh4hndabw4wM6C6NnTWDcRlWArfaAHlU+ptVF3Js1ho+Bt4GiafwjfkVujGI96LZgTHmFUKVlmZz7OE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(39830400003)(376002)(346002)(366004)(396003)(136003)(451199018)(66946007)(66556008)(66476007)(66899018)(4326008)(41300700001)(8936002)(8676002)(6666004)(6486002)(83380400001)(31696002)(110136005)(5660300002)(478600001)(31686004)(38100700002)(316002)(36756003)(6506007)(2906002)(2616005)(26005)(6512007)(44832011)(4744005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YS9Zc1F0MjExZFVhMVNFSDFFMzBQYkl2Y1AwNU9HRHp1WEgyRERueXlxMkt6?= =?utf-8?B?bnhsSFExNERhZGEvSHROaHZENmt1SEJ6R3hrTEhUalg0SWJjT3g1RFNZeDB6?= =?utf-8?B?VmVUZi9GTkZqOXZjR0Nvd1VNR013d1JUUFBKbXowOVhUdUloOG9PZFl5VVBJ?= =?utf-8?B?d003c2Rqd3VZamVtVVU1aUZGS05JQXJZRUZCeWFoeXhhMXdCMW9FRi92WW5k?= =?utf-8?B?cWd0S0tSTFdkNjJFdDJMK3VobURoNE9SZVRWU0ZWaHVGTUhmdmxFUEczMXcr?= =?utf-8?B?djlYbmxaU05veFJpaUNwTzNsWmdiZlFWNGs1eVJYTUkxQi9LS09kYTBjQU8r?= =?utf-8?B?U2FqY0Z0MkwydHMrV0l3WXBLcmdGcFo2aGkvb0t0Y3N5SzZEeXVaQy8yYnhp?= =?utf-8?B?cFN4NVpDUmIvUHQrcjBadUoyTFY2Ry90TE1ycXBibHBnNVRVbThGNCtTY3Jp?= =?utf-8?B?Q2cxdTFrZE9oNlpjdExMVVpEaHd6cWFYbE5FdzNpZzFNMXcvVWdCcmg2Mk44?= =?utf-8?B?aUV5Y1BBbENwT0hpM3pKNTYxc0RCcXpZOTI1NEVlOHNDR3o1SmdNOVlRbWh3?= =?utf-8?B?RlJ3ZWZqN05DSjRDWEVmTWpvanBEc3B6ckFWMGUwU2ZLKzZYZGNkSnA5QUN3?= =?utf-8?B?aC9acnNGVXF4SENLa243aEVEU0VWYitCS0VCNjRDM2d0cXR0c0RwR1VIMERt?= =?utf-8?B?OHl2NnFIOHBpekx2N0U1RTJPTnVRaWpvVzR5ZjV1clV0TFlEU1Vsc0psTXdS?= =?utf-8?B?RWMzTkhOM1FWSklvcHd5ZHFxWlhBYzZvVGEveHNKbGpmbCtraWhGM2c3S0h5?= =?utf-8?B?bFpRNjI2RDdRWWdwOXlGemtRVVp1M2xrR0JSK3lsbVpsdHdDMk9IaHEvM09X?= =?utf-8?B?YzFjMVV1aStCcStlWUp0bDk0MDVWUnBuRGN2eU9lNzBjVXUveDRnOFRRakFC?= =?utf-8?B?SjVEMGpkWW84K2FhL2Y1c0t3SS9BbysrRHhkSmRsczhXMkl4dHlybEtzTExy?= =?utf-8?B?VzlLaEk1ZEtoYjNiOEhubWJCaTdrYnVUQkpraEJobkNieEN5WUNiSWZEcnc1?= =?utf-8?B?d1JxUTJwQnZDUFYyeHBXc0VrWlEwREIwQlI2VUFJTk1qNGdFd3FIYW1HTVNz?= =?utf-8?B?ZVpXOHZGVkpROTUxRzJMQUpJbitDYkovMzhQRTUwellVcm1LbVBsVlhkTFht?= =?utf-8?B?NmVMaGtHWUpLOHk1WnZ5VVZINE0yY3NUa2NFU3g2dTVBQkNkeGNrOEtzbnBU?= =?utf-8?B?b3d6VG5rUHhtZkswL0dyaUFPaUQwMFZIaWU4dWRKb0hMSHVBRDNVUGltcVVX?= =?utf-8?B?YVhLUlhRSkx4QjlFUjlsNTZ4S3NRbjZhMXQ2QjVudlJHbDhaMFdZNzJXc3dI?= =?utf-8?B?YkxmOTFtWURpYVlpaHdGT0NUSE1tWDJGV2RRSUZDc21xVFVGclE4ekVSU0ZJ?= =?utf-8?B?NUtKVzV6L3NJMUs2TUhnTHFuRm5DTURzKzZ2L0l6Wm1PU055aHE4SmJmUlMy?= =?utf-8?B?dzd0MmhwVTc1anlWNXByRlI4bisxQmdab05sS2hVekVCMkIyd1Ezdm9JMkNm?= =?utf-8?B?d3VEV2xWTVd3QXVYZUl1WkhmMzh5bWp6SytxOGlaakNOUzRjTVRQTFVDT0NB?= =?utf-8?B?b1Nwd29TamorYllVbWJvMWRadlZvSTdBTVNuWEFjM2Y0WVlXUk5sVEJGVDla?= =?utf-8?B?OWU0Rm1IMG9KSmdPMTlhc090OE42SWY0Ym12UExXYkFrWm1ZaW1FbXluZldI?= =?utf-8?B?M1Y4eTVFdlZqaE0ydkRZZ3RzRC9NdkRUamE2eEZGR0JqVU1Hb1BUK0V5WlNJ?= =?utf-8?B?WUJ5TC9zQ05QOVgwNXdYYW1RY0czNEdPbmxScXNTZnFPNTk2VFM1L0RVQVpO?= =?utf-8?B?TU9qMmFMMmpRcUtGaGRrOThtZ1VtZ3k3bU9hbTBJMXUyZSs3U1Y0MjNhWlIv?= =?utf-8?B?MldnN1BIOEUrMnBNT21RK3FQemp2Q2pERUFlUldkLzYxR01kZzA1UWlUalBM?= =?utf-8?B?eThMVUxyQlNqcDRoR3YrK3c5L0pQTlBQOG4wcGJWTHFWWmgveWtBMC9jUUdG?= =?utf-8?B?MkRLRGlqYkZZUjRjUVk1VXpxcWRuZzBOQ01BMGExUVJJeldyVnFaQlMwUE8y?= =?utf-8?Q?bbrNj00ziweiip8AsEE6ejEVc?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf8374df-7c0c-47ba-0e5c-08db046d8e7e X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 16:01:19.3348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SqCRyXWsLu7euRE3xh65sSBRfAtm7SyzFtXXamAFenghdVA9y6QP293V5H327clev4COAou6XdhAO7NNw2w93g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8388 X-Spam-Status: No, score=-3033.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> @@ -946,17 +946,16 @@ extern int have_ptrace_getregset; >> *VALP and return 1. If not found or if there is an error, return >> 0. */ >> >> -int linux_get_auxv (int wordsize, CORE_ADDR match, >> - CORE_ADDR *valp); >> +int linux_get_auxv (int pid, int wordsize, CORE_ADDR match, CORE_ADDR *valp); >> >> /* Fetch the AT_HWCAP entry from the auxv vector, where entries are length >> WORDSIZE. If no entry was found, return zero. */ >> >> -CORE_ADDR linux_get_hwcap (int wordsize); >> +CORE_ADDR linux_get_hwcap (int pid, int wordsize); >> >> /* Fetch the AT_HWCAP2 entry from the auxv vector, where entries are length >> WORDSIZE. If no entry was found, return zero. */ >> >> -CORE_ADDR linux_get_hwcap2 (int wordsize); >> +CORE_ADDR linux_get_hwcap2 (int pid, int wordsize); > > Ideally the comment for these three functions would be updated to > mention the PID argument. I think the patch is OK to push after addressing this comment. Simon