From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135441-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 128219 invoked by alias); 30 Nov 2016 12:46:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 128202 invoked by uid 89); 30 Nov 2016 12:46:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 12:46:08 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id BC9C17F6C8;	Wed, 30 Nov 2016 12:46:07 +0000 (UTC)
Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUCk6i6026337;	Wed, 30 Nov 2016 07:46:07 -0500
Subject: Re: [PATCH 21/22] Class-ify ui_out
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124191825.26147-21-simon.marchi@ericsson.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <f1a0fa51-0fbe-ec9f-e801-21eab202e4be@redhat.com>
Date: Wed, 30 Nov 2016 12:46:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161124191825.26147-21-simon.marchi@ericsson.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00981.txt.bz2

On 11/24/2016 07:18 PM, Simon Marchi wrote:

> -/* Create a ui_out object */
> +class ui_out_level
> +{
> + public:
>  
> -extern ui_out *ui_out_new (ui_out_impl_base *impl, int flags = 0);
> +  ui_out_level (ui_out_type type)
> +  : m_field_count (0),
> +    m_type (type)
> +  {
> +  }
> +
> +  ui_out_type
> +  type (void) const

Just a reminder: "explicit" and "(void)" in multiple places.

Otherwise LGTM.

Thanks,
Pedro Alves