From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <m.weghorn@posteo.de>
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by sourceware.org (Postfix) with ESMTPS id C3F68395B079
 for <gdb-patches@sourceware.org>; Wed, 20 May 2020 16:28:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C3F68395B079
Received: from submission (posteo.de [89.146.220.130]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 9DDE0160060
 for <gdb-patches@sourceware.org>; Wed, 20 May 2020 18:28:40 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 49RyqW5Ccsz6tmY;
 Wed, 20 May 2020 18:28:39 +0200 (CEST)
Subject: Re: [PATCH 2/2] gdb/testsuite: add inferior arguments test
To: Simon Marchi <simark@simark.ca>, Pedro Alves <palves@redhat.com>,
 Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
References: <1190e73a-8f10-dc6d-4d59-b9a2929530ad@simark.ca>
 <20200510155937.1064329-1-simon.marchi@efficios.com>
 <20200510155937.1064329-2-simon.marchi@efficios.com>
 <c367468e-9892-ced5-1b71-7a7d7ced8e9a@redhat.com>
 <e8c678ce-9714-6199-db7d-41c9f04f3bce@simark.ca>
From: Michael Weghorn <m.weghorn@posteo.de>
Message-ID: <f1da5ddd-5716-2b43-7d9c-04e1f6dbc094@posteo.de>
Date: Wed, 20 May 2020 18:28:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <e8c678ce-9714-6199-db7d-41c9f04f3bce@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 20 May 2020 16:28:43 -0000

I've just sent an updated patch series (v5).

On 19/05/2020 19.13, Simon Marchi wrote:
> On 2020-05-15 4:07 p.m., Pedro Alves via Gdb-patches wrote:
>> On 5/10/20 4:59 PM, Simon Marchi via Gdb-patches wrote:
>>
>>> +++ b/gdb/testsuite/gdb.base/inferior-args.c
>>> @@ -0,0 +1,8 @@
>>> +#include <stdio.h>
>>> +
>>> +int main(int argc, char **argv) {
>>> +	for (int i = 0; i < argc; i++)
>>> +		printf("[%d] %s\n", i, argv[i]);
>>> +
>>> +	return 0;
>>> +}
>>
>> Formatting.  Also missing copyright header.

Done in v5.

>>
>>> +standard_testfile .c
>>> +
>>> +if {[build_executable "failed to prepare" $testfile $srcfile debug] == -1} {
>>> +    return
>>> +}
>>> +
>>> +clean_restart $binfile
>>
>> This seems unnecessary, since do_test already calls it.
>>
>> Otherwise, you can use prepare_for_testing here.

I've removed the extra call to 'clean_restart'.
> 
> Thanks for the comments.  Michael, would you mind addressing these changes
> in my patches in your branch?
> 
> Simon

I've addressed the comments in this email, but so far not those in the
other thread:
https://sourceware.org/pipermail/gdb-patches/2020-May/168795.html

Please let me know if you want me to look at those as well. Handling
that wasn't straightforward to me. I'd have to dig deeper (in particular
how tcl works) in order to properly address those.

Michael