From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PUSHED 5/6] gdb: use libbacktrace to create a better backtrace for fatal signals
Date: Tue, 28 Sep 2021 19:55:11 +0100 [thread overview]
Message-ID: <f1dd4e64-07b5-a067-e031-89d1f8da5569@palves.net> (raw)
In-Reply-To: <abbbd4a3e0ca51132e7fb31a43f896d29894dae0.1632828191.git.andrew.burgess@embecosm.com>
Hi Andrew,
I read this now (for the first time, I completely missed v1!), and spotted a couple typos:
On 2021-09-28 12:26 p.m., Andrew Burgess wrote:
> + return function != nullptr && strcmp (function, "main") == 0;
> +}
> +
> +/* Write a backtrace to GDB's stderr in an async safe manor. This is a
typo: manor -> manner.
> +/* Print a backtrace of the current GDB process to the current
> + gdb_stderr. The output is done in a signal async manor, so it is safe
likewise.
Thanks for doing all this.
next prev parent reply other threads:[~2021-09-28 18:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 9:49 [PATCH 0/6] Display GDB backtrace for internal errors Andrew Burgess
2021-08-19 9:49 ` [PATCH 1/6] gdb: use bool instead of int in struct internal_problem Andrew Burgess
2021-08-19 18:33 ` Simon Marchi
2021-09-07 14:11 ` Andrew Burgess
2021-08-19 9:49 ` [PATCH 2/6] gdb: make use of std::string in utils.c Andrew Burgess
2021-08-19 18:41 ` Simon Marchi
2021-09-07 14:12 ` Andrew Burgess
2021-08-19 9:49 ` [PATCH 3/6] gdb: Add a dependency between gdb and libbacktrace Andrew Burgess
2021-08-19 18:43 ` Simon Marchi
2021-08-27 17:44 ` Tom Tromey
2021-08-30 20:33 ` Andrew Burgess
2021-08-19 9:49 ` [PATCH 4/6] Copy in libbacktrace from gcc Andrew Burgess
2021-08-27 17:46 ` Tom Tromey
2021-08-30 20:34 ` Andrew Burgess
2021-08-19 9:49 ` [PATCH 5/6] gdb: use libbacktrace to create a better backtrace for fatal signals Andrew Burgess
2021-08-19 18:58 ` Simon Marchi
2021-08-19 9:49 ` [PATCH 6/6] gdb: print backtrace for internal error/warning Andrew Burgess
2021-08-19 19:01 ` Simon Marchi
2021-08-30 14:16 ` [PATCH 0/6] Display GDB backtrace for internal errors Tom de Vries
2021-08-30 20:35 ` Andrew Burgess
2021-08-31 11:17 ` Florian Weimer
2021-09-28 11:26 ` [PUSHED " Andrew Burgess
2021-09-28 11:26 ` [PUSHED 1/6] top-level configure: setup target_configdirs based on repository Andrew Burgess
2021-09-28 11:26 ` [PUSHED 2/6] gdb: Add a dependency between gdb and libbacktrace Andrew Burgess
2021-09-28 11:26 ` [PUSHED 4/6] src-release.sh: add libbacktrace to GDB_SUPPORT_DIRS Andrew Burgess
2021-09-28 11:26 ` [PUSHED 5/6] gdb: use libbacktrace to create a better backtrace for fatal signals Andrew Burgess
2021-09-28 18:55 ` Pedro Alves [this message]
2021-09-29 8:21 ` Andrew Burgess
2021-09-29 3:09 ` Simon Marchi
2021-09-29 9:56 ` Andrew Burgess
2021-09-28 11:26 ` [PUSHED 6/6] gdb: print backtrace for internal error/warning Andrew Burgess
2021-09-28 12:26 ` Eli Zaretskii
2021-09-29 8:34 ` Andrew Burgess
2021-09-28 12:20 ` [PUSHED 3/6] Copy in libbacktrace from gcc Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1dd4e64-07b5-a067-e031-89d1f8da5569@palves.net \
--to=pedro@palves.net \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).