From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2124.outbound.protection.outlook.com [40.107.115.124]) by sourceware.org (Postfix) with ESMTPS id 45BEC3849ACF for ; Fri, 19 Apr 2024 19:45:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45BEC3849ACF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45BEC3849ACF Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.124 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713555912; cv=pass; b=qzZnf5UmFt8JmvOs8Mn06yi8XFRs87GVBoH810qHYLGBwxsOCYOQrot+WdV6eXB+gflnnuJ+Yvua29Ra4mhWX1prb2A3r4rIeXBk5wpKQs4e8qVQ0I/sDjzr47kdGIE1d/kQMtdjM8bLbJASJk6ph8z6b3ftksMVcZBWKwAcgiY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713555912; c=relaxed/simple; bh=SrK+3vObQ8gKUuJGO0hKPuYQboWmk+aQUPj9KY9/SRY=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=B9vfSsgo1oeWDtTXbMPzjHlUXEJu8V/cfw9vw9/rc3yPxW8R/6WP8nqAUcwM90OjMLrkorBtYo5q6J0ITKHQTLB/iq1BDo3gN1OAmHE/x8CYslKgEQi4yKjAqcLUQ+VMdLSDahlKm1nTzyA221/OWvgLIvKB3SlO/iOrycx+lcU= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RzcpWAF/zNJfvUTgap40YKmkEsptym6liye71uq34Vk6nJfNfwMGnayBeGgKkZKgQXb6RfRdy9RN0KXis2qwVmErgY9sF9UtK/LKA29SOzUlHqe5W+iYzOlN7w6V92t1+qI0M4q8Crbo0Wv/JhFxSkkGmbe8ZhtwuYYV1uyv4Qdn/Rnh+LmHzGd9/mvTPQk3vcRdniPwuJXRRVwRTRyJ+hyEIgql09EmU2sfKSxoTQP/My2gEsABo0Z8Ymh+7JL2BwP4R31P9zSI4y6tI1yxTsof1YIwFnR1zWryFPZZYMwplrcYuQT5Yub+eL2vGG8WJkFuyM9TjnZMGZ0sl6jlUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62V/QobX1RObhTpeLk8U9kKBmHOobKpEAd36WymEcTw=; b=ERhkaseRozHc4t07Z78ZyBWPrkMprs+u6J++UgAxRSMJS5ICcArSgV4jGvP14B2+f3abueT9TWgz6HxoBrW1uDa742LJXhpQ5PF6dI1QmLrdOYonL2G/fJrwFDKVn3DLPtX6UV28IvZCxHLkU8fBrTAieJp1C6QuwfOhkF+n8up578bdkG7lPJknfYw7fCRAynPOg7xyWx693E/5tnO65Spi23Dk7L7NDWWPZz3DuZfWMhFPCFq9ydjWkGqPxvXgKUpt3pcxdml2Kl0X4gKSvZMzhZ/UKIqEeVn9qsWoPXAVPuQmRTei1bv5DwpcoB9suEpybDxovneSzv2Kx+O+mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=62V/QobX1RObhTpeLk8U9kKBmHOobKpEAd36WymEcTw=; b=j3MKy1Wu2zgbqRdGQ/GjphGta3fYtFCyjVwN9G6A0syRj9xDg8IdmB3t1pwzeudpqDOCb8U3pFrgoxOvN/ROmE/MeOq07X0tBhSWep1SEb2t+VRxcXQ3ZPe/7qGsSnb8SicaJd2JFlHnGSS44o4vzOea9oJrienNlWkBH83JWLCosVmeldzzEzw4E0qxLmgz9tsy62j2j3rPmOhvmlnMV8XAytPz0VyHizcBIFP3P1EWBrfWtkmr31vJ0vppAZ2ImvQoMclMq6hvMyRPMh8d9MVUr26XJOr3WwaKFbrhUDVOZTQO11NULmYwwZQ4I1URcY7KIdzZbR15i7VGK75xcA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YT3PR01MB5569.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:62::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.16; Fri, 19 Apr 2024 19:45:08 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1%5]) with mapi id 15.20.7519.010; Fri, 19 Apr 2024 19:45:08 +0000 Message-ID: Date: Fri, 19 Apr 2024 15:45:07 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] gdb: make regcache::debug_print_register return a string To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240417205426.2030615-1-simon.marchi@polymtl.ca> <20240417205426.2030615-5-simon.marchi@polymtl.ca> <87frvhupeq.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87frvhupeq.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0117.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:83::11) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YT3PR01MB5569:EE_ X-MS-Office365-Filtering-Correlation-Id: d30672c2-c1c3-4d0a-74fe-08dc60a93821 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: 86FBdzQ4HlAKttEjzBrNlPlZhaxnXpj1mc4q+Dw6iWWT0t0v8XU4J8XJqq5oo5qW7cIWDU0xhmJrU/7o2Y1ZEk7RkZVS6NU4rfIOBaE7b8oaesPuYOoNIYPXHKNIAezBVQ4aUD4T3GKuKx90djn/IxGCUlOjlC9OzwVyFs764JoKZtUXAzRLi7aQMoEMupmV7d/OvQx6/lq0IAI+Yd7imMtMhlKRfqyem1s/PexqfAycYd1fBqy63z7Sa77QNGZnigip6ACaJNML0HK9tWFvNw12LSl06a3oshThov8cxQ2rp6GtQbflqqnXYQ8OwHxFFeNNmlOao/o4Ii3jmzham/uKsPCSkq3Ba0T5gI2KHbMnwTSHVkTf5RcoinfLoStHVvXNoLWyhGvn+wZW0KDqw4LQvZUZdiDKg/qnzncbqPT32KYRAsY8TneOdcvUznncMpgBFGg+vtrNKngCXEXWUCMshcCBr8flKHmg+F7CcTdtcSBLf9H6dwn8FKMftbwrwArJm3Mkm8elT0X/fFraKLCiEZzUklt1JLYR0Tx11/jSk2zi6LnvWy8OD6RN9ztToMJHjx3wq8sYkJk8Rdfn0gvLxsArEBO7xZySmXTNolv3oUgyM5foS40BYRZ21ufBF2so6dJUrGivv03PlLwacVtrtrUUANI2ToD22hjEH1M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clNZWG8wZXNPdUZKMGs2Mm05eVlJaVRZQ1hDWmV0VFlxMVBCWFJsaEZaUWEy?= =?utf-8?B?QlQwNExnN2pTK2JSZXpHK0kvSXBkM3RPcS9vSDI4SmpJalBib3QrYklSYmdB?= =?utf-8?B?dmQxQStaeEU3Y3U5WUd4YVc5dTU5V2RVcmVXRWljVTNJL2kyOWNnbkJTR0J5?= =?utf-8?B?YkhsMWUrY1h2ditNL2FKSWZFU3pVOGJ3ZUEzMTBIYkpaaWlWd2xRQXprdXNN?= =?utf-8?B?UlVVVE5OQzlZTnBrejI5T010UVVjUStZSW9YY1hpZWQweTFKNkVrdEFqc0E5?= =?utf-8?B?a2lMeXFjVWErVnZUQ0g3U2JTYW8rY09Bd0tFcFVLb0dybUFVK0RTYUFOeExD?= =?utf-8?B?QVd6ZnBoSkJibmRJQnVCTHVHRm0vdTRSY3c2ZXFrQTlKV0xZNXQrbCtTelJ4?= =?utf-8?B?Nlh1Rm9JL00yNzNwbytLSmNycCsxdGhYQ214TVdCZ0djZjBqMXhlYWFjVzRH?= =?utf-8?B?L2syM0I4eE9Ma2VYc05teDVHM1k0bEhFdjBwK1lSYlBlNWt3UFVoWVVLMzJu?= =?utf-8?B?d0tnSTVwRFQ0N2V3TmMyVkQ3RTVmdUd2cnBrRi8yaDBpL3E4K3NwSWhxdEww?= =?utf-8?B?ekdvK1BHazVQWU5GWkZ2blVwZEdEc21xZVovNTcxR1hpRXhaWVpVZXUvcFRk?= =?utf-8?B?L0hmcTlTQ2ViMXJwaEtDWmJEN0E4bFBiVnJYRmRMTWY4aGd6Z1E5a1Nid3FJ?= =?utf-8?B?b3ZXQ1dFOTYrVVBiZ2VnVm5DVWxLeCtqR2kwbk56UHl2MzB2dmROV2Jkdjc0?= =?utf-8?B?TlNxRmhKS1FOV3RYRUlQUkFCSW44S3FSYk9nN1VrQW16dVVTRVJwZytPTGUr?= =?utf-8?B?MjlDeXhENy8zRlJkV3BaZkFUaENtRnpsNnBWY2p0YThLekVhTnU5TnBGdjUw?= =?utf-8?B?UDlXR0dST0hDSmFnNm1KUVNGZC9aamlOU20vcHlNRW9yY2VXRG5yVEZRNjU4?= =?utf-8?B?VGo3QStrREtydjlQeWYyRXprZHJxdDk5MG9hbW9NNjZBeDhibHJwbUhPNXk1?= =?utf-8?B?QVVVbmtSUnpWOElBcmRLdklQT0U1MU95RzdBcHc0U2JuQmM2elNiZ2wxNW8r?= =?utf-8?B?YnFzRFJidFFEaWlLSEJDMk84bmxGdUt4eVkybjRlRU1BVUZUNzBnSExTdGRJ?= =?utf-8?B?VnpTK2JkNmJhSWF1WGQwRk5IWXhZdVg3dDhpYkZvQW9NOVJhTk56WlFQT0ZJ?= =?utf-8?B?V3dZWC9Jd2NzMXJEajgxMmxsSmpTNmxKUHJZYnJ2c25UcUJXSlVoOFAxSDJi?= =?utf-8?B?VnIyNk1NZk5FZ0hGcjBHcWgzTW5Ma2hYMnlNT3lWZzArOTZzM2R5STI4Z1hV?= =?utf-8?B?NDFNK0pXRllBM2txN01sSldleDE5dlhWbjB0MVFrR1N4YzZVaVZBcDVOUTJD?= =?utf-8?B?eUhPTjErSlJuZ0t3TXZONVdjcTJ5eHcyK0p1TGtEOTAzUEE0bUhEaDIyam5V?= =?utf-8?B?TlRQLzlBRFFjOWVJMXZnZDBmMGpEUlN1RmgwdGxiYWxTNXpJWUc5L1Y0amdC?= =?utf-8?B?REEraGtlVlZKOCtxeWNxc1VYcU55ZHNETWF3akIwSytiazFuR3pTbGxSVGFw?= =?utf-8?B?cUV3M0xMa3gvVnVCVHZFVjE5K0NLT1NrRTlJT0lLTU81bkp4SjAzQkx3TTJ1?= =?utf-8?B?ZzIra1hpNC9nQy9HS20yMkRMMGxjM3VCaVJ0LzlFbXl0L3o2YlNZazIxY0c3?= =?utf-8?B?VTBhZ2o5OG8vVWprbFZPODI2U2ZGNjVHWVJYSHZqY2lBNkFuelB1K2xPUnox?= =?utf-8?B?dFRFRzZ1Q3BuSEVKVXNuWWtvNG9kdGpzSDR3VFlXRHh3TzdmczJlNnBnamtP?= =?utf-8?B?UzVqOWd3OGR6bmdmOXRXSFlRK080YURvZ0hyRkQvU0R5NVYyTDlWTFRMR2NC?= =?utf-8?B?UUpYRGJiaTRmK3VIVittcXJoaUdrRjE4SFdXdmpacmhSVGxQU3JmQSt5bDIr?= =?utf-8?B?eWFjV0NBSmU2Y1R1VHhSS0JQT1lSbk5IY1lEUDdSSFB5SjIwMnZkYitjamJ2?= =?utf-8?B?ZXdad294OVNoZi9FUGVhYlZsUDl3MHdIWFNXa2NHd2pXb0hhdlZWUTZidlZX?= =?utf-8?B?REFCQXdPNEswSWQ3aE9zUFlXWnJZY2lubHgvdGU5UEMxOGRld3lLMk5VTFpW?= =?utf-8?Q?VnxG2IlUNrlNINNAao1d1zf5G?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: d30672c2-c1c3-4d0a-74fe-08dc60a93821 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 19:45:08.8271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3q+VVKKyDfdHHggs1kpgPZ1hUNumZecKD6oSLdVQ5ZJPassppBgMmXyefypD2h+skQl63n81rWf1y8cLuqUEpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB5569 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-19 15:24, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> From: Simon Marchi > Simon> This makes it easier to introduce `target_debug_printf` in a subsequent > Simon> patch. > > Simon> -/* Dump the contents of a register from the register cache to the target > Simon> - debug. */ > Simon> - void debug_print_register (const char *func, int regno); > Simon> + /* Return a dump of the contents of a register, suitable for debug output. */ > Simon> + std::string debug_print_register (int regno); > > After the patch this seems misnamed. > > Tom Ok, I changed the method name to "register_debug_string". Simon