From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2047.outbound.protection.outlook.com [40.107.212.47]) by sourceware.org (Postfix) with ESMTPS id A44003858D20 for ; Thu, 17 Feb 2022 16:07:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A44003858D20 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UyZvMqjkIcY8Uga/uCv52zYM89xTHR8T0xPmIZPbiycZSxRRCxUB0/ioyOywLTo9a2MGvJSqCn420VC093KfxV/FYwSUOQcAHx+3LtWVOnCRb2ld0/geaKUazjQHrFPKuPWwo2+5U13qzTSIr2kJ+22fpQApNekkfNHZd/fvrXXHDa1PyBSJcfSmdnTMApjQefArS9vxT4NMKk1lqs0jzKW/2fb/D1t1MC8ejepIxyBlVJKNIbVZdm6TOoNL3jCDku3W7f/Vw8e/yTw75tW8YpSgGjH5ulbYl5bVupJ1HXB6JSeqoFF6qAl8tEcGttCPYhNh+7lR4Yxi2m86VV/CPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uu0ZIXG6tUWrAgdrt2zERsEYYnHxxUnxmgKZEtVtGrc=; b=b+MfnQAmb73LV+nLsvfvaflzZdsuzz28Rb4J+1xIB1HW4tyNA2GHNZUC5oZVqLX0cfAWAcKln6GJuWJxgDuPWEgWldbZKBDl3AA01BEQlP0IzeZhlErZ432DzikaAJp9Hg3GLqR1EsB+c5k7jCujaUyImKutd0VTMvbb+Z3HqfWI83IlucKxs1zb34RQU3m1ZO+eRyNrMH1QBe8QsJ8MxyXAdoEDHwK91Mg4YMzdl4pGfWxOGpejCLYXlEsgtDixG2Q1JTzj4G/oLK9GBjH9Edgri9x/Znb12/MD91794Kc4swYVkae/y10ZNWsCixiRQutmDqv7y90NqSxSYsQRmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labware.com; dmarc=pass action=none header.from=labware.com; dkim=pass header.d=labware.com; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by PH0PR17MB5455.namprd17.prod.outlook.com (2603:10b6:510:c7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 17 Feb 2022 16:07:42 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::78f9:3a56:7d30:e2c9]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::78f9:3a56:7d30:e2c9%6]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022 16:07:41 +0000 Message-ID: Subject: [PING] [PATCH v3 0/1] PR20684, preserve user selected context when invoking MI commands From: Jan Vrany To: gdb-patches@sourceware.org Date: Thu, 17 Feb 2022 16:07:34 +0000 In-Reply-To: References: <74e5b388-9f7a-dd0a-befe-3b069fba54b7@polymtl.ca> <20220127145011.1153142-1-jan.vrany@labware.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0159.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::20) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b8ef046-defe-4b5b-49de-08d9f22f9fff X-MS-TrafficTypeDiagnostic: PH0PR17MB5455:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wtBsxfUjUoYvBeCYueFpKU7lWjEOmu4nFVd/aF97RCCzsWDgWSl3Atl+6AqT6BJ/3PHEEQ/tnAmM36Svd/vmrEZ5Fa/XJERo+fUBBxbH5JMMJ1yARryN2VwdAas5RfSXDf85WCXwI55r4vVR8iH7iumHIAZaBw1Z+KDI+1Mn8SqGM39dPKc/j9UhRpkm+5DHm/JT2wnR++CLHnIvVzvNKK3nj5bHRJGCFlTFKFWs/wLpdzi6m1g+yVq9kfj99Q4ZBkrAtgHlm0Sk+tGqX6i5/bEsI+bauVZ/agiXCsydWBwy2NR1Y7Pb8ky8nW+/byfkByQj29Zc3mKlut2Wzx7uD3aZeg8uyl42c9iKvyOd5BQJve1Te0dkagc0QS5mIs4aVUxoqAKrw1MOnjMgPmzZYPquKyX4uxHKAcak1Udw/BplS5w7JaxpI5WkWAUAVq1uBccLYNCDANm2j7Aj7Kzwe0WQTmpVBMgTwtHXa+OLtKcszq12iSD78LXCKPQNdvOA/YFoHiETGFBCKtRdlAJSYMEyxZxsrs3CJ+eJ8Y64VyvCTa8NPkd3HTB11RHLjmPOmu7+or/LNbxE6Rda0dyQk1VNM8irAOjK3knFwrvGWlQWa37NnFme/zILfRH7cD4SvGyFcQSwydGYVa/efyHlNNQR6HEwfxIap+7tmN4gyaQgKhpgjuGRWjtC7E0OiM+V/Y94JpF3LL3yXT8oUI8svRgonoLr8rCN54qwHCMCfjaFlQY4SpD+VBDrOWb6Z4YW0eAtZgAePm3vQzxZ6ZmVJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(508600001)(6512007)(66476007)(44832011)(8676002)(52116002)(38350700002)(6506007)(966005)(6916009)(316002)(86362001)(38100700002)(186003)(8936002)(2906002)(5660300002)(66556008)(6666004)(83380400001)(26005)(66946007)(36756003)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NExSZHFXMFYrWE00dDZyaFhDcHA5UGlrR3R3dkZUbTdPOWtmZlBreXFtaW9R?= =?utf-8?B?R1lCSnBUQkRaQTZLMFl6ZENmR2Fmai9pRGxBbGdxTllteEVJaXlDakhEanFW?= =?utf-8?B?K2hGMFNxamorTzZYT0cxbjJMUlRYOGx0ODBPR1pSRkxpTmVpYXVabkQrS3lP?= =?utf-8?B?N2o1aWR2V3pDNVlBU05HbkgxNXlJbDR4RVE5VFE4NWc0T3VsSUhURTJqRVQv?= =?utf-8?B?UmV3ZjNhazZYd2wwU0l4TEg5RTdrQndDcVdxT2ZhTjh4LzVkVVc3NndIeXdM?= =?utf-8?B?Vzl4Sm04dkJrR0NsRmczTG5hRmNwU3hmejFTWkhxK1VMUWlMNmpaZWhWTENv?= =?utf-8?B?VnhyckpRS3Fjbm1LbUM3dFNsRjhhREN0c2VFYk1pSFk3SktEa1lCWDc3V2FU?= =?utf-8?B?YWc4TWU2ZGZYMEVDR0NmU0JMRE1IZW4zczhNNnkySnFwUEJEN1U0VTdzYlVx?= =?utf-8?B?Wng2b1VpYzFnUlRkenl3SGRsUnBjTW9sR1BiL3hJY25DaXp1QXYzSk9PeExH?= =?utf-8?B?OHhsUWJ0UjFmc1Y3ZHZRNDZJWU45YmkyWFdPWEtBUWt0R1ZBQmpvbmtSVEFK?= =?utf-8?B?UmFpR283ZDdRVTJPdkt1WFM0c3B5alRlcWE4elNaOFVRUm55eDFhODlteklE?= =?utf-8?B?RjBLVURhWnZnWW9CdE9DRWdLSFo2eTRsWHlGR0ZMOHZLcXhVSFh4VDUyUGZr?= =?utf-8?B?bVp3N1R4V1NXRURLWGdzUlIwZ3h4Z3lmdWczMkszZ0R6Z3prVFAzUGZWeDhm?= =?utf-8?B?YmFyNjF5czFEMzBjZ0w1UURhSEZrUmpjOGJIeCs0Y2hSUnFrQ2FjVXBRaDBG?= =?utf-8?B?K3NGZXRHZ21vWU1HelpFYlNEY2Yyb2g2eFRkVnZwNnh1YVJQcWNXUmw4Y2xM?= =?utf-8?B?TStPZFp4MVlLbnNzTFFzZTlJeWQvU29CTjFOaUE4UDhJOHVXWGhOUnRKclpz?= =?utf-8?B?N21WTUtYQ0VCUmNnWTN4ckEwYzdyRmlhR1lET0FVTU5TWnlxY3VqNXh2RGFv?= =?utf-8?B?SVJQVWR6T3J4Z2pOZG9rT0NXNXBra2FlZmgrUEJ4K3JXUFRoRjBSQmo2YVRv?= =?utf-8?B?MEd3YWY2cXIycFJuWGZVbmZCeDdrNWdUSDlHUHpDUkE5SmU4UW5IaFpwUHVH?= =?utf-8?B?bEZ0MXQ5VllRZDVtd2pIeU5TTVVUS3JaTDMvbTlhN3Y4UUJqUy9ObmFvMGg3?= =?utf-8?B?U1ROZG96eHpoZVQyTHZQNVJMOENFMWYwT1pzREhvR3huMFB6aSs1MjdKSDFK?= =?utf-8?B?QWl5TFd3T0IxUDFscTdxVlljN1BDMVR3d2JNK1lEN3BDanZKMzRDanozeFFp?= =?utf-8?B?eXhTc05Uci8vV1pUaU02TFAxWE1kUGlkSW9Qc1hGUlVESW9KdmFTUHJMdXZJ?= =?utf-8?B?NFBWUUNUM1dDMy9MK2U3bCsxcWV0UXgzd2pPSkRBMWRiTmVFMkh4dUtyRHhT?= =?utf-8?B?NFJKYTNHTC9nTGxUb0UxY3cvZmgyekdPeUxlclF1dXJPMDMwTG5vaTFRT2xK?= =?utf-8?B?aEd0dGI4K3psRnNiSzhBOVcvZzFSUGdYNmp0ZG9TWEJZb04xRDhUYkgvdGtV?= =?utf-8?B?MS84djkvaDFkRFBqaFd4eStQNTlINGt6d1RySXNvcnFSWmFEUGNDUkZwR3hX?= =?utf-8?B?dzBpNThTN2Jxcm1mUVFoREpuMitLWDdWdVZBa0IvcWUvMng3SFNKaC9DQjVS?= =?utf-8?B?UWliRk84K0RBbFF3Rkh6YjIvbnc2cEN2Mkp5bEtBSWRvYWNEWDkwTktqaXRj?= =?utf-8?B?MEFIdGF0ZG9oZS9wN2NxMmsvSTBKRE81Mk4vTGJyVEx1KzMwcjEvNDB6OFRo?= =?utf-8?B?MTZOT2JIdU1uZmlFZjlWTndrUVFHTGQ3VHlhNXV5RGs2U2lBVWJzbk4waS80?= =?utf-8?B?bERyOUhsU1lpdEpDWDZwelFPdkMwRkhIWmk5d0NiS3hSTW1KOFc2TlRPSlBH?= =?utf-8?B?aDRSK29sYktSY0pjMWpMa0hpT0lFNVdmVVhTc1g4UXNadjdkTjY2WCtsazVV?= =?utf-8?B?akRDejhPWUNuaTZCd1VaUGNaNGJtWldvRTZKOTF6SUp2aXNYVzc4SURjejdw?= =?utf-8?B?T3dzdUNDYTNkQ3htUVJackcvbmppd0ZEaElzUjZjQ05RaWs2OTgxOE9GNkg3?= =?utf-8?B?QXQxZUxmNXE1ZEd1SXVucUJueHYwY2ZmZThSQ1pEQmlRVVE4b3dVOThGdHJL?= =?utf-8?Q?2TB66g5o8LNmNZU5as9AcYY=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b8ef046-defe-4b5b-49de-08d9f22f9fff X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 16:07:41.6171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lwknVEI5rQoXLXSTtjCU/MesFrBkr797IBE1RNxxtw/dcNk7Zsphr/l6tmOx3yr3az58S+6vyvfutwDS5KUJrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR17MB5455 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 16:07:49 -0000 Polite ping. Jan On Mon, 2022-02-07 at 11:56 +0000, Jan Vrany wrote: > Polite ping. > > Jan > > On Thu, 2022-01-27 at 14:50 +0000, Jan Vrany wrote: > > This is a next version of the patch fixing some regression > > > > Changes since previous iteration [1]: > > > > * updates to accomodate new C++ification of MI commands pushed in > > December last year. > > * updates to handle cases pointed out by Simon > > * add testcase > > > > Changes since v1: > > > > * address Simon's comments [2] > > * add more tests for -stack-select-frame > > > > Changes since v2: > > > > Fix regression in mi-nonstop.exp and mi-nsthrexec.exp. This > > was caused by extra user selected thread notification being sent > > when resuming a thread like: > > > >  -exec-continue --thread 2 > > > > The culprit was this part of mi_excecute_command (): > > > >          else if (inferior_ptid != null_ptid) > >            { > >              struct thread_info *ti = inferior_thread (); > > > >              report_change = (ti->global_num != command->thread); > >            } > > > > This "else" is only executed when command specifies --thread. > > > > Imagine currently selected thread is thread 1 and -exec-continue --thread 2 > > is issued. > > > > BEFORE applying this patch, no change would be reported because mi_cmd_execute () > > would switch the thread to thread 2 so `ti->global_num != command->thread` would > > be false. > > > > AFTER appling this patch, mi_cmd_execute () would switch the thread *and then restore* > > back so `ti->global_num != command->thread` would be true. > > > > Therefore I removed this whole `else if` branch: since mi_cmd_execute () now restores > > the thread if --thread is passed (except few limited commands that notify themselves), > > this condition would hold each time thread passed to --thread is different than current > > thread. Removing it preserves the behavior. > > > > Removing that "else if" branch allowed me to merge two nested ifs into one to (hopefully) > > make the code simpler. > > > > Thanks! > > > > Jan > > > > > > [1]: https://sourceware.org/pipermail/gdb-patches/2021-February/175897.html > > > > > > Jan Vrany (1): > >   gdb/mi: PR20684, preserve user selected thread and frame when invoking > >     MI commands > > > >  gdb/mi/mi-cmds.h | 12 ++ > >  gdb/mi/mi-main.c | 54 ++++--- > >  gdb/testsuite/gdb.mi/mi-cmd-user-context.exp | 155 +++++++++++++++++++ > >  3 files changed, 198 insertions(+), 23 deletions(-) > >  create mode 100644 gdb/testsuite/gdb.mi/mi-cmd-user-context.exp > > >