From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 173A93945C14 for ; Tue, 15 Nov 2022 23:46:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 173A93945C14 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AFNdu1h016674; Tue, 15 Nov 2022 23:46:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=l1UvKQT6WfOF5HBL+l/rBFO6b66z5pUdZTRw0yHZnx0=; b=U2reR9Hia2d2r191Zio1FCgWAGL/EVFsPuvgzG7qi9vwBIgdL7DhqeS83seIYUQL9aFc NmUU3ti4RPKPlctn3A8n4dT/7uKruF4yhgFA4DAkEHAdLrGJxYWCqFa+RYRiZDj9cwGP +RpkDT+yWoEKEUo97AjLDL20ER2QYBnAig01ty4r+cSZv/8vo0/ZyGZjc6LcsiwB8Ja3 ONIwZi4Zph4rF0uluiBs3CcvDYV0yC8d8qquhHNrKioGaLjyB+6ptSQcMLnlzrnXtlvT eZBF3jOMtCSXtaWwS8IVu8nDgKhp/roT5UMrZHAfOCJPff0V50uDW+m2490ayKK828vn 0A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kvmmv04cq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 23:46:42 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AFNiujk014558; Tue, 15 Nov 2022 23:46:41 GMT Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kvmmv04cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 23:46:41 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2AFNYkRF024241; Tue, 15 Nov 2022 23:46:40 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma05wdc.us.ibm.com with ESMTP id 3kt349y7w4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 23:46:40 +0000 Received: from smtpav03.wdc07v.mail.ibm.com ([9.208.128.112]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2AFNkc5C62456318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Nov 2022 23:46:39 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B57CE58058; Tue, 15 Nov 2022 23:46:38 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DBBC45805C; Tue, 15 Nov 2022 23:46:37 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.52.7]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 15 Nov 2022 23:46:37 +0000 (GMT) Message-ID: From: Carl Love To: Simon Marchi , Ulrich Weigand , "gdb-patches@sourceware.org" , "tdevries@suse.de" Cc: "kevinb@redhat.com" , "will_schmidt@vnet.ibm.com" , "blarsen@redhat.com" Date: Tue, 15 Nov 2022 15:46:37 -0800 In-Reply-To: <4f9bbf3b-6a82-ea6f-7879-c1041539a3ff@simark.ca> References: <2db5ad69b32f4cda9c53b252ad37cd783f827c14.camel@de.ibm.com> <7f476265-c6a9-9fcf-ce13-ff550ea5e6f6@suse.de> <6ed2cf1714e5b8dc386e66b634b540efdf828ed5.camel@de.ibm.com> <4c6fc2c2180e0d470d8e70801a91a7ee234c5b68.camel@us.ibm.com> <4f9bbf3b-6a82-ea6f-7879-c1041539a3ff@simark.ca> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: FDh7NGztSr6MngX3P9-ODV5JspBChm1z X-Proofpoint-GUID: FK8CvnjsdYsjnn3luc6JGB-Ob_GPpNGT Subject: RE: [PATCH 2/2 ver 3] PowerPC, fix support for printing the function return value for non-trivial values. X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-15_08,2022-11-15_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=920 clxscore=1011 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 priorityscore=1501 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211150161 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ulrich, Simon, Tom, GDB maintainers: > > Just so you can test properly, I also see these failures that are > likely > due to the same bug: > > UNRESOLVED: gdb.base/foll-vfork.exp: exec: vfork parent follow, > finish after tcatch vfork: finish > UNRESOLVED: gdb.base/foll-vfork.exp: exec: vfork child follow, finish > after tcatch vfork: finish > UNRESOLVED: gdb.base/foll-vfork.exp: exit: vfork parent follow, > finish after tcatch vfork: finish > UNRESOLVED: gdb.base/foll-vfork.exp: exit: vfork child follow, finish > after tcatch vfork: finish > UNRESOLVED: gdb.base/sigaltstack.exp: finish to throw INNER > UNRESOLVED: gdb.base/sigstep.exp: finish from handleri: leave signal > trampoline I have dug into why I didn't catch the issue earlier. Looking carefully at the regression test output, the foll-vfork.exp, sigaltstack.exp, sigstep.exp and asm-source.exp tests are all failing similarly. In the GDB regression test output I see: Running /home/carll/GDB/build-non-trivial/gdb/testsuite/../../../binutils-gdb-n\ on-trivial/gdb/testsuite/gdb.base/foll-vfork.exp ... ERROR: GDB process no longer exists ERROR: GDB process no longer exists ERROR: GDB process no longer exists ERROR: GDB process no longer exists Running .../binutils-gdb-non-trivial/gdb/testsuite/gdb.asm/asm-source.exp ... ERROR: GDB process no longer exists Running ../binutils-gdb-non-trivial/gdb/testsuite/gdb.base/sigaltstack.exp ... ERROR: GDB process no longer exists ERROR: Couldn't send finish to GDB. ERROR: can not find channel named "exp17" Running .../binutils-gdb-non-trivial/gdb/testsuite/gdb.base/sigstep.exp ... ERROR: GDB process no longer exists The failures then end up being recorded in the summary as "# of unresolved testcases" not as "# of unexpected failures". I can see with the current mainline code base there are 8 unresolved testcases. I updated the fix that I sent to Tom earlier per the comments from Ulrich. With that fix applied, the number of unresolved test cases drops to 1. If I run the regression tests with the tree backed up the the commit just before my commits from Monday, I see one unresolved test case. So, clearly my commit added 7 unresolved test cases, the six that Simon mentioned above and the one from Tom. The original unresolved test case is: Running .../binutils-gdb-non-trivial/gdb/testsuite/gdb.base/gdb-sigterm.exp ... FAIL: gdb.base/gdb-sigterm.exp: pass=0: expect eof (GDB internal error) ERROR: Could not resync from internal error (recursive internal problem) I always check that "# of unexpected failures" did not change with my patch applied. I didn't notice that the number of unresolved testcases changed and hence missed the breakage my patch caused. My bad. I will be sure to watch the other stats in the gdb summary a lot closer in the future. Thanks for pointing out the failures and the for help resolving the issue. I will post my updated fix for Tom to test/review. I think we have this all figured out and fixed. Sorry for breaking things. Carl Love